From mboxrd@z Thu Jan 1 00:00:00 1970 From: rain1@openmailbox.org Subject: Re: On my way to my first patch, need review Date: Sun, 27 Mar 2016 21:29:58 +0100 Message-ID: <089d71f80004d480bc4f10b9778688fd@openmailbox.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akHKA-000748-6k for guix-devel@gnu.org; Sun, 27 Mar 2016 16:30:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akHK6-0006dS-PO for guix-devel@gnu.org; Sun, 27 Mar 2016 16:30:14 -0400 Received: from smtp13.openmailbox.org ([62.4.1.47]:55717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akHK6-0006dO-GT for guix-devel@gnu.org; Sun, 27 Mar 2016 16:30:10 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: vincent@cloutier.co Cc: guix-devel@gnu.org On 2016-03-26 22:49, vincent@cloutier.co wrote: > Even though I don't know if I am accepted for GSoC yet, I thought it > would be nice to start contributing now! :) > > I started by adding the gem wayback_machine_downloader (a very useful > piece of software by the way). > > So I used `guix edit ruby` and I copied it in the Documents folder. > Then I added somewhere in the middle of the file: > > (define-public wayback-machine-downloader > (package > (name "wayback-machine-downloader") > (version "0.2.1") > (source > (origin > (method url-fetch) > (uri (rubygems-uri > "wayback_machine_downloader" > version)) > (sha256 > (base32 > "1nrwm5bc7vqm02m2x0lylxyya446kg0spg6ksi7dfkrad0l9jq8y")))) > (build-system ruby-build-system) > (arguments > `(#:tests? #f ; no rakefile > )) > > (native-inputs > `(("ruby-rake-compiler" ,ruby-rake-compiler) > ("ruby-minitest" ,ruby-minitest))) > > (synopsis > "Download website from archive.org's Wayback Machine") > (description > "Download any website from the Wayback Machine. Wayback Machine by > Internet Archive (archive.org) is an awesome tool to view any website > at any point of time but lacks an export feature. Wayback Machine > Downloader brings exactly this.") > (home-page > "https://github.com/hartator/wayback-machine-downloader [1]") > (license expat))) > > Then I ran: `guix package -i wayback-machine-downloader -f > ~/Documents/ruby` and it successfully installed. > > So my questions are: > > 1) Do you guys and gals have a better workflow that includes the git > repo, so I can send a patch? All I saw in the documentation was about > building guix itself. I guess I could clone somewhere and use `guix > package -f`, but will this be a reliable way of testing? And will this > make my guix less stable on the long run? > > 2) Should I add "ruby-" before the name of the package? I know > technically all gems should have "ruby-" before the name, but this is > designed to be use independently. Could it have multiple names, or is > it a bad idea? > > 3) Where does this package belong in the directory? > > 4) Is the package declaration itself all right? Are packages sorted or > organized in any way? > > 5) I speak fluent French, can I add a description and summary in > French? > > Thanks! > Vincent > > > Links: > ------ > [1] https://github.com/hartator/wayback-machine-downloader Hello! I tested this out on guixsd, I changed (license expat) to (license license:expat) and it built fine but when I tried to run it I got this error: ~$ wayback_machine_downloader /gnu/store/jaf2s3paa3fswfpzi6amlqjxd3fwiw9x-ruby-2.3.0/lib/ruby/2.3.0/rubygems/dependency.rb:319:in `to_specs': Could not find 'wayback_machine_downloader' (>= 0.a) among 11 total gem(s) (Gem::LoadError) Checked in 'GEM_PATH=/home/rain/.gem/ruby/2.3.0:/gnu/store/jaf2s3paa3fswfpzi6amlqjxd3fwiw9x-ruby-2.3.0/lib/ruby/gems/2.3.0', execute `gem env` for more information from /gnu/store/jaf2s3paa3fswfpzi6amlqjxd3fwiw9x-ruby-2.3.0/lib/ruby/2.3.0/rubygems/dependency.rb:328:in `to_spec' from /gnu/store/jaf2s3paa3fswfpzi6amlqjxd3fwiw9x-ruby-2.3.0/lib/ruby/2.3.0/rubygems/core_ext/kernel_gem.rb:65:in `gem' from /home/rain/.guix-profile/bin/wayback_machine_downloader:22:in `
' I'm not sure what the fix would be.