From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id mCGCLTJU/2RCRwEA9RJhRA:P1 (envelope-from ) for ; Mon, 11 Sep 2023 19:53:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id mCGCLTJU/2RCRwEA9RJhRA (envelope-from ) for ; Mon, 11 Sep 2023 19:53:54 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 638BC5ACB1 for ; Mon, 11 Sep 2023 19:53:54 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=TGVHte4c; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694454834; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=pXbs8fIorMSd7Q5vrHpmvG3eYFOXmsQ/ZWk6z17A8Qg=; b=A6lWl6UuYn4ib9yLKS3P4bsirTw9JdrpFm+Pzq47oCLZPeavWRpU+JBU8klcPAJgUgZHz5 iT0U92JwzefO3v65tYZFnnqJUnxf2QzoH2VShrR1YLPuqbW6yJD2/uXJ2+RrYW0QYgj90B qTmMSyLb8TgD7fUxPoI29eAcPNGiJpAn9qxXXcdLFPREFXPqvXoYG9p0+RCU8ihL7fV6Q4 8ktduRwxf0RuqSXkW9y54GiP8xh6Oy1TMtmIPUoBsy0b8mldYZIe8dNitUXdkSLCdNIQYa j6s5fdu6GBOAuWm+I3c1r4XJ0JFqAwLOkfuWSY+3TpSH3D2vcMUGUfitmY8elQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=TGVHte4c; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694454834; a=rsa-sha256; cv=none; b=aa8KpNNjs2Qv8i1JsgQ7hBN9qFzqpqLh35/EEPsEWc49dfuk7Mm1c35Y9hFldOdiMdw2cv zxT0m1DR0QXW8SfK+kqxX4XZ6VwyEKbZn8TvTQNrprjDTUjmZ2YXA6jpy7hoItGkRVlKhN LZtxHBtnuMYU9oqLLAOxc4ZSjv6Krw+HvIwnXLJDGGyG98dBhT0CAAkeuzjc3lQgR6RswU gc6yZaNsH+FowPOxnRITw8pmLFByo9uudgWw2uaY3wgDJ5/FxnLszslEGQIqqqzvH/o3+R hw/mIJJl2FofShW28mw/v5/mxqTEEExcjBuVMsrv4GTL1A85SX7nhuVGtu7CfQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfl6Z-0002ps-AF; Mon, 11 Sep 2023 13:53:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfl6Y-0002pf-DT for guix-devel@gnu.org; Mon, 11 Sep 2023 13:53:46 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfl6W-0008WI-3W for guix-devel@gnu.org; Mon, 11 Sep 2023 13:53:46 -0400 Received: by mail-wr1-x444.google.com with SMTP id ffacd0b85a97d-31aeedbb264so5022213f8f.0 for ; Mon, 11 Sep 2023 10:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694454822; x=1695059622; darn=gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=pXbs8fIorMSd7Q5vrHpmvG3eYFOXmsQ/ZWk6z17A8Qg=; b=TGVHte4ch+7p/mEYFNaS8UE2eOhQF+WYnSBaTsWHArBlbDyjovvd06Dqx1vZS7iGd2 BLwIYaYNFifHFFWHXp/d8OT0+n+CKp+ytuvaBPOLGSTJhtSIaIOniEiSoFWAb2GpBX2k mIN9V61iCN3Vt36zUXwt18QY0LtTPJvf1J8FJ5yjQ1lmkDDEz752d4wBcS9Hw9hASHZK K+FRTpndqOV43t7Pj7C4D5yVMdgaErV5lU/fuZT3ER0oR02g6bnZhV9aysDUdyukuL9G jbGNP9DXEPPOFXprP0auQR5RC2gNjOCUjB/PICgr3gdEkbseYqS/SxLHUxW/HnPake1C kK1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694454822; x=1695059622; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pXbs8fIorMSd7Q5vrHpmvG3eYFOXmsQ/ZWk6z17A8Qg=; b=EX9HJbClHG96/I/FUC/leJZ58eN5yEVLjfjecH2HwXUnE2mLSixM3Bg+6UXiCdWezr TNQsM8z6Aa5hPNcrhKJtMR3126xsspsSGk7Xtcm8P5mrqmnsiwwR/JmHYEJ1LLQfjqdi PDrPmi7hkcFAKTPqloJs5zQ7FL9MRSPQd5SyCPNXyTJIrt6fh2EFHecm+Dp8VgHdUqIL +gdYwhJUOfFigVdsAE0N5si3UR/l7n9rSBNluDbZaw8j9gY2etIpRHxwo4lgDnvpWbEM fzyxK0m8SymopPQqgmPrAcsjA4PCTQ7t/sVPv64GXuTifT1VfqOjyDPgUPu05xJW3esP 2Umg== X-Gm-Message-State: AOJu0YxfG+H5PpFt53LA+1qjD/gLEi5Ffh1RO11suIz4yAebYhmj4GOI Ocz2ZOEOpsEnGYejBGF+gtJe8X80V/tnK0tp X-Google-Smtp-Source: AGHT+IFhqXWoMk50lnpNkKEv69QnS8ncR4yLn9sWLiRZyXfA0hx0grT8Pday2EngVBRL9ozn0r7DMQ== X-Received: by 2002:a5d:46cc:0:b0:319:7656:3863 with SMTP id g12-20020a5d46cc000000b0031976563863mr8102678wrs.47.1694454822261; Mon, 11 Sep 2023 10:53:42 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id j14-20020aa7c40e000000b0052a1c0c859asm4908681edq.59.2023.09.11.10.53.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 10:53:40 -0700 (PDT) Message-ID: <07680e309df1fe42da11d9e3a6c33de40f82bf09.camel@gmail.com> Subject: Re: How can we decrease the cognitive overhead for contributors? From: Liliana Marie Prikler To: Simon Tournier , Ricardo Wurmus Cc: Attila Lendvai , Andreas Enge , Katherine Cox-Buday , guix-devel@gnu.org Date: Mon, 11 Sep 2023 19:53:38 +0200 In-Reply-To: <87fs3lj8tn.fsf@gmail.com> References: <87sf7o67ia.fsf@elephly.net> <9269133a74e06bfc5ee5bfeee0342ba2f5beaeb1.camel@gmail.com> <87tts44d2y.fsf@elephly.net> <4c85b742e29ebbf7fe3cde3f72961269ec26218c.camel@gmail.com> <87cyyr3zdc.fsf@elephly.net> <87fs3lj8tn.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::444; envelope-from=liliana.prikler@gmail.com; helo=mail-wr1-x444.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -7.07 X-Spam-Score: -7.07 X-Migadu-Queue-Id: 638BC5ACB1 X-TUID: qsHHgyIS/0c/ Hi Simon, Am Montag, dem 11.09.2023 um 12:36 +0200 schrieb Simon Tournier: > Today, the review and commit process have many steps, more or less > simple, not all sure!, well at the end, we have something complex. >=20 > One trivial step is to apply the patch (or series) to your local > checkout and so many things can lead to some useless frictions.=C2=A0 For > example, the patch does not apply because the base commit is not > provided, or because it is badly formatted, or because=E2=80=A6.=C2=A0 An= d one > ends to fix themself, e.g., probably using some manual trick just for > applying the patch.=C2=A0 No value for the project. >=20 > Yes, QA is currently helping for that specific example about applying > patches but the solution depends on why the patch does not apply. As a committer, I've already shared my tool for applying patches from mumi. It is currently broken due to yet another bug in mumi that I can't figure out the cause of, but assuming that gets fixed, it is indeed a trivial step with the added value that I can sign off the commit as I do (and signed commits gives the benefit of a trusted upgrade chain, as detailed in the introductory blog). Now granted, there is no benefit if you do this "checking out for review work" as a non-committer, because your signature, whether you apply it or not, holds no value for the project. However, there are issues one can spot simply "by looking" as well as others that do require actual research beyond building the package (such as "is this software actually GPL'd" for example). As for actually checking whether the package builds, we could move more of that to QA, but I'm not sure whether that'd be a benefit. For "patch does not apply", the forge solution is typically to send a notification to the issuer. Sure, we could do that, we could even do so automatically, but fixing one's own patch over and over against a running target when there's no hope it'll get merged (for other issues that are never pointed out, because you're coding for a bot) induces even more cognitive overhead. > Well, I am not saying that we should switch to PR model using > GitHub. :-) Let just recognize that our current workflow has many > drawbacks that make some frictions (steps with no value) for > reviewing. And PR model =C3=A0 la GitHub has many other drawbacks but at > least it reduces some frictions (technical steps with no value); > mainly because some people are paid for removing (or hide) these > useless friction. >=20 > Don=E2=80=99t you agree that the review process implies many manual steps > that have no value for the project? I might actually disagree on the "many", but let's agree on "some" and move on from there. > Last, I agree that the main issue when speaking about the reviewing > process is not about tooling.=C2=A0 The lack of a smooth technical > solution is just acting as a chemical developing solution in > photography, it increases the contrast and makes the poor image > apparent. Yeah, I don't get that metaphor. Cheers