From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OU54DimKaGDgOgAAgWs5BA (envelope-from ) for ; Sat, 03 Apr 2021 17:30:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 0JxPBymKaGCEMQAA1q6Kng (envelope-from ) for ; Sat, 03 Apr 2021 15:30:49 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D50AE20E37 for ; Sat, 3 Apr 2021 17:30:48 +0200 (CEST) Received: from localhost ([::1]:51976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSiEa-0006ew-1i for larch@yhetil.org; Sat, 03 Apr 2021 11:30:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSiEH-0006eB-Hs for guix-devel@gnu.org; Sat, 03 Apr 2021 11:30:30 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:14507) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSiEA-0006fU-J7 for guix-devel@gnu.org; Sat, 03 Apr 2021 11:30:28 -0400 Received: from nijino.local (194-96-13-79.adsl.highway.telekom.at [194.96.13.79]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FCLTK1rqlz1LBRx; Sat, 3 Apr 2021 17:30:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4FCLTK1rqlz1LBRx DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1617463813; bh=3+FOn7Bv0Iem6r2UdeH0+b8C3WVMNnugx2cnLy5v0yA=; h=Subject:From:To:Date:In-Reply-To:References:From; b=aH4HTFvudMQndLDm7GwcqxdVQLvbEGp+fmwvl5S8HYOvBoVUPhSgRkW17iF5/FPW9 KEa3bMhmUc+wg/7eAea8S4g5OkkNTNB+cdewPv3SMwxQJHzIa0R2lREnMb/ODueCEz ADkcG4KTFey30Ld86Vyc67036V/RdKmibnCPriEg= Message-ID: <04ca8e13c39b4e1e41a10a5d77250391cfb001b5.camel@student.tugraz.at> Subject: Re: A new wip-emacs branch From: Leo Prikler To: Xinglu Chen , guix-devel@gnu.org Date: Sat, 03 Apr 2021 17:30:12 +0200 In-Reply-To: <87lf9zwpgy.fsf@yoctocell.xyz> References: <92b90b2aa6ed7d61beba38ff123b8bf1c0695234.camel@student.tugraz.at> <87pmzbwqcu.fsf@yoctocell.xyz> <87lf9zwpgy.fsf@yoctocell.xyz> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 Received-SPF: pass client-ip=129.27.2.202; envelope-from=leo.prikler@student.tugraz.at; helo=mailrelay.tugraz.at X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617463848; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=3+FOn7Bv0Iem6r2UdeH0+b8C3WVMNnugx2cnLy5v0yA=; b=Nujxf/y73/dejWZq2kFgAi/TWVmw9o8/26c8RoJSwbUIe8hgN335p3SjfQpJXaoN9pOzQD Eyzolf2bRV53rmoUI7s7cCzFu4YCoZ6TmhNqRAseFqZMXxBqUjNSPU03FB0woTwU3e3hdK OVHi8JFX0rFcDFy/2D412100WQ08e2KrfWL7Z9Eiwzv3Ijp85Upch2fjhLyWYQTGQnAwM6 xymB3Vm5pOpS8Jv8HPpwOZYoWcNkXikO/UTFWtSb0i935+xUzza+4zIR06g4SYVG4TXXAS 6hc0nihj8HjXDWqtB2Egr6XxpZd+T3jPc8lxpAbcWZOb/hC75L5fOEWps9eFhw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617463848; a=rsa-sha256; cv=none; b=eKcxqSgVKPHPr+gZJuMvB7pgKogBQ/EmnrpDfROqRKdXp+6ISiqO2UU4iyo1Rk1im94wti ktNYwKGc2NMK9mbRVwEY0Mxht2zolSfUOih1oz8ItbUE4iB+AXn3WKTXgcczMpMQEGVUmZ nCZVqF4DrdHGUMiyMfHvkzcsyBUxMpfh6CqnB1aHoQ4Aj9xIBePWssovWOpmNtZPI3oPZb dGaut9WdxAc1ljXpVtACvacW0ud5arqFMnQicHBPU721Wd8BYz5WOM3zdQgOWhzfCJtohE 7bsgAfRSvgRLSBtV1vKRZz0HLm2WmvQcerg/EfAY4YX7Cypu/iBYw0iCtGOjpg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=tugraz.at header.s=mailrelay header.b=aH4HTFvu; dmarc=pass (policy=none) header.from=student.tugraz.at; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -3.13 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=tugraz.at header.s=mailrelay header.b=aH4HTFvu; dmarc=pass (policy=none) header.from=student.tugraz.at; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: D50AE20E37 X-Spam-Score: -3.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: jbGGhFUHy1Qb Am Samstag, den 03.04.2021, 13:57 +0200 schrieb Xinglu Chen: > On Sat, Apr 03 2021, Xinglu Chen wrote: > > > I tried the 'wip-emacs' branch (commit > > b18d605fcb51bcce56a1114f82645658db9f5b14), and I noticed that > > 'emacs-emacsql' was failing to install. The 'make-autoloads' phase > > fails with: > > I was able to fix this with the attached patch. Your patch LGTM in a vaccum (except that package-version this-package could be abbreviated to just "version" IIUC), but I went for a different fix, since emacsql tried to avoid redundancies by putting in other redundancies. I ran a small test with emacs-emacsql-sqlite on 2be3daa19d2fd47933c622995d2f2dde714075e6, but please try it for yourself and check whether everything works as you expect it to. Regards, Leo