unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Xinglu Chen <public@yoctocell.xyz>, guix-devel@gnu.org
Subject: Re: A new wip-emacs branch
Date: Sat, 03 Apr 2021 17:30:12 +0200	[thread overview]
Message-ID: <04ca8e13c39b4e1e41a10a5d77250391cfb001b5.camel@student.tugraz.at> (raw)
In-Reply-To: <87lf9zwpgy.fsf@yoctocell.xyz>

Am Samstag, den 03.04.2021, 13:57 +0200 schrieb Xinglu Chen:
> On Sat, Apr 03 2021, Xinglu Chen wrote:
> 
> > I tried the 'wip-emacs' branch (commit
> > b18d605fcb51bcce56a1114f82645658db9f5b14), and I noticed that
> > 'emacs-emacsql' was failing to install.  The 'make-autoloads' phase
> > fails with:
> 
> I was able to fix this with the attached patch.
Your patch LGTM in a vaccum (except that package-version this-package
could be abbreviated to just "version" IIUC), but I went for a
different fix, since emacsql tried to avoid redundancies by putting in
other redundancies.

I ran a small test with emacs-emacsql-sqlite on
2be3daa19d2fd47933c622995d2f2dde714075e6, but please try it for
yourself and check whether everything works as you expect it to.

Regards,
Leo



  reply	other threads:[~2021-04-03 15:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  8:00 A new wip-emacs branch Leo Prikler
2021-04-01 12:21 ` pinoaffe
2021-04-03 11:37 ` Xinglu Chen
2021-04-03 11:57   ` Xinglu Chen
2021-04-03 15:30     ` Leo Prikler [this message]
2021-04-04  9:32       ` Xinglu Chen
2021-04-04 10:53         ` Leo Prikler
2021-04-06  9:06 ` Leo Prikler
2021-04-06 18:21   ` Xinglu Chen
2021-04-06 21:32     ` Leo Prikler
2021-04-07 10:07       ` Xinglu Chen
2021-04-07 17:54   ` Leo Prikler
2021-04-08  3:17   ` Carlo Zancanaro
2021-04-08  7:49     ` Leo Prikler
2021-04-08 14:05       ` Carlo Zancanaro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04ca8e13c39b4e1e41a10a5d77250391cfb001b5.camel@student.tugraz.at \
    --to=leo.prikler@student.tugraz.at \
    --cc=guix-devel@gnu.org \
    --cc=public@yoctocell.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).