From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WMeCKwlER2ImdAEAgWs5BA (envelope-from ) for ; Fri, 01 Apr 2022 20:27:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id QDwyJAlER2KpbAEAG6o9tA (envelope-from ) for ; Fri, 01 Apr 2022 20:27:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3EE123EAC2 for ; Fri, 1 Apr 2022 20:27:21 +0200 (CEST) Received: from localhost ([::1]:56830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naLzU-0008GJ-D9 for larch@yhetil.org; Fri, 01 Apr 2022 14:27:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naLxw-0008EU-4i for guix-devel@gnu.org; Fri, 01 Apr 2022 14:25:44 -0400 Received: from [2a00:1450:4864:20::541] (port=40489 helo=mail-ed1-x541.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naLxu-0003N8-E8 for guix-devel@gnu.org; Fri, 01 Apr 2022 14:25:43 -0400 Received: by mail-ed1-x541.google.com with SMTP id y10so3901032edv.7 for ; Fri, 01 Apr 2022 11:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=Dnv4YvTZECnkJIEaKrBYeu10k4e51YJifeXdtFG3/UU=; b=phrqwRxPrkGIsJd1R1owfU/phgSZhjNZk90xaL4qtOWOr1NRNNmtP9fkgvf5IQ0+bM +i8GyiplHJEwr/TvaixAU58TPWA+tNHWDIoMJCLQ/ByGPgT8bUUsITWb1d7aDZsJi9bD HRz9O/15+YYdB169X/KtKwomtHCr57XoBIqadPYBHee5RyfyK9vzW3Xm3nmETjsC8R8e HWVm3O+EckWPYWHjTGMcSQYWtDhqAALy0IwyfV9IWDdNRB9JpPA26EoDqUrtgTziCzJE YQhPJyjc1ph6CIQW5ByW8pFZ/2dQFB2PPVvD2jrATSPg9TcM2+SsJ6GDXUrO86BxuJcc +0tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=Dnv4YvTZECnkJIEaKrBYeu10k4e51YJifeXdtFG3/UU=; b=wiFEy1/gAjNPn1xSKmcJcKUeGMQXvEt0QrCo4t0g+WEkDl77fuL28Kk3RDv7A7IVqe RDI1empY5/XirXgbUTp9ulwiT+twNv/TR0+jJryBv1jStdDiZBhVqVPxSuWvV0kpJzCu 5g4Qz0epUc+fPZQfLEJfq0Af/vBkkhND300RZH7YOjIq/G4euC2t+JfclprNNxThextQ ZkF5YAo/sip/5I4X305CjG/op0g5FMrnhTha+9kL86W+NxDCI88jzxKPINm+KPLG9RoI +AcFVQAuZ3eyQzgejO1QSqSu5SRYcqSsXKKfotRzMxsIFRQEGYgyiAmUvuxDXtgHR6oG H70Q== X-Gm-Message-State: AOAM531IT7+l0O0Iw26N/8duoYyq+DNssf0z/iLXWZfV0qecU33emJbX DE2UEA42J+6OaYM6m5cZMl8= X-Google-Smtp-Source: ABdhPJxLH5q8431NObJxqnEfJfcOxHNV0XKNscEZjD/EsF5ngb1XiCXaOUOLEnv563l2cooSuRrE+w== X-Received: by 2002:a05:6402:4302:b0:419:4be8:6493 with SMTP id m2-20020a056402430200b004194be86493mr22379265edc.294.1648837540500; Fri, 01 Apr 2022 11:25:40 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id u4-20020a170906780400b006ce69ff6050sm1289335ejm.69.2022.04.01.11.25.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 11:25:40 -0700 (PDT) Message-ID: <01ff99a0452cb12718938646388302ac372a7416.camel@gmail.com> Subject: Re: New review checklist From: Liliana Marie Prikler To: Maxime Devos , guix-devel@gnu.org Date: Fri, 01 Apr 2022 20:25:37 +0200 In-Reply-To: <447d4df82b8626181b37bedb37ba60d212cd98e9.camel@telenet.be> References: <0912e3091c2bc34866f2795ec4f0413fc0928bdc.camel@gmail.com> <447d4df82b8626181b37bedb37ba60d212cd98e9.camel@telenet.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::541 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::541; envelope-from=liliana.prikler@gmail.com; helo=mail-ed1-x541.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648837641; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=Dnv4YvTZECnkJIEaKrBYeu10k4e51YJifeXdtFG3/UU=; b=pitJto9VvEidwlDqur/i19qT5GyMKTJtz33Aj/9FySQof7baE8P6Wlx6FS2gPIh+t9Nvg+ TysOAnyx1qHW9v9Fgd/Sg8RgVhnfo9dNjjs1THKVofg1hq+UFBnQbLvkYOYHLlvx8kiOgF BdX+sUIvt70wCRA8xUZF3MWf/WrUYKKmXHp1i8CbqdGzVdZfAehIQlHzFyoruQntLD1BNZ OdSux3NJSQf2hTcDUV0ye5yZJAl+H8qRvKlFoM1zO4G3F/S5LzQ+qog4nqxBbsuBJM2n8j jiE2Khilxmnl768UL6u2aw+gGPxN4Wum4aIr/xyUAJfta5rJ391Smf0Vb066BQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648837641; a=rsa-sha256; cv=none; b=At4t10cPFX0bI9t3UL4dbagCXyyGM7CuLejXTpm2RQfl0RJ8QvmJnc3bJ2OLTpyTC/ueng 3RLTgLnjnKvWNlIeTfvUCSIxnl7DvaqzVxEXB8BKl1QNbYCBoCk2Mdk6IQxc7Mh9tyvtsc 8exGI0Z9C+ZAwFQ8sHp64djEd5+Te3Pu6JDYqYDR5kTZifhpvyGe1ON6WjmqLhnWijR3Eb DZ9PTYx04mS1munyWENCYa4vZphgy80LBT5RZBiSyAeiJ+olww9pzNDv1HmnRsSnh1VF+7 zZSFPxLHyjIL+ecN6GG7c+D6m8uF2OAskJ8aEbWo+XhiSrGwecBWbkFn7a68zQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=phrqwRxP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.07 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=phrqwRxP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3EE123EAC2 X-Spam-Score: -4.07 X-Migadu-Scanner: scn1.migadu.com X-TUID: ZloyX0VtmBQb Hi Maxime, Am Freitag, dem 01.04.2022 um 19:46 +0200 schrieb Maxime Devos: > [...] > I know there have been some discussions in the past about whether > git-version should be used when a commit is explicitly chosen, > whether > tags should be used instead of commits, how high a risk there is that > version->commit can become multi-valued, ‘tricking peer review’ ... > > However, my question isn't about any of that.  It is only about the > let-binding itself, in situations where the bound variable is only > used in a single place.  What is the reason for doing > > (let ((commit "cabba9e...")) >   (package >     (name "foobar") >     (version "0.1.2") >     (source (origin ... >               ;; this is the only use of the 'commit' variable bound > in >               ;; the above 'commit' >               (commit commit))) >     ...)) > > when it can be simplified to > > (package >   (name "foobar") >   (version "0.1.2") >   (source (origin ... (commit "cabba9e..."))))? > > I mean, we don't do this for, say, 'name', 'version' and 'uri': > > ;; these three variables are only used in a single location > (let ((name "foobar") >       (version "0.1.2") >       (uri "https://foo.bar")) >   (package >     (name name) >     (version version) >     (source (origin (uri uri) (commit ) [...])) >     ...)) > > Why would things be different for 'commit' here?  How does putting > the value of 'commit' in a let-form reduce surprises? The main goal of let-binding commit and revision is to allow for easier change. Suppose you need to reference some half-release for some obscure reason, then this style makes it easier to switch to what is already established praxis. In general, consider the poor soul who may have to read and maintain your code after you get hit by a car because neither busses nor trams run in your region.