From: Eric Bavier <ericbavier@centurylink.net>
To: guix-devel@gnu.org, ludo@gnu.org,
Arun Isaac <arunisaac@systemreboot.net>
Subject: Re: zipbomb handling should not be done in url-fetch/zipbomb
Date: Sun, 18 Jun 2017 17:21:05 -0500 [thread overview]
Message-ID: <012D1840-3FA8-4F96-8909-278E3DE75EC4@centurylink.net> (raw)
In-Reply-To: <878tkqbceq.fsf@gnu.org>
On June 17, 2017 3:13:33 PM CDT, ludo@gnu.org wrote:
>Arun Isaac <arunisaac@systemreboot.net> skribis:
>
>> * Proposal
>>
>> zip bomb (zip archives without a top level directory) handling should
>> not be done in `url-fetch/zipbomb'. It should be implemented as a
>> boolean argument to the `unpack' phase.
>
>I guess the Boolean argument would determine whether to do (chdir
>(first-subdirectory ".")), right?
>
>Unfortunately that’s not enough for the cases where an origin has
>patches or a snippet, because that code also assumes there’s only one
>subdirectory (see ‘patch-and-repack’ in (guix packages)).
>
>Perhaps the right fix would be to fix ‘patch-and-repack’ somehow.
I think this would be preferable. Since it means that users of 'guix build -S' would still get "unbombed" sources.
`~Eric
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
next prev parent reply other threads:[~2017-06-18 22:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 9:45 zipbomb handling should not be done in url-fetch/zipbomb Arun Isaac
2017-06-17 20:13 ` Ludovic Courtès
2017-06-18 22:21 ` Eric Bavier [this message]
2017-06-20 18:49 ` Arun Isaac
2017-06-21 10:45 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=012D1840-3FA8-4F96-8909-278E3DE75EC4@centurylink.net \
--to=ericbavier@centurylink.net \
--cc=arunisaac@systemreboot.net \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).