From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aDI4BfP/UmIN1QAAgWs5BA (envelope-from ) for ; Sun, 10 Apr 2022 18:04:03 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EGGRAvP/UmKzDgAA9RJhRA (envelope-from ) for ; Sun, 10 Apr 2022 18:04:03 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9A6ED2B0D5 for ; Sun, 10 Apr 2022 18:04:02 +0200 (CEST) Received: from localhost ([::1]:54404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nda2j-0002oY-CD for larch@yhetil.org; Sun, 10 Apr 2022 12:04:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nda1K-0000PK-Gf for bug-guix@gnu.org; Sun, 10 Apr 2022 12:02:34 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47283) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nda0n-000782-LX for bug-guix@gnu.org; Sun, 10 Apr 2022 12:02:34 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nda0n-0007AK-Jf for bug-guix@gnu.org; Sun, 10 Apr 2022 12:02:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#54831: Unhandled ENOENT exception References: <878rsdbygd.fsf@ditto.jhoto.spork.org> In-Reply-To: <878rsdbygd.fsf@ditto.jhoto.spork.org> Resent-From: Christopher Rodriguez Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 10 Apr 2022 16:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54831 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 54831@debbugs.gnu.org Received: via spool by 54831-submit@debbugs.gnu.org id=B54831.164960649727513 (code B ref 54831); Sun, 10 Apr 2022 16:02:01 +0000 Received: (at 54831) by debbugs.gnu.org; 10 Apr 2022 16:01:37 +0000 Received: from localhost ([127.0.0.1]:41180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nda0O-00079g-Qq for submit@debbugs.gnu.org; Sun, 10 Apr 2022 12:01:37 -0400 Received: from mail-qv1-f54.google.com ([209.85.219.54]:38855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nda0N-00079U-1x for 54831@debbugs.gnu.org; Sun, 10 Apr 2022 12:01:35 -0400 Received: by mail-qv1-f54.google.com with SMTP id p8so11476694qvv.5 for <54831@debbugs.gnu.org>; Sun, 10 Apr 2022 09:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:from:to:subject:date:message-id:mime-version; bh=hFXj9/mC7urmtqViiMta1S580/J+8J52y9A+VA+Etz8=; b=o9xe2O6e7ijo/yqa+Trop9yFTb6Uy6h74J+UpvdhgpY+IpQl94etsKI+4uVLmhDRIL Yr0uYDErP0RjSd/BZmEg/KJOWPWX1oSct7rxGR75te1kFw/8MX3Ib4Kw6uHSy5xQHV0H 0pdD3Qg0xjb311YvljHVy3cUQNyaGcC4ti6L9iJkQAdPaEhfDR0TwoA7jTvr83njDv6H z7gdsivHZIpSAbQuN3iS8fpksqR7xyTFXaXZN25W2mz2S4x6ktFT4MRlf9VBMALHZgLJ /s4PP4WfMlEHF/7eAMkkX067AgxpoClNyygtwzOyAGOighClqXLtZ0TevFYFZrteoKO+ CBTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=hFXj9/mC7urmtqViiMta1S580/J+8J52y9A+VA+Etz8=; b=sCxaEXqFYdiCY51exNTpA2wWLVl3DwXEYVoz5IN758b55ppC/R/Tg/14ddpIhD9xqG le1dwBHqzTxSZeDDHH994cLz0P6Z4E27T/3f2Kh5CC2fWNuGUqHBXfYpJghxFJm1SZpE IaspQck2gwHPit2fOcPvvMPwywBWSqbV+4E1ygh6cxn6KSeKyOqdUvJC5rflCULepF3u wox/9tnDHbHXKy9VNczyvmOootANFt8RKJq3tlxEdkJT3i9j7OugVFkMFut0ati/fIFz 2IG6fFHu/xsuZNDNlTI/hA53Un0j4PTrntncpUwBY8FMY86uop2yqmQ6AhqWl9BhiRBL pf4w== X-Gm-Message-State: AOAM5311WlT844ea0eRPphhlZuOkng2Hs/vhTlFm1Y9nl/ZXqIIMJvxX MIjE3/sHWf92hRAvFFXX3+wfS6woSxQ= X-Google-Smtp-Source: ABdhPJy8w9XXEVOcHBrsbodjsnkXaodQGuY6xArFQRdHlTHEpYWSGauJnbkqZfjzgWI19yRckUPucw== X-Received: by 2002:a05:6214:761:b0:441:196:795e with SMTP id f1-20020a056214076100b004410196795emr23482879qvz.67.1649606489069; Sun, 10 Apr 2022 09:01:29 -0700 (PDT) Received: from gmail.com ([52.94.133.131]) by smtp.gmail.com with ESMTPSA id x20-20020ac85f14000000b002e1ee1c56c3sm23802529qta.76.2022.04.10.09.01.28 for <54831@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Apr 2022 09:01:28 -0700 (PDT) User-agent: mu4e 1.6.10; emacs 28.0.50 From: Christopher Rodriguez Date: Sun, 10 Apr 2022 11:47:54 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="===-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649606642; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=hFXj9/mC7urmtqViiMta1S580/J+8J52y9A+VA+Etz8=; b=HnYI/eQGYb3C6W8fEL4sv8sVkb7e9T+XEbRG4g71m7nxf7V2iDG35Z2xgOZTIe4quVEZSg mdAWsYIZkBj2GAH70dlQgviQlRTn4OjHnm6Tx8M3IKefNEzqgbMN7aU1rRXX+02xTFceGY AGvJGKmeXNlD1z2ijlQyQDaGYQMNLdw6w5WcKf4tRMarBVLu9f9Y3yjy6WlfnR4Kffm7Nj BeGGgC82cxdZ2WtGzWTdIB9tNGyHXeCfW7hHhrEaPtn87fZ1d71hkmvgmEc9iLxkJxiagw ze7Og0YwsnBT92VnPaq2/1xByYdKFsZ2m/8S0ZnFjUKKvUuk04p5PlQkwDl6Rw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649606642; a=rsa-sha256; cv=none; b=aeohLNjDzk2IL1QJXrlK0nCkCRiHDSJ/n3SehTM5qoDsFJTsahM1BVi+epm5Y/Agr2Cr6C dF6s2o/Kn+Gf3SPb2HH0SV+2UMe2ZT197ou1IlpSy2bsvpBjS5lCH9rgKiQGaHvL9T8y++ hOJCjnHGvsL5GM7Il1UF9/tt3X1MqONArbpogKkDISXAr5g05XEFRFMYz0yxgD5Vuufg8V 47y+ZWeRMF+wFW/gsaoXw2wMhBLBs5Tlg9P0a3jYvxv1Fyi0gDZOFqUqPTD3dbmlOAIbYY X659IUjHbInmevAjTi60I1M68Rjq96KeI6q/WljmxPBaEPQKiWqHBXiox+1pvQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=o9xe2O6e; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 4.03 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=o9xe2O6e; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9A6ED2B0D5 X-Spam-Score: 4.03 X-Migadu-Scanner: scn0.migadu.com X-TUID: MpajmrhxUt8D --===-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Christopher Rodriguez Table of Contents =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80 I'd like to add my $0.02 as well. Seems like the issue is during the deployment, as Madhavan said. Specifically, the error message in that form only appears in `gnu/home/services/symlink-manager.scm', in the function `cleanup-symlinks'. It seems that, right now, the issue is that `ENOTEMPTY' and `ENOTDIR' are tested for and handled, but `ENOENT' is not. Ideally, this should be handled and tell the user /which/ file or directory is missing, not halt the entire process. And, since we are testing for a missing file (and thus have no chance of overwriting a user's data), it would probably make the most sense to just create the file that is missing in the next step, without stopping at all. I'll throw together a patch real quick to test with. I could be very off base, but I think this should fix this issue. --==-=-= Content-Type: text/html

I'd like to add my $0.02 as well.

Seems like the issue is during the deployment, as Madhavan said. Specifically, the error message in that form only appears in gnu/home/services/symlink-manager.scm, in the function cleanup-symlinks.

It seems that, right now, the issue is that ENOTEMPTY and ENOTDIR are tested for and handled, but ENOENT is not. Ideally, this should be handled and tell the user which file or directory is missing, not halt the entire process. And, since we are testing for a missing file (and thus have no chance of overwriting a user's data), it would probably make the most sense to just create the file that is missing in the next step, without stopping at all.

I'll throw together a patch real quick to test with. I could be very off base, but I think this should fix this issue.

--==-=-=-- --=-=-= Content-Type: text/plain -- Christopher Rodriguez --=-=-=-- --===-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJMQbvYVxvZ0eF/84XZ6FgaGVz3sFAmJS/08ACgkQXZ6FgaGV z3txsQ/+OZ42WnjCye/RwDgahEVaGQzs7wYGcUOLQOcFd0tmG32+ytm9YN8pIU7t lCxoELMZ6VNIPkuAX+ugnylM+/nMRDJIovKeRnzOKHekkf7u9OY7vB4LhDR1YtWT dchAk6FcDBSGVvC9lmJS1OZuZcDEkKQMNcEoWok4fOWx0p95hAuzIrBbCkDpuCEH yiiJS7I48ssTPBUAT/1hfxFJIfPmIJvNPmERhf2uBoheEgkegcUA0HfbO3WkSr+D eW4bDW+0r+b53vDdDoGZoS+UxDkAcJwP0TmjJArQTschBcmnBE6cN6uV/qcPRh3/ BceajngpahEvQxe9iBiP9FZhzGXWgd1UdKEbml8WlCZVpfZExjPYh/2dJiJhQ9aq SFtx4gapMOR1Ja0Rf8ofg/nQGaS4KOFlbsu/V/dEMyhqR0hqtVASM8BRx2UFouAW 06GD65Mpugid6A/Nv7iQWLy8pkLEPJ2LCEAWSwt+vo9WS1EvurzyFgK0qBUMtx04 3z4a+Ssd9RSTKenSX9UYibvaz8olRzMIrGxai1Zd+zFWXHvrB9ZZk/HUPDI3k3Tn LoH3DhPtb6O3a/r+cmrx4c8BmnClPVS1pp8BBg0aOpbJTl2hG8d/22ej7m4PK5vk SJGtShRlG9uGc0jDCpnRS9nGKJaNWycMOd5Fd7WEhQ2+xHwlzvk= =RT93 -----END PGP SIGNATURE----- --===-=-=--