unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Gabriel Wicki <gabriel@erlikon.ch>
To: 73700@debbugs.gnu.org
Subject: bug#73700: Acknowledgement (python-django executable unable to find 'django' module)
Date: Tue, 8 Oct 2024 12:45:56 +0200	[thread overview]
Message-ID: <mbslo2q2453a2u6k4ardgd6cd37nuz33rf5qooakb3cy6au7ci@wnnqbyogg2rq> (raw)
In-Reply-To: <handler.73700.B.172837714932754.ack@debbugs.gnu.org>

The following is an obvious, simple fix.  I am not sure how others
regard the issue at hand i would summarize as usability vs. disk-space.
IMHO usability - or shipping broken executables - should be prioritized
before saving some hundred megabytes.

From 5601bbf93baf65e1f6902bf678acb9dddb9e98f1 Mon Sep 17 00:00:00 2001
Message-ID: <5601bbf93baf65e1f6902bf678acb9dddb9e98f1.1728384174.git.gabriel@erlikon.ch>
From: Gabriel Wicki <gabriel@erlikon.ch>
Date: Tue, 8 Oct 2024 12:41:14 +0200
Subject: [PATCH] gnu: python-django: Fix broken django-admin executable.

* gnu/packages/django.scm (python-django) [phases]: Un-delete 'wrap phase.

Change-Id: If8c3c7f7396e7865a7c0ea662845b228984a4789
---
 gnu/packages/django.scm | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/gnu/packages/django.scm b/gnu/packages/django.scm
index 4404c8368d..d0e331e0aa 100644
--- a/gnu/packages/django.scm
+++ b/gnu/packages/django.scm
@@ -98,13 +98,7 @@ (define-public python-django-4.2
                    ;; Tests expect PYTHONPATH to contain the root directory.
                    (setenv "PYTHONPATH" "..")
                    (apply invoke "python" "runtests.py" test-flags))
-                 (format #t "test suite not run~%"))))
-         ;; XXX: The 'wrap' phase adds native inputs as runtime dependencies,
-         ;; see <https://bugs.gnu.org/25235>.  The django-admin script typically
-         ;; runs in an environment that has Django and its dependencies on
-         ;; PYTHONPATH, so just disable the wrapper to reduce the size from
-         ;; ~710 MiB to ~203 MiB.
-         (delete 'wrap))))
+                 (format #t "test suite not run~%")))))))
     ;; TODO: Install extras/django_bash_completion.
     (native-inputs
      (list tzdata-for-tests

base-commit: d44beb9b4ad836781928a0c5667e94c0d6df13f0
-- 
2.45.2





      parent reply	other threads:[~2024-10-08 10:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08  8:45 bug#73700: python-django executable unable to find 'django' module Gabriel Wicki
     [not found] ` <handler.73700.B.172837714932754.ack@debbugs.gnu.org>
2024-10-08 10:45   ` Gabriel Wicki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mbslo2q2453a2u6k4ardgd6cd37nuz33rf5qooakb3cy6au7ci@wnnqbyogg2rq \
    --to=gabriel@erlikon.ch \
    --cc=73700@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).