From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: bug#19708: Bowtie fails to build
Date: Thu, 29 Jan 2015 11:01:56 +0100
Message-ID: <idjpp9x7vmz.fsf@bimsb-sys02.mdc-berlin.net>
References: <20150127214727.GA6287@debian>
	<idjwq476lmt.fsf@bimsb-sys02.mdc-berlin.net>
	<20150128165735.GA14986@debian.math.u-bordeaux1.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50538)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1YGlwJ-0006Hu-0e
	for bug-guix@gnu.org; Thu, 29 Jan 2015 05:03:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1YGlwE-00045g-OZ
	for bug-guix@gnu.org; Thu, 29 Jan 2015 05:03:06 -0500
Received: from debbugs.gnu.org ([140.186.70.43]:37358)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1YGlwE-00045H-Fq
	for bug-guix@gnu.org; Thu, 29 Jan 2015 05:03:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1YGlwE-0005zi-4S
	for bug-guix@gnu.org; Thu, 29 Jan 2015 05:03:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.19708.B19708.142252573622983@debbugs.gnu.org>
In-Reply-To: <20150128165735.GA14986@debian.math.u-bordeaux1.fr>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Andreas Enge <andreas@enge.fr>
Cc: 19708@debbugs.gnu.org

Andreas Enge writes:
> Clearly, only x86_64 is supported. Citing from Makefile:
> BITS=32
> ifeq (x86_64,$(shell uname -m))
>         BITS=64
> endif
> # msys will always be 32 bit so look at the cpu arch instead.
> ifneq (,$(findstring AMD64,$(PROCESSOR_ARCHITEW6432)))
>         ifeq (1,$(MINGW))
>                 BITS=64
>         endif
> endif
> ifeq (32,$(BITS))
>   $(error bowtie2 compilation requires a 64-bit platform )
> endif
>
> So we should disable mips and i686.

Submitted a patch to the ML to do just that.

>> This is odd.  The Makefile only adds this option on MacOS:
>>     MACOS = 0
>>     ifneq (,$(findstring Darwin,$(shell uname)))
>>             MACOS = 1
>>             ifneq (,$(findstring 13,$(shell uname -r)))
>>                     CPP = clang++
>>                     CC = clang
>>                     EXTRA_FLAGS += -stdlib=libstdc++
>>             endif
>>     endif
>
> I see the following in my Makefile:
> MACOS = 0
> ifneq (,$(findstring Darwin,$(shell uname)))
>         MACOS = 1
> endif
>
> ifneq (,$(findstring 13,$(shell uname -r)))
>         CPP = clang++
>         CC = clang
>         EXTRA_FLAGS += -stdlib=libstdc++
> endif
>
> Notice the different placements of the "endif". Are we talking about different
> versions of bowtie? I looked at the top Makefile from the result of
> "guix build bowtie -S".

Oh, I must have been looking at master.  In commit 4a99b0023[1] this was
changed to:

    MACOS = 0
    ifneq (,$(findstring Darwin,$(shell uname)))
    	MACOS = 1
    	ifneq (,$(findstring 13,$(shell uname -r)))
    		CPP = clang++
    		CC = clang
    		EXTRA_FLAGS += -stdlib=libstdc++
    	endif
    endif

I'm not sure why it built the first time, though.  (Compare [2] and
[3], both using the same release.)  Anyway, I can go ahead and patch the
Makefile until a new release is out.

What do you think?

~~ Ricardo


[1]: https://github.com/BenLangmead/bowtie2/commit/4a99b0023bdfbbe486b9649489a32ea184c18c9a
[2]: http://hydra.gnu.org/build/175069
[3]: http://hydra.gnu.org/build/204787