From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: bug#25281: rust importer duplicates input
Date: Wed, 28 Dec 2016 13:06:28 +0100
Message-ID: <idjeg0sgsvv.fsf@bimsb-sys02.mdc-berlin.net>
References: <87zijhuzcv.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me>
	<CAL1_immr3jcxCDJxjYUpO5o8sxVsorW-t7178Vzd55kCGrG3-w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56973)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cMD0d-0002IV-JD
	for bug-guix@gnu.org; Wed, 28 Dec 2016 07:07:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cMD0Y-0006DI-EX
	for bug-guix@gnu.org; Wed, 28 Dec 2016 07:07:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:42224)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cMD0Y-0006DC-4J
	for bug-guix@gnu.org; Wed, 28 Dec 2016 07:07:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cMD0X-0002ED-VX
	for bug-guix@gnu.org; Wed, 28 Dec 2016 07:07:01 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.25281.B25281.14829268008527@debbugs.gnu.org>
In-Reply-To: <CAL1_immr3jcxCDJxjYUpO5o8sxVsorW-t7178Vzd55kCGrG3-w@mail.gmail.com>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: 25281@debbugs.gnu.org


David Craven <david@craven.ch> writes:

> Looking at the Cargo.toml file we see this:
>
> [target."cfg(unix)".dependencies]
> libc = "0.2.14"
> # Compat with older Cargo versions temporarily
> [target.x86_64-unknown-linux-gnu.dependencies]
> libc = "0.2.14"
> [target.i686-unknown-linux-gnu.dependencies]
> libc = "0.2.14"
> [target.x86_64-apple-darwin.dependencies]
> libc = "0.2.14"
> [target.i686-apple-darwin.dependencies]
> libc = "0.2.14"
>
> I started reimplementing cargos dependency resolution algorithm, but
> think now that it's better to use a Cargo.lock file when one is
> provided.
>
> When there isn't a cargo lock file it's a library in the sense that it
> is a collection of source code that can be reused in a cargo project
> that has a Cargo.lock file.
>
> I don't think that this is a issue that needs fixing.

Could the importer be changed to either ignore targets that don’t match
the current architecture or to uniquify the list of inputs?

~~ Ricardo