From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Goebel Subject: bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.] Date: Mon, 12 Dec 2016 23:23:59 +0100 Message-ID: References: <20161211181237.24485-1-ng0@libertad.pw> <20161211181237.24485-6-ng0@libertad.pw> <20161211223454.GA9474@jasmine> <871sxem5ix.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87mvg1k2f3.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20161212154412.GA25907@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGZ1v-0007rh-BT for bug-guix@gnu.org; Mon, 12 Dec 2016 17:25:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGZ1q-0004Un-J6 for bug-guix@gnu.org; Mon, 12 Dec 2016 17:25:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:52511) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cGZ1q-0004Uj-GX for bug-guix@gnu.org; Mon, 12 Dec 2016 17:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cGZ1q-0003E0-Ac for bug-guix@gnu.org; Mon, 12 Dec 2016 17:25:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20161212154412.GA25907@jasmine> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Leo Famulari , Marius Bakke Cc: 25177@debbugs.gnu.org First of all thanks for spotting this bug. >> The bad news is that we have some breakages. >> >> 'python-py' fails with: >> >> TypeError: py.test.__dict__ is not a dictionary >> >> Which seems similar to >> >> https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174165144 The relevant comment is https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174196194: Starting with version 18.4, setuptools will always try to execute a test-suite (see https://setuptools.readthedocs.io/en/latest/history.html#id186), which will fail if there is none. So the solution is to disable the test-suite for python-py, as there is no test-suite which can be run via "setup.py test". For testing I added "python-setuptools" (18.3.1) as native input. This made the "check" phase run "0 tests" for python2-py and no tests at al for python-py. (This package includes a test-suite (see tox.ini), but this test-suite requires py.test, with itself requires python-py. So I suggest to disable it.) Our Python (3.5.2) comes with setuptools 20.10.1. > Yikes, I had hoped to avoid addressing that Nix issue and the humongous > "fix" for a while longer: > > https://github.com/NixOS/nixpkgs/pull/12552 This puill-request is huge, but for setuptools, it comes down that they updated from 18.2 to 19.4. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |