From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2KdEMX7q2WFsiQAAgWs5BA (envelope-from ) for ; Sat, 08 Jan 2022 20:48:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iKjiLX7q2WEhCAEAauVa8A (envelope-from ) for ; Sat, 08 Jan 2022 20:48:14 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 512C615213 for ; Sat, 8 Jan 2022 20:48:14 +0100 (CET) Received: from localhost ([::1]:48384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6HhF-0003MA-9p for larch@yhetil.org; Sat, 08 Jan 2022 14:48:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6Hh4-0003M0-98 for bug-guix@gnu.org; Sat, 08 Jan 2022 14:48:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n6Hh4-0000sP-0h for bug-guix@gnu.org; Sat, 08 Jan 2022 14:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n6Hh3-0003nB-Ud for bug-guix@gnu.org; Sat, 08 Jan 2022 14:48:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#53127: [PATCH RFC] Turning Rust/Cargo inputs into =?UTF-8?Q?=E2=80=9Cregular=E2=80=9D?= inputs? Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 08 Jan 2022 19:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53127 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 53127@debbugs.gnu.org Received: via spool by 53127-submit@debbugs.gnu.org id=B53127.164167127814554 (code B ref 53127); Sat, 08 Jan 2022 19:48:01 +0000 Received: (at 53127) by debbugs.gnu.org; 8 Jan 2022 19:47:58 +0000 Received: from localhost ([127.0.0.1]:48751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6Hgz-0003mf-LA for submit@debbugs.gnu.org; Sat, 08 Jan 2022 14:47:57 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:37511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6Hgv-0003le-Rx for 53127@debbugs.gnu.org; Sat, 08 Jan 2022 14:47:56 -0500 Received: by mail-wr1-f67.google.com with SMTP id t28so11477724wrb.4 for <53127@debbugs.gnu.org>; Sat, 08 Jan 2022 11:47:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=0Gh+R7NG2o6vAe58tYrtEUpc0Rk0mWPfxl6aYZJ4qKM=; b=orFHjQuv//Ynaw8jAScI6DbL9MTpQC7JIS3UT/OFSAE6PvQ0rhh21bEfKS1bjuIALU zBjGBN3FDlYZU7egjmFDc3qHG9jP1AicmW5T/MFzRxl2B9+9Vukf71BlmE9zFD1IjQiX 2Y0v/0DQNUM1eyBGL9Kn+/YY3DjAnD8tB3C/W5tfpS1NGVOpsmpbSvJ+EALEDnjlTiXf oMstA3s9dl/NauzYDTuEBGvnkWBImogly1Ks0M9Z5bruHij0S+6zb97ZOXqmMAlw8Hwm IHSdTzB5+LboBpGBnrl7qt+1fYoklvNl9NgS04E5OjdGCTAcZuwKforYaKvZtQajIHK/ B3Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=0Gh+R7NG2o6vAe58tYrtEUpc0Rk0mWPfxl6aYZJ4qKM=; b=oLsH8yt9ceD5XW2nZKVFLsI15aIMdOug5Ey97rj/6oknOwd4t3YtbXf7BGID5SbGOn yhsFKwnY2McHmUu0e83COlov7czpVFBk8KjW0mZv/mIItPbskYiks2XrmtfFmUrsqlB1 T3sxu6yCSEOTIa6QhChuQHhQYqVfnDKo8ClGHvI83O09+MVa7dzmGsN6jdy73maNIwda HachPOs2fVUqZ7oYuwuv1ftF65LRlUkfFpWt5BfCeTud9oJdTpqW7iff+gj6HycvKV6Z dstg/x9Ub2lT9yanfE0AKBiY6RWKM1hAv1id7oGAB1Qa0/UhiqAsHSsGYSWRLCf+ByPm 0aiQ== X-Gm-Message-State: AOAM530Iisr+jg5jCK206Uh2S/MljWu8XJuZzsQyr1EnNU+MsMCtvctB gky3c346jYZuhXnQhKdbDuU= X-Google-Smtp-Source: ABdhPJxNDbCcQl74xRKFqzPaKRILHbVrG40yldkP++f6z4f5Pa5x7fLgYD2mpUmdcRTukdmTkRQMVg== X-Received: by 2002:adf:fc0f:: with SMTP id i15mr369924wrr.467.1641671268163; Sat, 08 Jan 2022 11:47:48 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id o16sm2442559wms.4.2022.01.08.11.47.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jan 2022 11:47:47 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Sat, 08 Jan 2022 20:47:46 +0100 In-Reply-To: <87sfty3yb5.fsf@inria.fr> References: <87sfty3yb5.fsf@inria.fr> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641671294; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0Gh+R7NG2o6vAe58tYrtEUpc0Rk0mWPfxl6aYZJ4qKM=; b=osyS/ovJjjOOY6hQ+1+fyj1GAQW1XmvnCp7+j7uCQTe2719svIprBbHvxwDoUZ9yDHD425 tahStzWXHditoT2lm494g79XYvfuab/Lf/qS2wgz7xYjTTOu3Ld/IXOtBh8+bbn5GLyyh+ XoViLA0sBdu7lr61Rq+4Fk5RJkQnk4tyO0Aum4XCv6EGcXvlycL2biyInz+dqLaeTlZJtA qXfK8KRocZblWU1sSsdhbl9/XgZEx1om9N4PbA4xKQuHTKli89ep+BtZmTw+qWcKAvyLsI iDJUJ3iKjQlLnAplxZ6Jws6bXAykdclM4Vjq5lIIG/OBH1O9nmER3SjCtoGsQA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641671294; a=rsa-sha256; cv=none; b=d19DPLQ1JKWk5EkRmsqv4CLnXp6zpqDBAu/XLXu91/e4Xi4LD/LyxkMt44QJEPqytgSRi5 RO99X3d6/1q6u4kI7ZYJJH0n48kfLGBpZ/HBPCOJSYKcohDJJ+YNxUnMTuw3gyjs8KlMWn qU8Bu9ZCQtvOJuJujTS1is3DXAxMlt9y9WBVt5O/lDhPyQN0V+V/PeosDclS0+sB6sWU8r nfShl/p1Ccpx0MO6Iq8OfNRenYoRqz6AjTCgbQaW6qxr/wv/R7TuRQXEmXO/hT9hr5Lkjt i0cj5/VMrTU/pP+P3E3hbE8QYVXV+6Z/Uj6Uj2gid2l15SXfv96fknquz+xIhQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=orFHjQuv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=orFHjQuv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 512C615213 X-Spam-Score: -2.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: Le3Iaxmxl3U0 Am Samstag, dem 08.01.2022 um 18:57 +0100 schrieb Ludovic Courtès: > Hello! > > I’m opening this issue to discuss the possibility of changing > #:cargo-inputs and #:cargo-development-inputs to regular inputs, as a > followup to: > >   https://issues.guix.gnu.org/51845#10 > > I have a preliminary patch for ‘guix style’ and (guix build-system > cargo), but there’s a couple of stumbling blocks. > > First, after the hacky patch in the discussion above, I attempted to > turn #:cargo-inputs into ‘propagated-inputs’ (instead of ‘inputs’), > because that seemed to be somewhat more logical.  That cannot work > though, because then those packages would propagate to non-Rust > packages; for example, librsvg would depend on the “build output” of > rust-* instead of just depending on its source.  Anyway, I’m back to > ‘inputs’. > > Second, until now, these two things would have a different meaning: > >   #:cargo-inputs (list rust-cargo) > > vs. > >   (inputs (list rust-cargo)) > > In the latter case, the package depends on the build result of > ‘rust-cargo’; in the former case, the package depends on the source > of ‘rust-cargo’.  (See ‘rav1e’ for an example where this happens.) I suppose adding (package-source rust-cargo) to inputs to preserve the old meaning would not make much sense? If so, what about having a source output and using (list `(,rust-cargo "source") ...)? > Last, the change to ‘inputs’ would introduce a few cycles at the > level.  Those cycles vanish when we lower to bags and > derivations.  However, because of these cycles, things like ‘guix > refresh -l’ may not work; there might be other unexpected and > undesired side effects. What about making the change incrementally, so that outer layers can start adopting the new style while inner layers are being rebootstrapped. I also think it'd make sense to see how we could detect cycles through static analysis. > Some of these cycles could in theory be removed.  For instance, > ‘rust-cfg-if’ has an optional dependency on ‘rust-compiler-builtins’, > which leads to a cycle, but Cargo won’t let us actually remove that > dependency, even though it’s optional. Could we rewrite the toml file to tell Cargo it has no power over us? Could we define bootstrap mockups? > PS: I guess you already knew all this Efraim but I’m kinda >     (re)discovering it and now experiencing frustration firsthand.  > :-) Let's hope at least someone in our team has overcome Rust fatigue by the time the GCC frontend for it lands. Rust is an incredibly good language, all it needs is a reasonable compiler and build system. Cheers