From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: "Ludovic Courtès" <ludovic.courtes@inria.fr>, 53127@debbugs.gnu.org
Subject: bug#53127: [PATCH RFC] Turning Rust/Cargo inputs into “regular” inputs?
Date: Sat, 08 Jan 2022 20:47:46 +0100 [thread overview]
Message-ID: <f31aa42f47fef21dd459771402601ddbe16998a9.camel@gmail.com> (raw)
In-Reply-To: <87sfty3yb5.fsf@inria.fr>
Am Samstag, dem 08.01.2022 um 18:57 +0100 schrieb Ludovic Courtès:
> Hello!
>
> I’m opening this issue to discuss the possibility of changing
> #:cargo-inputs and #:cargo-development-inputs to regular inputs, as a
> followup to:
>
> https://issues.guix.gnu.org/51845#10
>
> I have a preliminary patch for ‘guix style’ and (guix build-system
> cargo), but there’s a couple of stumbling blocks.
>
> First, after the hacky patch in the discussion above, I attempted to
> turn #:cargo-inputs into ‘propagated-inputs’ (instead of ‘inputs’),
> because that seemed to be somewhat more logical. That cannot work
> though, because then those packages would propagate to non-Rust
> packages; for example, librsvg would depend on the “build output” of
> rust-* instead of just depending on its source. Anyway, I’m back to
> ‘inputs’.
>
> Second, until now, these two things would have a different meaning:
>
> #:cargo-inputs (list rust-cargo)
>
> vs.
>
> (inputs (list rust-cargo))
>
> In the latter case, the package depends on the build result of
> ‘rust-cargo’; in the former case, the package depends on the source
> of ‘rust-cargo’. (See ‘rav1e’ for an example where this happens.)
I suppose adding (package-source rust-cargo) to inputs to preserve the
old meaning would not make much sense? If so, what about having a
source output and using (list `(,rust-cargo "source") ...)?
> Last, the change to ‘inputs’ would introduce a few cycles at the
> <package> level. Those cycles vanish when we lower to bags and
> derivations. However, because of these cycles, things like ‘guix
> refresh -l’ may not work; there might be other unexpected and
> undesired side effects.
What about making the change incrementally, so that outer layers can
start adopting the new style while inner layers are being
rebootstrapped. I also think it'd make sense to see how we could
detect cycles through static analysis.
> Some of these cycles could in theory be removed. For instance,
> ‘rust-cfg-if’ has an optional dependency on ‘rust-compiler-builtins’,
> which leads to a cycle, but Cargo won’t let us actually remove that
> dependency, even though it’s optional.
Could we rewrite the toml file to tell Cargo it has no power over us?
Could we define bootstrap mockups?
> PS: I guess you already knew all this Efraim but I’m kinda
> (re)discovering it and now experiencing frustration firsthand.
> :-)
Let's hope at least someone in our team has overcome Rust fatigue by
the time the GCC frontend for it lands. Rust is an incredibly good
language, all it needs is a reasonable compiler and build system.
Cheers
next prev parent reply other threads:[~2022-01-08 19:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 17:57 bug#53127: [PATCH RFC] Turning Rust/Cargo inputs into “regular” inputs? Ludovic Courtès
2022-01-08 19:47 ` Liliana Marie Prikler [this message]
2022-01-10 8:58 ` Ludovic Courtès
2022-01-10 20:24 ` Liliana Marie Prikler
2022-01-11 10:11 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f31aa42f47fef21dd459771402601ddbe16998a9.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=53127@debbugs.gnu.org \
--cc=ludovic.courtes@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).