From mboxrd@z Thu Jan  1 00:00:00 1970
From: goodoldpaul@autistici.org
Subject: bug#40710: node-build-system should not install tests
Date: Sun, 19 Apr 2020 09:12:20 +0000
Message-ID: <eee33db71991f14383a67a853abf8e7e@autistici.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:48158)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jQ60d-0000yi-77
 for bug-guix@gnu.org; Sun, 19 Apr 2020 05:13:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jQ60c-00068v-N7
 for bug-guix@gnu.org; Sun, 19 Apr 2020 05:13:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:60720)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jQ60c-00068O-Ak
 for bug-guix@gnu.org; Sun, 19 Apr 2020 05:13:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jQ60c-000659-4q
 for bug-guix@gnu.org; Sun, 19 Apr 2020 05:13:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.40710.B.158728755723341@debbugs.gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:47938)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <goodoldpaul@autistici.org>) id 1jQ60A-0000jf-Is
 for bug-guix@gnu.org; Sun, 19 Apr 2020 05:12:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1)
 (envelope-from <goodoldpaul@autistici.org>) id 1jQ609-0004ag-Tg
 for bug-guix@gnu.org; Sun, 19 Apr 2020 05:12:34 -0400
Received: from devianza.investici.org ([198.167.222.108]:59153)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <goodoldpaul@autistici.org>)
 id 1jQ609-00042n-42
 for bug-guix@gnu.org; Sun, 19 Apr 2020 05:12:33 -0400
Received: from 1.mail-backend.investici.org (unknown [10.0.0.11])
 by devianza.investici.org (Postfix) with ESMTP id A065AE0541
 for <bug-guix@gnu.org>; Sun, 19 Apr 2020 09:12:20 +0000 (UTC)
Received: from 1.webmail.investici.org (localhost [127.0.0.1])
 (Authenticated sender: goodoldpaul@autistici.org)
 by 1.mail-backend.investici.org (Postfix) with ESMTPA id 82BF8C1FA7
 for <bug-guix@gnu.org>; Sun, 19 Apr 2020 09:12:20 +0000 (UTC)
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
To: 40710@debbugs.gnu.org

As discussed here [0], node-build-system right now installs all the 
contents of a package's root node_modules directory, including i.e. 
tests.
We should investigate how exactly npm decides what to install and try to 
replicate that inside node-build-system. It seems likely that it uses 
the "files" array from the package.json file (see [1-2]).

[0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36599
[1]: https://github.com/colorjs/color-name/blob/master/package.json#L6
[2]: https://github.com/npm/node-semver/blob/master/package.json#L21