From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arun Isaac Subject: bug#27222: [PATCH] emacs-build-system install phase doesn't honor directory hierarchy Date: Mon, 05 Jun 2017 00:55:11 +0530 Message-ID: References: <87h8zwptdn.fsf@gmail.com> <874lvwp7km.fsf@gmail.com> <87wp8rq57k.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dHbA6-0005c2-82 for bug-guix@gnu.org; Sun, 04 Jun 2017 15:26:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dHbA2-0001mw-Tk for bug-guix@gnu.org; Sun, 04 Jun 2017 15:26:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53457) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dHbA2-0001mg-Dj for bug-guix@gnu.org; Sun, 04 Jun 2017 15:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dHbA2-0006xK-1b for bug-guix@gnu.org; Sun, 04 Jun 2017 15:26:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <87wp8rq57k.fsf@gmail.com> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Alex Kost Cc: Maxim Cournoyer , 27222@debbugs.gnu.org > As far as I understand it, it was done for purpose: some packages > include "uninteresting" (for tests, maintenance, etc.) *.el files in > subdirs, that's why they are excluded by default. So probably a better > solution would be to fix 'ert-runner' package (as it is done in commit > b1d32ec0e23bfec1dab4c56909228a494b2b0d60, for example). WDYT? I agree. The solution is to fix the ert-runner package, not the emacs-build-system. > This change also doesn't prevent excluding subfolders if they are truly > unnecessary (such as tests subfolder), but this should happen due to > explicit regexp in the exclude option, not because *all* subfolders are > excluded. We adopted the policy of excluding *all* subfolders from MELPA. From their "Recipe Format" section at https://github.com/melpa/melpa "Note that elisp in subdirectories is never included by default, so you might find it convenient to separate auxiliiary files such as tests into subdirectories to keep packaging simple." I think this is a good policy. If we include subfolders by default, we'll have to modify many packages with #:exclude arguments to get rid of unnecessary subfolders. However, if we exclude subfolders by default, we'll only have to modify fewer packages with #:include arguments. > I also think these arguments are redundant! I suggested to remove this > duplication at: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26559#41 And, I did respond at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26559#53 > ... but I think the include/exclude arguments need to be duplicated in > two places. For example, look at arguments #:strip-flags and > #:strip-directories in the `strip' phase of the gnu-build-system. Even > there, the default values of the arguments are repeated in two places. Do you know of some way in which we can avoid duplication of the arguments? Even the gnu-build-system duplicates default values of arguments. =