From: Maxime Devos <maximedevos@telenet.be>
To: "Maxim Cournoyer" <maxim.cournoyer@gmail.com>,
"Ludovic Courtès" <ludo@gnu.org>
Cc: 55898@debbugs.gnu.org
Subject: bug#55898: Services depending on new Shepherd features may fail until reboot
Date: Thu, 1 Sep 2022 15:28:01 +0200 [thread overview]
Message-ID: <d06b945a-3c6a-17ab-4179-18c6ba7479b7@telenet.be> (raw)
In-Reply-To: <87tu5r8c8m.fsf@gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1803 bytes --]
On 01-09-2022 15:18, Maxim Cournoyer wrote:
> I had something different on mind; I was thinking of some added field to
> our shepherd-service object where the minimal version of Shepherd
> required could be specified, e.g. "0.9.1".
>
> The check could be abstracted in the shepherd-service implementation,
> avoiding services writers to handle that by themselves in*each* service
> requiring so.
>
> The benefit would be an improved user experience, and cleaner service
> code. Upon reconfiguring a machine not yet equipped with a new enough
> Shepherd, Shepherd could print:
>
> --8<---------------cut here---------------start------------->8---
> The x, y and z services won't be started until the next reboot, as they
> require a newer Shepherd version.
> --8<---------------cut here---------------end--------------->8---
>
> Instead of seeing the new services fail to run without (for the end
> user) without any obvious reason.
>
> Does that make sense?
I like this system, it's declarative, simple and doesn't have the
defined?-looks-in-(current-module) problem. It also avoids accumulating
compatibility fallbacks that probably won't be well-tested.
If something like (defined? 'whatever) is desired instead of version
checks (though I don't see the value here, see Maxim explanation on
different contexts), a similar system based on feature checks could be
used instead:
(require-exports ; <-- the field
'(((module name) this that ...)
[...]))
The (if (defined? ...) preferred compat) pattern could be preserved for
the case where a patch author puts in some extra effort to not require
reboots on systems where an old shepherd is running, but a simple
version check or feature check would be accepted too.
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-09-01 13:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 5:53 bug#55898: jami service failing following 'guix deploy' update Maxim Cournoyer
2022-06-11 14:51 ` Maxime Devos
2022-06-14 19:40 ` Maxim Cournoyer
2022-06-24 17:52 ` Maxim Cournoyer
2022-06-24 18:01 ` bug#55898: jami service failing following reconfigure Maxim Cournoyer
2022-07-06 21:38 ` bug#55898: jami service failing following 'guix deploy' update Maxim Cournoyer
2022-07-06 22:01 ` Maxim Cournoyer
2022-07-20 21:19 ` bug#55898: Services depending on new Shepherd features may fail until reboot Ludovic Courtès
2022-07-21 4:10 ` Maxim Cournoyer
2022-08-29 13:43 ` Ludovic Courtès
2022-08-29 21:06 ` Maxim Cournoyer
2022-08-30 7:33 ` Ludovic Courtès
2022-08-30 9:35 ` Maxime Devos
2022-08-30 13:50 ` Ludovic Courtès
2022-09-01 13:18 ` Maxim Cournoyer
2022-09-01 13:28 ` Maxime Devos [this message]
2022-09-01 13:51 ` Ludovic Courtès
2022-09-01 19:16 ` Maxim Cournoyer
2022-09-02 9:10 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d06b945a-3c6a-17ab-4179-18c6ba7479b7@telenet.be \
--to=maximedevos@telenet.be \
--cc=55898@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).