From mboxrd@z Thu Jan 1 00:00:00 1970 From: mikadoZero Subject: bug#35047: "Running the Test Suite" root user Date: Sat, 30 Mar 2019 11:30:52 -0400 Message-ID: References: <874l7ka2ve.fsf@nckx> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:53991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hAFy4-0003js-OC for bug-guix@gnu.org; Sat, 30 Mar 2019 11:32:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hAFxx-0005R5-HA for bug-guix@gnu.org; Sat, 30 Mar 2019 11:32:22 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52214) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hAFxi-0005MN-5C for bug-guix@gnu.org; Sat, 30 Mar 2019 11:32:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hAFxh-0004PT-TC for bug-guix@gnu.org; Sat, 30 Mar 2019 11:32:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <874l7ka2ve.fsf@nckx> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Tobias Geerinckx-Rice Cc: 35047@debbugs.gnu.org Tobias Geerinckx-Rice writes: > mikadoZero, > > mikadoZero wrote: >> Looking at "2.3 Running the Test Suite" of the manual it does not >> mention that tests should be run as a non root user. > > I guess this is one of those (Unix-)cultural knowledge things: it > wouldn't even occur to me to build or test anything as root unless > explicitly asked to do so :-) > >> The test `tests/pack` fails when `make check` is run as a root user. >> It >> does not fail when run as a non root user. I found this example by >> running `make check TESTS=3D"tests/pack.scm"`. Is this an issue for >> many >> tests? >> >> I can prepare a patch for the relevant part (parts if this also >> applies >> to `make check-system` as well) in "2.3 Running the Test Suite" of >> the >> manual. > > Thanks for the offer! I think adding yet another gotcha to the manual > should be a last resort, though. Many people still miss them and get > into trouble (and on to IRC). > > Could we, in order of preference: > > - make these tests pass even when run as root? (I guess not?) > - skip them and add =E2=80=98n tests not run as root=E2=80=99 to the fina= l tally? > - refuse to even start the test suite as root? > > What =E2=80=98root=E2=80=99 means here will depend on why these tests are= failing. > > Kind regards, > > T G-R Preventing the issue instead of warning of it in the manual sounds like a better solution to me.