From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: 44906@debbugs.gnu.org, "Mark H Weaver" <mhw@netris.org>,
zimoun <zimon.toutoune@gmail.com>,
"Ludovic Courtès" <ludo@gnu.org>
Subject: bug#44906: [PATCH 0/3] Properly construct URLs if base-url has trailing slash
Date: Fri, 9 Jul 2021 10:38:38 +0200 [thread overview]
Message-ID: <cover.1625818877.git.h.goebel@crazy-compilers.com> (raw)
In-Reply-To: <87zh2udx4j.fsf@netris.org>
Here is now an attempt to solve the issue. It had to be fixed in
guix/substitutes.scm and guix/ci.scm only. In guix/scripts/publish.scm I did
not spot any place where wrong URLs are constructed.
Many thanks to Mark for pointing to 'resolve-uri-reference'.
Regarding CI: I did some tests, so these should work. Anyhow, I did not find a
tests-suite for fully testing this part.
Hartmut Goebel (3):
substitute: Fix handling of short option "-h".
substitutes: Properly construct URLs.
ci: Properly construct URLs.
guix/ci.scm | 79 +++++++++++++++++++++----------------
guix/scripts/substitute.scm | 2 +-
guix/substitutes.scm | 13 +++---
3 files changed, 55 insertions(+), 39 deletions(-)
--
2.30.2
prev parent reply other threads:[~2021-07-09 8:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 21:19 bug#44906: Substitute requests fail if URL has trailing slash Hartmut Goebel
2020-11-27 23:37 ` zimoun
2020-11-28 9:47 ` Hartmut Goebel
2020-12-03 17:01 ` Ludovic Courtès
2020-12-04 4:15 ` Mark H Weaver
2021-07-09 8:38 ` Hartmut Goebel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1625818877.git.h.goebel@crazy-compilers.com \
--to=h.goebel@crazy-compilers.com \
--cc=44906@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=mhw@netris.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).