From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2CiGLYrBJ2LpFgEAgWs5BA (envelope-from ) for ; Tue, 08 Mar 2022 21:50:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id oGtCKorBJ2LsBAEAauVa8A (envelope-from ) for ; Tue, 08 Mar 2022 21:50:18 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 73DE73C517 for ; Tue, 8 Mar 2022 21:50:18 +0100 (CET) Received: from localhost ([::1]:45854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nRgmf-0004Np-F6 for larch@yhetil.org; Tue, 08 Mar 2022 15:50:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nRgmR-0004Nf-4t for bug-guix@gnu.org; Tue, 08 Mar 2022 15:50:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35885) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nRgmQ-0001Zl-Oj for bug-guix@gnu.org; Tue, 08 Mar 2022 15:50:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nRgmQ-0006hA-M1 for bug-guix@gnu.org; Tue, 08 Mar 2022 15:50:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#54292: Commit e8518c43 breaks guix pull on i686 Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 08 Mar 2022 20:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54292 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Philip McGrath , Diego Nicola Barbato Received: via spool by 54292-submit@debbugs.gnu.org id=B54292.164677258225704 (code B ref 54292); Tue, 08 Mar 2022 20:50:02 +0000 Received: (at 54292) by debbugs.gnu.org; 8 Mar 2022 20:49:42 +0000 Received: from localhost ([127.0.0.1]:58015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRgm6-0006gW-Is for submit@debbugs.gnu.org; Tue, 08 Mar 2022 15:49:42 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:44958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nRgm4-0006gH-Vb for 54292@debbugs.gnu.org; Tue, 08 Mar 2022 15:49:41 -0500 Received: by mail-ed1-f65.google.com with SMTP id x5so265854edd.11 for <54292@debbugs.gnu.org>; Tue, 08 Mar 2022 12:49:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=kj3YkmsfQ2Khr4Ec75GqkBFqHwBIs5QBZQP+CXUBwV8=; b=HKP/3TyhKuLZUXMJ22zJSSC8hmhZxIWbtJOIkIi6IQqTyoFLiMr1+y8/ERDnj5l7YN ZLCMr3e0uzVdaUuwAQu9tq3p6LJWN9zRxZxYi7gP3JKUFuC5DveeMbOWz8St5mmDjLrk VrcjqsD/hs9f87EL+Aw7VqWj6X82t0tSgcJN7aqwKaj1mDKKmET0SzkkXATra5lGptHa hp1pWj3A6KIjzPl2oErk/FXs1JWNWwjrVH+D2ofDnxh3vTDCeS3i+W1AdaQ3ADASUnOb i9EgQb0N/Ih5hb41V5Ij96ZjC7rsFbO2pPfMnXAj/QOqMnwWUgHEQ5SVSqIbdNF8HfI/ lStQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=kj3YkmsfQ2Khr4Ec75GqkBFqHwBIs5QBZQP+CXUBwV8=; b=Dy2k9zuTZG/UYgnufSa1bcQs/mQdLWAt5BSRs+8u6c62OtynQnMZH/1xBV6Fl1aSCF FxsMceS5BpEWK6H9scvBE5KIG1iPaUlNkx3412BWm8cd/0jou7YXVk6fc0jBb8c5Ng6+ 8k57JrYlFDgnt8DjOI/S/AYcw2B6A2jevUzzJ95++v0EX70jjyyRPqHjygwyva2V0KoM b6sQOMzbKWLIJ8wr1e51W13YQmJYtj+ZO8teB3x6+6FwGEfhJuGpEDBxeDDOt/q27bp1 nm7ogHAvKBGHm1pJfAiYymlufTY0xi4YUq2TPUPBI1AVvfoQPaPe5lVVzHCS1rt2WFQN wxiA== X-Gm-Message-State: AOAM530+geo4j2jWRLzP2B2JtRHTGJllni397ltCqXOfRejzADB+UUEG 3QkQ6Pv6RXVQp+BdZHwldR8= X-Google-Smtp-Source: ABdhPJwTbMN9YBy3rTiubN7LYBLTwKVdv814PnLP+qlAnJ4qyw0hvhHJ+RDa9JLAcP1CGa9bty+tyQ== X-Received: by 2002:a05:6402:442:b0:416:14b7:4d55 with SMTP id p2-20020a056402044200b0041614b74d55mr17831052edw.183.1646772574950; Tue, 08 Mar 2022 12:49:34 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id q2-20020a170906144200b006ceb8723de9sm6180337ejc.120.2022.03.08.12.49.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 12:49:34 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Tue, 08 Mar 2022 21:49:32 +0100 In-Reply-To: <5216289.ggv9HUQsqW@bastet> References: <87sfru0w0h.fsf@GlaDOS.home> <5216289.ggv9HUQsqW@bastet> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 54292@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1646772618; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kj3YkmsfQ2Khr4Ec75GqkBFqHwBIs5QBZQP+CXUBwV8=; b=lbyvY6pO6YPyL/BBD7RZ0kBjGtrHpXU4TTbjoBu+zKXIOfzeqOO/zCVC04XEE45K2g4LJK pcOt5V3hbUM8qA4r/9ju+FMhiKFTA9egT1Cv7TS2ojLW+FV2u8gNcv4v22Dv8FK/s/jQYJ GnguB7HYL2KZpo/Ql5BjvBO0UVmBTiuF19Yl1WIfNkEfZqL47IAKXIvPPR4HJnXZoq5DUA hK9S6IWbC6sIn2oyEktIRaqcUROd1Q6l/idqdKOwU/LZ+5KcjvXSbASQDF1ilIZtZEPVFe q6qpUw+5Nv5IyDeCklb6U7olrMo8Zrl6PzkkViprD2RrCIjCv3d+F4nuUOTesQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1646772618; a=rsa-sha256; cv=none; b=kKlkTOV536uaIVn6NCgBovNausZbOqcHyrvUZAGUkPmvVDHJchgK4ZtU1BzlYhDboyOJc0 NSLhmVF0uahE8/rxHVFJslmBhEFmEAXVlI7pxloeKZRsiqT9HkGHX7j3O0QDYr7TRoRanc SHfEpPtIOLAe/I/3+qYVE7/WO5JLPWzgR4gFbEwzaSJO7pvNcjmtNH0LZHdjmGlxp7ERCS MSLgOEfs812eUwwgaBUwtS/3KQZxq3ErfsDnk0oVRTulBwLFh8tr+NsoWByawdh1bQCRfY viLS7rMeemW/QWFaLemP9wL2eU71XfpzxJDrqGaiHRS7QC7wlhqBymS0/Vcbtw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="HKP/3Tyh"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.38 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="HKP/3Tyh"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 73DE73C517 X-Spam-Score: 5.38 X-Migadu-Scanner: scn0.migadu.com X-TUID: TxtPrp2oWodk Am Dienstag, dem 08.03.2022 um 13:33 -0500 schrieb Philip McGrath: > I can see (at least) two paths forward: > >   1. `%nix-{arch,os}-to-chez-alist` could become many-to-one rather > than one-to-one. Presumably we'd use the first applicable entry > when going from Chez to Nix. > >   2. We could give up on alists and use existing predicates from > (guix utils) like `target-x86-32?`, as Liliana had already > suggested during review for `chez-upstream-features-for-system`. > > I liked the alists because they made the bidirectional relationship > obvious, but I wonder if there are other potential pitfalls analogous > to this one. Maybe someone more familiar with non-x86_64 systems in > Guix/Nix than I am should decide. There is no 1:1 mapping to be found here as far as I can see. Likewise, the reverse mapping is currently unused and should in my opinion be dropped so that people don't expect a round-trip to be well- defined. > OTOH, while it's definitely a bug that `(nix-system->chez-machine > "i686-linux")` currently returns `#f`, it seems like the more > immediate problem is from the `maybe-compile` phase of > the stex-bootstrap package, where this code: > >                         (define machine >                           #$(chez-machine->threaded >                              (nix-system->chez-machine))) > > assumes, apparently incorrectly, that it's only going to be run when > the result of `nix-system->chez-machine` is non-false. In other > words, even if we fix the bug in `nix-system->chez-machine` for i686, > I think we'd still hit this problem for systems that Chez really > doesn't support, e.g. ppc64le or MIPS. I don't know what the most > correct way would be to write this code, but I think we could defer > the error until someone attempts to build the package for the > unsupported system by just writing something like: > >                         (define machine >                           #$(and=> (nix-system->chez-machine) >                                    chez-machine->threaded)) I pushed that definition upstream, but a rewrite is still needed. I also think this logic should be a little decoupled from the question of whether or not a given nix-system is supported. While surely this function returning #f means it's not, there are still other questions to consider. An implementation could look like the following (define* (nix-system->chez-machine system #:key threaded?) (false-if-exception (string-append (if threads? "t" "") (cond ((target-x86_64? system) "a6") ...) (cond  ((target-linux? system) "le") ...)))) Cheers