From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id OC74D56cM2Uu1QAAauVa8A:P1 (envelope-from ) for ; Sat, 21 Oct 2023 11:40:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id OC74D56cM2Uu1QAAauVa8A (envelope-from ) for ; Sat, 21 Oct 2023 11:40:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EE3D940A3F for ; Sat, 21 Oct 2023 11:40:45 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=zancanaro.id.au header.s=k1 header.b=PDgcJRqE; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=zancanaro.id.au (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697881246; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=D13rE6HqSrLglhrHuJ19dRV4u/pNiGThICrYKrXobvg=; b=FTt+msbjW1jsVfa1nKM+e23cK9+4sMXAtzudJ9Ap4pfD4cRvg8VpPY5ft+Wm5h4msFdJ0m wXCv9+limINgp9dKNg8RBm1BqjZZRLdI+kcRLuseto+ARUNqOcdnl9tVpoOvPLaPLDm8mn hZC3nsOI8dP1Znp5sf6CzTt+PcR9G5f728TudFJedpZkc6LY8xkbWIyVdV/d0+Wrc5SLbK bqNCveZJcSLdbXMxJY9orFolnRKZawX4tb2qdaNwI21wLWfydiqIUUXj+IdxYi1Zilt9iJ xRYpSEn0UeNavSpeWzgR5Iu9DXwoGNHyDOd8O4LIGsD/0HglMFaIKa4I3dshcg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697881246; a=rsa-sha256; cv=none; b=cOCm585jb1Cuh9BC0vzpr7slylXmrYU8KMlveHkS4zyQAdGS/7SZJPp3HwZLrmSbNS2rVA Ze+bEGSjTzj2obyCAnUkrjFW7/A2Day7Dd2l2XMMdwChoaIthmBxIggtz4EjxAkKOOUE/t LAlj3WkBXX/UZ0dFy1RoTBPrmuFDH/pBC+rrQVZNsQVV0E3Q31FhdmjrGR6vIUij/Dwnc0 LxThu9isgw1l+DHLsAq+PA6Htus8j8ja32MTNvGBApbPM3ZoEjRf38HlInlMRKK6/y3Idu fQTYt7ri+fawn/sDsuuSExDqznLKOQo0ZLeTQ2mZ3cvGYm+Da6V6gGrppJPQjQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=zancanaro.id.au header.s=k1 header.b=PDgcJRqE; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=zancanaro.id.au (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qu8TE-00082P-NA; Sat, 21 Oct 2023 05:40:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qu8TC-00081z-Hn for bug-guix@gnu.org; Sat, 21 Oct 2023 05:40:34 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qu8TC-0001UE-8c for bug-guix@gnu.org; Sat, 21 Oct 2023 05:40:34 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qu8Td-0007MK-NR for bug-guix@gnu.org; Sat, 21 Oct 2023 05:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#66659: [PATCH] home: services: Don't crash on-first-login when nothing to do Resent-From: Carlo Zancanaro Original-Sender: "Debbugs-submit" Resent-CC: , bug-guix@gnu.org Resent-Date: Sat, 21 Oct 2023 09:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66659 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 66659@debbugs.gnu.org Cc: ( , Andrew Tropin , Ludovic =?UTF-8?Q?Court=C3=A8s?= X-Debbugs-Original-Xcc: ( , Andrew Tropin , Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 66659-submit@debbugs.gnu.org id=B66659.169788121528217 (code B ref 66659); Sat, 21 Oct 2023 09:41:01 +0000 Received: (at 66659) by debbugs.gnu.org; 21 Oct 2023 09:40:15 +0000 Received: from localhost ([127.0.0.1]:42216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu8St-0007L2-3e for submit@debbugs.gnu.org; Sat, 21 Oct 2023 05:40:15 -0400 Received: from voltorb.zancanaro.id.au ([45.77.50.64]:47410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu8Sn-0007Kj-VP for 66659@debbugs.gnu.org; Sat, 21 Oct 2023 05:40:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=k1; bh=D13rE6HqSrLglhr HuJ19dRV4u/pNiGThICrYKrXobvg=; h=references:in-reply-to:date:subject: to:from; d=zancanaro.id.au; b=PDgcJRqEkF6YKbRHPrVPez+CpJMAQuLs9VU1yqji NAIqxFJgsVbOKPUhg5SPTQLdAi1xo7hpvtYiU6mj9TKOveuTbE2rJg63omwwIJIq0fj947 SABXoyG3GPUFZ8h5jwzPIjmgmxblvp5cRYwu/ijsetXMNT69GpgqN7OHWtJ2E= Received: by voltorb.zancanaro.id.au (OpenSMTPD) with ESMTPSA id 957c49ed (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <66659@debbugs.gnu.org>; Sat, 21 Oct 2023 09:39:09 +0000 (UTC) From: Carlo Zancanaro Date: Sat, 21 Oct 2023 20:39:21 +1100 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: <87pm18codq.fsf@zancanaro.id.au> References: <87pm18codq.fsf@zancanaro.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: 4.36 X-Migadu-Queue-Id: EE3D940A3F X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: 4.36 X-TUID: nQwuE5sy92/0 * gnu/home/services.scm (compute-on-first-login-script): Ensure that WHEN is syntactically valid in expansion. --- gnu/home/services.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gnu/home/services.scm b/gnu/home/services.scm index 651c068f79..3f018e3893 100644 --- a/gnu/home/services.scm +++ b/gnu/home/services.scm @@ -435,7 +435,10 @@ (define (compute-on-first-login-script _ gexps) ;; after complete logout/reboot. (if (file-exists? xdg-runtime-dir) (when (claim-first-run flag-file-path) - #$@gexps) + #$@gexps + ;; An empty WHEN body is not syntactically valid, so we put an + ;; arbitrary form here to ensure it's not empty. + #t) ;; TRANSLATORS: 'on-first-login' is the name of a service and ;; shouldn't be translated (warning (G_ "XDG_RUNTIME_DIR doesn't exists, on-first-login script base-commit: 80c8f5b57aa3699445fab29e0f75f5955e697509 -- 2.41.0