From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mP4BK9AQrWHqFgEAgWs5BA (envelope-from ) for ; Sun, 05 Dec 2021 20:19:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iKy4JtAQrWEuPQAA1q6Kng (envelope-from ) for ; Sun, 05 Dec 2021 19:19:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 543E62ED4D for ; Sun, 5 Dec 2021 20:19:44 +0100 (CET) Received: from localhost ([::1]:42638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtx2z-0001Mt-It for larch@yhetil.org; Sun, 05 Dec 2021 14:19:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtx2N-0001MA-I8 for bug-guix@gnu.org; Sun, 05 Dec 2021 14:19:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47937) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtx2M-0006Fw-IF for bug-guix@gnu.org; Sun, 05 Dec 2021 14:19:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mtx2M-0002Ob-Eo for bug-guix@gnu.org; Sun, 05 Dec 2021 14:19:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52316: Package example from cookbook has bugs Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 05 Dec 2021 19:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52316 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 52316@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16387319089161 (code B ref -1); Sun, 05 Dec 2021 19:19:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Dec 2021 19:18:28 +0000 Received: from localhost ([127.0.0.1]:59482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtx1o-0002Nh-FE for submit@debbugs.gnu.org; Sun, 05 Dec 2021 14:18:28 -0500 Received: from lists.gnu.org ([209.51.188.17]:43874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtx1m-0002Na-Od for submit@debbugs.gnu.org; Sun, 05 Dec 2021 14:18:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtx1l-00012H-SF for bug-guix@gnu.org; Sun, 05 Dec 2021 14:18:26 -0500 Received: from [2a02:1800:110:4::f00:18] (port=45352 helo=michel.telenet-ops.be) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtx1j-0006CE-2f for bug-guix@gnu.org; Sun, 05 Dec 2021 14:18:24 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id SjJH2600D4UW6Th06jJHNw; Sun, 05 Dec 2021 20:18:18 +0100 Message-ID: From: Maxime Devos Date: Sun, 05 Dec 2021 19:18:17 +0000 Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1638731898; bh=uUwCHp6ciNQwFyZjf7vVPIlw/tFs9fzAdbgemR0Ge5E=; h=Subject:From:To:Date; b=WMskKCBtAOMDo9Y7bHMv3WrQzG2indQcsrVouTIVmAmH5vz6VE395L9kCblyLVt4a 2gS6gjbQxmoqkRHB1avEC9orOcR6GPwd0m9oQMGrVBMd/ZL0Lj12E6TFNteGLCrI4X hj4Hgfg6XvesenciJw5HJTxmmsbFecfZVhVlgCJtvuXv4ecy/0OaPjBcr5ikZtta/5 zozqYo8XuOWEZkal+1f5geNGay1pc7E97ua372XDeE3e+mVCbPq04/SAw+4vSZRX0w BtQBuuBpFDzto+3ReWVNj6Gf0YDE/78IOcOuA5dADQGZc1Iztpa0ro8A6Wl+k+toQt 2aHa7ZP5WFNaA== X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:1800:110:4::f00:18 (failed) Received-SPF: pass client-ip=2a02:1800:110:4::f00:18; envelope-from=maximedevos@telenet.be; helo=michel.telenet-ops.be X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638731984; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=uUwCHp6ciNQwFyZjf7vVPIlw/tFs9fzAdbgemR0Ge5E=; b=Ghy24JCw5stb9lYxhtoMsrwwMbE/eDz5Hx/YcX1sjohYDgcGXUlwo7W88k6/LBjoPezJr7 Q/Yd48r2m59fP62WS6zo06HE4Y2jsmqGO35cYWvcYx8u+2FRdW2mGPxZoQPFmJMv2VweV8 0bAP0KnPks6kjVR+86U7mSW5XKGw9ujSVyYqh7DjbuMpPYg4PFyxO/1+u9zkxoFGp1ojej qaYoLt3MEK2D00lJq2ELyIQB4QhEo1SF+1DYCjpqBvD/y94E4aADoIQ1T+suCbKppJFw/z prTSsCKdiTfXdd8rOYK7u1GMl8Dw445Q/dVozuYnF47/8XgMwUTrrCEcz5qdYQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638731984; a=rsa-sha256; cv=none; b=ek3lrTP96OPBVzLBc0LVknNs8NG+vyXoSqfmu5A3PHEvYmEWmc1lfBqJxZEm6WUcqb4M8U c1CJQotFNrIasmQcUQCusHrXDrWxmcg8jTqT0tsHjxrhlfqRkGMg5imycKkwFm5edtHsNC hvjPGoz+jn3kEp8+Q0CQcU7fAn5RyItNCBADRkZfxK72fx23xtJXQ/SnOPoIn9TfN3NeSm erNn45hwXqpuCApfFW09ZoNdfkB1Xq1n9lXLZ868r6uWh4SMUkKv+YrPEYfRXRBrggC4Eh OBi8bAzEcvZb76KBAMDbUMJcb1vqmlTtEDieZMvFi4MUPeUq6j3Sm72XRS9qAQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=WMskKCBt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.14 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=WMskKCBt; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 543E62ED4D X-Spam-Score: -2.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: Ypk04hCnJfV9 Hi guix, The example at https://guix.gnu.org/cookbook/en/html_node/Extended-example.html has two bugs: #:tests? is unconditionally set to #true. This is bad for cross- compilation and --without-tests=PACKAGE reasons, and would be flagged by the linter. In the new 'check' phase, libgit2_clar is invoked unconditionally. This would be flagged by the linter. Also, not exactly a bug, but still bad practice: the web page suggests: #:make-flags (list (string-append "prefix=" (assoc-ref %outputs "out")) "CC=gcc") however, hardcoding gcc is bad for cross-compilation reasons. It should use (cc-for-target) instead. Greetings, Maxime