From: Maxime Devos <maximedevos@telenet.be>
To: "Ludovic Courtès" <ludo@gnu.org>, zimoun <zimon.toutoune@gmail.com>
Cc: 50597@debbugs.gnu.org
Subject: bug#50597: different fixed-output when using ’--with-source’ transformation
Date: Sat, 18 Sep 2021 19:35:12 +0200 [thread overview]
Message-ID: <bfbc4c2bd52137e55afb32c424e62d576d9cbf73.camel@telenet.be> (raw)
In-Reply-To: <87fsu1uaup.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
Ludovic Courtès schreef op za 18-09-2021 om 18:06 [+0200]:
> Hello!
>
> zimoun <zimon.toutoune@gmail.com> skribis:
>
> > Why the store item of source tarball is it different when applying the
> > transformation?
> >
> > Maxime provided a clue [1].
>
> Maxime is right: ‘--with-source’ passes #:recursive? #t unconditionally,
> whereas it’s usually #f for a ‘url-fetch’ kind of URI.
>
> What we could do is make it #t if and only if the URL denotes a local
> file and that file is a directory. I think that would achieve what you
> want without any observable regression in practice.
>
> WDYT?
This seems reasonable to me.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-09-18 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 5:44 bug#50597: different fixed-output when using ’--with-source’ transformation zimoun
2021-09-18 16:06 ` Ludovic Courtès
2021-09-18 17:35 ` Maxime Devos [this message]
2021-09-21 7:40 ` zimoun
2021-09-22 10:25 ` Ludovic Courtès
2021-10-13 9:31 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfbc4c2bd52137e55afb32c424e62d576d9cbf73.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=50597@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).