From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Taiju HIGASHI <higashi@taiju.info>, 55495@debbugs.gnu.org
Subject: bug#55495: [PATCH] gnu: emacs-haskell-mode: Fix build.
Date: Thu, 19 May 2022 21:09:14 +0200 [thread overview]
Message-ID: <bd9e0aa3d659f561a245203a1a17e5125ddcd7c6.camel@gmail.com> (raw)
In-Reply-To: <20220518143129.10357-1-higashi@taiju.info>
Hi,
Am Mittwoch, dem 18.05.2022 um 23:31 +0900 schrieb Taiju HIGASHI:
> * gnu/packages/emacs-xyz.scm (emacs-haskell-mode): Fix build.
> ---
> gnu/packages/emacs-xyz.scm | 9 +-
> .../emacs-haskell-mode-fix-tests.patch | 282
> ++++++++++++++++++
> 2 files changed, 289 insertions(+), 2 deletions(-)
> create mode 100644 gnu/packages/patches/emacs-haskell-mode-fix-
> tests.patch
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 529e9329d6..9d9669f383 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -1553,11 +1553,16 @@ (define-public emacs-haskell-mode
> (commit version)))
> (file-name (git-file-name name version))
> (sha256
> - (base32
> "0zxbacqzr84krmhqpvzndnvlcjh1gs1x20ys0dykgd7chyhci5j5"))))
> + (base32
> "0zxbacqzr84krmhqpvzndnvlcjh1gs1x20ys0dykgd7chyhci5j5"))
> + ;; Submitted for inclusion upstream.
> + ;; Not identical patches due to different target versions.
> + ;; (see: https://github.com/haskell/haskell-mode/pull/1780)
> + (patches
> + (search-patches "emacs-haskell-mode-fix-tests.patch"))))
> (propagated-inputs
> (list emacs-dash))
> (native-inputs
> - (list emacs-minimal emacs-el-search emacs-stream texinfo))
> + (list emacs-minimal emacs-el-search emacs-stream texinfo git))
There are other ways of suppressing errors caused by git. One of them
would be to set vc-handled-backends to nil for the tests.
> +- "Classify the current line into 'section-header 'subsection-
> header 'section-data 'comment and 'empty '"
> ++ "Classify the current line into 'section-header 'subsection-
> header
> ++'section-data 'comment and 'empty '"
LGTM.
> +- "Enumerate .cabal targets. PROCESS-TYPE determines the format of
> the returned target."
> ++ "Enumerate .cabal targets. PROCESS-TYPE determines the format of
> the
> ++returned target."
LGTM.
> +-Module names in exposed-modules and other-modules are expanded by
> replacing each dot (.) in the module name with a forward slash (/)
> and appending \".hs\"
> ++Module names in exposed-modules and other-modules are expanded by
> ++replacing each dot (.) in the module name with a forward slash (/)
> and
> ++appending \".hs\"
LGTM.
> +- "Default build command to use for `haskell-cabal-build' when a
> cabal file is detected.
> ++ "Default build command to use for `haskell-cabal-build' when a
> cabal
> ++file is detected.
LGTM.
> +- "Alternative build command to use when `haskell-cabal-build' is
> called with a negative prefix argument.
> ++ "Alternative build command to use when `haskell-cabal-build' is
> ++called with a negative prefix argument.
LGTM.
> +- "Default build command to use for `haskell-stack-build' when a
> stack file is detected.
> ++ "Default build command to use for `haskell-stack-build' when a
> stack
> ++file is detected.x
Additional x.
> +- "Alternative build command to use when `haskell-stack-build' is
> called with a negative prefix argument.
> ++ "Alternative build command to use when `haskell-stack-build' is
> ++called with a negative prefix argument.
LGTM.
> +- "Default build command to use for `haskell-cabal-build' when no
> cabal or stack file is detected.
> ++ "Default build command to use for `haskell-cabal-build' when no
> ++cabal or stack file is detected.
LGTM.
> +- "Controls whether to use cabal, stack, or ghc to compile.
> +- Auto (the default) means infer from the presence of a cabal or
> stack spec file,
> +- following same rules as haskell-process-type."
> ++ "Controls whether to use cabal, stack, or ghc to compile. Auto
> (the
> ++ default) means infer from the presence of a cabal or stack spec
> ++ file, following same rules as haskell-process-type."
LGTM.
> +- (let (htype dir)
> ++ (let (htype dir)
Indentation change? Suppress those, you want to make the diff as small
as possible.
> +- "The way to run cabal comands. It takes two arguments -- the
> directory and the command.
> ++ "The way to run cabal comands. It takes two arguments -- the
> ++directory and the command.
LGTM.
> +- "Suggest adding OverloadedStrings pragma to file when getting
> type mismatches with [Char]."
> ++ "Suggest adding OverloadedStrings pragma to file when getting
> type
> ++mismatches with [Char]."
LGTM.
> +- "Looks for cabal and stack spec files.
> +- When found, returns a pair (TAG . DIR)
> +- where TAG is 'cabal-project, 'cabal-sandbox. 'cabal, or 'stack;
> ++ "Looks for cabal and stack spec files.
> ++ When found, returns a pair (TAG . DIR)
> ++ where TAG is 'cabal-project, 'cabal-sandbox. 'cabal, or 'stack;
LGTM.
> +- "Puts point to the next following symbol, or to end if there are
> no more symbols in the sexp."
> ++ "Puts point to the next following symbol, or to end if there are
> no
> ++more symbols in the sexp."
LGTM.
> +- "Generate a regex for searching for any occurrence of the prompt\
> ++ "Generate a regex for searching for any occurrence of the prompt
LGTM, but you might want to shorten the docstring so that the first
line is a synopsis. This would make it easier for upstream to accept.
> +-- 'template-haskell-quote: for a string of apostrophes for template
> haskell
> +-- 'template-haskell-quasi-quote: for a string of apostrophes for
> template haskell
> ++- 'template-haskell-quote: for a string of apostrophes for template
> ++ haskell
> ++- 'template-haskell-quasi-quote: for a string of apostrophes for
> ++ template haskell
LGTM.
> +- "If point is in an SCC annotation, kill the annotation.
> Otherwise, try to insert a new annotation."
> ++ "If point is in an SCC annotation, kill the annotation.
> ++Otherwise, try to insert a new annotation."
LGTM.
> +- "Template string that will be inserted in new haskell buffers via
> `haskell-auto-insert-module-template'.")
> ++ "Template string that will be inserted in new haskell buffers via
> ++`haskell-auto-insert-module-template'.")
LGTM.
> +- "Shift the nested off-side-rule block adjacent to point by COLS
> columns to the right.
> ++ "Shift the nested off-side-rule block adjacent to point by COLS
> ++columns to the right.
LGTM.
> +- "Try to send a string to the process's process. Ask to restart if
> it's not running."
> ++ "Try to send a string to the process's process. Ask to restart if
> ++it's not running."
LGTM.
> +- "Run a loading-ish COMMAND that wants to pick up type errors\
> ++ "Run a loading-ish COMMAND that wants to pick up type errors
As above, what is "loading-ish", are "things like that" relevant, etc.
> +- "Regular expression for matching multiline prompt (the one inside
> :{ ... :} blocks).")
> ++ "Regular expression for matching multiline prompt (the one inside
> ++:{ ... :} blocks).")
LGTM.
> +- ((haskell-mode . ((haskell-w3m-haddock-dirs .
> (\"/home/chris/Projects/foobar/.hsenv/cabal/share/doc\")))))
> ++ ((haskell-mode .
> ++ ((haskell-w3m-haddock-dirs .
> ++ (\"/home/chris/Projects/foobar/.hsenv/cabal/share/doc\")))))
Who is chris? But fair enough, the indentation should be right.
Cheers
next prev parent reply other threads:[~2022-05-19 19:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 8:30 bug#55495: emacs-haskell-mode build fails Taiju HIGASHI
2022-05-18 13:16 ` Liliana Marie Prikler
2022-05-18 14:39 ` Taiju HIGASHI
2022-05-18 14:31 ` bug#55495: [PATCH] gnu: emacs-haskell-mode: Fix build Taiju HIGASHI
2022-05-19 19:09 ` Liliana Marie Prikler [this message]
2022-05-20 2:29 ` Taiju HIGASHI
2022-05-20 8:49 ` Taiju HIGASHI
2022-05-19 15:14 ` bug#55495: Re: emacs-haskell-mode build fails Luis Henrique Gomes Higino
2022-05-20 9:49 ` Taiju HIGASHI
2022-05-20 9:54 ` bug#55495: [PATCH] gnu: emacs-haskell-mode: Fix build Taiju HIGASHI
2022-05-20 20:59 ` Taiju HIGASHI
2022-05-20 21:57 ` Liliana Marie Prikler
2022-05-20 22:52 ` Taiju HIGASHI
2022-05-20 9:59 ` bug#55495: [PATCH v2] " Taiju HIGASHI
2022-05-21 5:23 ` bug#55495: [PATCH v3] " Taiju HIGASHI
2022-05-31 19:29 ` bug#55495: (no subject) Luis Henrique Gomes Higino
2022-06-01 3:52 ` Taiju HIGASHI
2022-06-01 14:56 ` Luis Henrique Gomes Higino
2022-06-01 15:36 ` Taiju HIGASHI
2022-06-02 3:57 ` bug#55495: [PATCH v3] gnu: emacs-haskell-mode: Fix build Taiju HIGASHI
2022-06-02 4:01 ` Taiju HIGASHI
2022-06-17 21:41 ` bug#55495: About v3 Luis Henrique Gomes Higino
2022-06-18 14:09 ` Taiju HIGASHI
2022-06-22 0:33 ` bug#55495: resolved by bug#56120 Taiju HIGASHI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd9e0aa3d659f561a245203a1a17e5125ddcd7c6.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=55495@debbugs.gnu.org \
--cc=higashi@taiju.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).