From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id pkSxBmnR7WDbNgEAgWs5BA (envelope-from ) for ; Tue, 13 Jul 2021 19:46:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cBS2AWnR7WDhSgAA1q6Kng (envelope-from ) for ; Tue, 13 Jul 2021 17:46:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 390D1776F for ; Tue, 13 Jul 2021 19:46:16 +0200 (CEST) Received: from localhost ([::1]:40292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3MU2-0000Ai-Nl for larch@yhetil.org; Tue, 13 Jul 2021 13:46:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3MTq-00006u-Mm for bug-guix@gnu.org; Tue, 13 Jul 2021 13:46:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58520) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m3MTq-0001Ft-59 for bug-guix@gnu.org; Tue, 13 Jul 2021 13:46:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m3MTq-0003Vm-1M for bug-guix@gnu.org; Tue, 13 Jul 2021 13:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#49510: [PATCH] gnu: Add PuTTY. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 13 Jul 2021 17:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49510 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: terramorpha@cock.li, 49510@debbugs.gnu.org Received: via spool by 49510-submit@debbugs.gnu.org id=B49510.162619830313419 (code B ref 49510); Tue, 13 Jul 2021 17:46:01 +0000 Received: (at 49510) by debbugs.gnu.org; 13 Jul 2021 17:45:03 +0000 Received: from localhost ([127.0.0.1]:41833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3MSt-0003UM-4f for submit@debbugs.gnu.org; Tue, 13 Jul 2021 13:45:03 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:30666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m3MSp-0003Ta-FM for 49510@debbugs.gnu.org; Tue, 13 Jul 2021 13:45:01 -0400 Received: from nijino.local (80-121-26-175.adsl.highway.telekom.at [80.121.26.175]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4GPSh664c5z1LBCr; Tue, 13 Jul 2021 19:44:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4GPSh664c5z1LBCr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1626198295; bh=kyKNcDWj07Muf2YV0YvZVXCi7TnpDCxba/TyMLonFAo=; h=Subject:From:To:Date:In-Reply-To:References:From; b=l5WtbG2Lu+Q8GzSakvNrO4jRhc16fjVdCc0C3/psQ2AlH2brOE6ctfrcJPHeuhTEh Ukgnk1n6yMh+kxyghNRd6PDE0MjdQJDiB//i2aulGR2AvLXexfG7FuSbu7EEEZYNS3 1TRCqoZbwrxCU7Lo94PdwrB9M1E0B6oHqiKL8VJg= Message-ID: From: Leo Prikler Date: Tue, 13 Jul 2021 19:44:54 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626198376; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=kyKNcDWj07Muf2YV0YvZVXCi7TnpDCxba/TyMLonFAo=; b=P50VHMax0TuUQIlHJop5THHbl0cO6SlTo8SIgdcETD+rdqEwL+sEzWfPSaeiZJIDgPRMdc EjpvRIxIcPWI4jLu3OGv2dZdltwfrVEvu8uBL54CpTx2TbXUgAlbNuKoFNfMRw2dMTIMRK x0HH2+jkvICPmy87yGg1ejvUhfkpIBHTxx80Waj5XFUJUZ5EiuvIhb0zDh5yv37I008wrB 0rCl9voNKLPt2WUsXqafDjxO4R3qc5SErbdkint6X0V5SgIEwwvPoheRTY/Sg7uvy8DBHw 3k5VO6cCnfEnek7ox2r+fSj+4Oobb/sY7zLd1qSlZB2PAU2ol4QQNlYYxBxuhw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626198376; a=rsa-sha256; cv=none; b=Xlj91XpUT5jHiLXlVvWxlcyKIT3dJG7Vvo9KyH/wRHNtomJvlSNNp3kiUDsIgLViZf9hlp Ks3bTXiITzl/x+fcbMb8k/QWbCFFPdDwriGz35mhue4XmN3iWhOWgoDgdpb2Dkf3cKS/1Y IGnt94ZILdr7V0xc/wuClqxQHJOlaSMNtmL89/61nK2moLb+31bHtTSft4hAiKChxf3VxK 31XkUxr3wyzf2Pxr1g1VBVnI8/fifhADp70g97g6zSamGWbUh3xZKapd4WfVJDawLrJgmJ rqQqAbzaaDlEbvsxyjHZkJuve9BDiQjBESuaBvad28tYg588e0gu6i7hU5jr1g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=l5WtbG2L; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -1.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=l5WtbG2L; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 390D1776F X-Spam-Score: -1.30 X-Migadu-Scanner: scn0.migadu.com X-TUID: QI5D/KIqFMQ1 Am Dienstag, den 13.07.2021, 13:25 -0400 schrieb terramorpha@cock.li: > Hi, thank you for the review. > > I corrected the version of the package (putty doesn't use > major.minor.patch, only major.minor), I fixed the lines that were > over the 80 character limit, re added the check phase, corrected the > formatting and put in the expat license. However, I do not know what > you mean by the "ChangeLog part of the commit message", I thought > that standalone patch didn't have a commit message attached. > Could you elaborate? > > Here is the modified patch. Please don't send raw diffs and more importantly don't copypaste them into your mail client (unless you know exactly, that your mail client behaves in a correct manner, which most don't). Mail clients have a tendency to mess up whitespace and line lengths, which can and does break diffs. Instead, use `git format-patch` and attach the generated patch file or (the following way is preferred) use `git send-email`. When using format-patch/send-email, the full commit message and name/email of the committer will be transmitted as well, not just a raw diff. Your second patch LGTM, perhaps with a few fixable formatting stuffs, but I'll have to ask you to resend it, since I can't `git am` it. Thanks, Leo > diff --git a/gnu/packages/networking.scm > b/gnu/packages/networking.scm > index 19b58501e9..ce00a016e6 100644 > --- a/gnu/packages/networking.scm > +++ b/gnu/packages/networking.scm > @@ -4100,3 +4100,38 @@ on hub/switched networks. It is based on > @acronym{ARP} packets, it will send > @acronym{ARP} requests and sniff for replies.") > (home-page "https://github.com/netdiscover-scanner/netdiscover") > (license license:gpl3+))) > + > +(define-public putty > + (package > + (name "putty") > + (version "0.75") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "http://www.putty.be/" version > + "/putty-" version ".tar.gz")) > + (sha256 > + (base32 > "1xgrr1fbirw79zafspg2b6crzfmlfw910y79md4r7gnxgq1kn5yk")))) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-before 'configure 'go-into-unix/ > + (lambda _ (begin > + (chdir "unix") > + #t)))))) > + (build-system gnu-build-system) > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + (inputs > + `(("gtk+" ,gtk+) > + ("perl" ,perl) > + ("python" ,python) > + ("python2" ,python-2.7))) > + (synopsis "Graphical @acronym{SSH} and telnet client") > + (description > + "Putty is a powerful terminal client. It supports > @acronym{SSH}, > telnet, > +and raw socket connections with good terminal emulation. It > supports > public key > +authentication and Kerberos single-sign-on. It also includes > command-line > +@acronym{SFTP} and @acronym{SCP} implementations.") > + (home-page "https://www.chiark.greenend.org.uk/~sgtatham/putty/" > ) > + (license license:expat)))