bug#24981: [Website] All pages fail the HTML validation test

bug#24981: [Website] All pages fail the HTML validation test

[Luis Felipe López Acevedo]

Steps to reproduce
==================

1. Go to https://validator.w3.org/
2. For each page in the website: validate by URI


Unexpected behavior
===================

All pages are marked as [Invalid]


Expected behavior
=================

All pages are marked as valid HTML 5 (Document checking completed. No 
errors or warnings to show.)


Additional information
======================

Most of the errors happen because of a missing Doctype declaration. It 
seems all pages built with Haunt have this problem, while the 
packages[1] and packages issues[2] pages, generated with a different 
mechanism, do include the document type.

There are other errors not related to the document type declaration in 
the packages-related pages.[1][2] Mostly, obsolete elements or 
attributes, and missing closing tags.


[1]: https://www.gnu.org/software/guix/packages
[2]: https://www.gnu.org/software/guix/packages/issues.html



-- 
Luis Felipe López Acevedo
http://sirgazil.bitbucket.org/

bug#24981: [Website] All pages fail the HTML validation test

[Ludovic Courtès]

Hello!

Luis Felipe López Acevedo <felipe.lopez@openmailbox.org> skribis:

> Steps to reproduce
> ==================
>
> 1. Go to https://validator.w3.org/
> 2. For each page in the website: validate by URI
>
>
> Unexpected behavior
> ===================
>
> All pages are marked as [Invalid]

Oops.

> Most of the errors happen because of a missing Doctype declaration. It
> seems all pages built with Haunt have this problem, while the
> packages[1] and packages issues[2] pages, generated with a different
> mechanism, do include the document type.

I see you already fixed this one the same way I’d have done it.  :-)

> There are other errors not related to the document type declaration in
> the packages-related pages.[1][2] Mostly, obsolete elements or
> attributes, and missing closing tags.

This is underway too, right?

Ludo’, who likes self-fixing bugs.  :-)

bug#24981: [Website] All pages fail the HTML validation test

[Luis Felipe López Acevedo]

On 2016-11-23 16:45, ludo@gnu.org wrote:
> Hello!
> 
> Luis Felipe López Acevedo <felipe.lopez@openmailbox.org> skribis:
> 
>> There are other errors not related to the document type declaration in
>> the packages-related pages.[1][2] Mostly, obsolete elements or
>> attributes, and missing closing tags.
> 
> This is underway too, right?

Yes. The ones on the Packages issues page will get fix with the fix for 
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22115>, and then I'll 
check what's wrong with the Packages page.

> Ludo’, who likes self-fixing bugs.  :-)

:)

-- 
Luis Felipe López Acevedo
http://sirgazil.bitbucket.org/

bug#24981: [Website] All pages fail the HTML validation test

[Ludovic Courtès]

Luis Felipe López Acevedo <felipe.lopez@openmailbox.org> skribis:

> On 2016-11-23 16:45, ludo@gnu.org wrote:
>> Hello!
>>
>> Luis Felipe López Acevedo <felipe.lopez@openmailbox.org> skribis:
>>
>>> There are other errors not related to the document type declaration in
>>> the packages-related pages.[1][2] Mostly, obsolete elements or
>>> attributes, and missing closing tags.
>>
>> This is underway too, right?
>
> Yes. The ones on the Packages issues page will get fix with the fix
> for <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22115>, and then
> I'll check what's wrong with the Packages page.

Awesome.  I can update the other pages with CVS when you deem
appropriate, if you don’t feel like fiddling with CVS yourself.

Thanks!

Ludo’.

bug#24981: [Website] All pages fail the HTML validation test

[sirgazil]

With the new website online, all pages pass the HTML validation, except 
for the Packages page, which has a </p> tag for no opened P element in 
every package description, and uses obsolete TT element in links to patches.

https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.gnu.org%2Fsoftware%2Fguix%2Fpackages%2F


-- 
https://sirgazil.bitbucket.io/

bug#24981: [Website] All pages fail the HTML validation test

[Ludovic Courtès]

Hello,

sirgazil <sirgazil@zoho.com> skribis:

> With the new website online, all pages pass the HTML validation,
> except for the Packages page, which has a </p> tag for no opened P
> element in every package description,

Oh, how’s that possible?  A bug in Guile’s ‘sxml->xml’?

> and uses obsolete TT element in links to patches.

I didn’t know <tt> is obsolete.  Would <code> be OK here?

We’d need to adjust Guile’s stexi modules accordingly.

Thanks,
Ludo’.

bug#24981: [Website] All pages fail the HTML validation test

[sirgazil]

On 07/12/17 07:21, Ludovic Courtès wrote:
> Hello,
> 
> sirgazil <sirgazil@zoho.com> skribis:
> 
>> With the new website online, all pages pass the HTML validation,
>> except for the Packages page, which has a </p> tag for no opened P
>> element in every package description,
> 
> Oh, how’s that possible?  A bug in Guile’s ‘sxml->xml’?

I haven't take a look at the code yet. But I plan to do so after I 
upgrade Guix to 0.14.


>> and uses obsolete TT element in links to patches.
> 
> I didn’t know <tt> is obsolete.  Would <code> be OK here?
> 

Depending on the meaning of the texinfo command that is converted to TT 
one could use CODE, a SPAN with a class or any of the other elements 
recommended here: 
https://www.w3.org/TR/html5/obsolete.html#non-conforming-features.

> We’d need to adjust Guile’s stexi modules accordingly.
> 
> Thanks,
> Ludo’.
> 

bug#24981: [Website] All pages fail the HTML validation test

[sirgazil]

On 07/12/17 07:21, Ludovic Courtès wrote:
> Hello,
> 
> sirgazil <sirgazil@zoho.com> skribis:
> 
>> With the new website online, all pages pass the HTML validation,
>> except for the Packages page, which has a </p> tag for no opened P
>> element in every package description,
> 
> Oh, how’s that possible?  A bug in Guile’s ‘sxml->xml’?

I just fixed this one. It was a mistake in the packages template (using 
a DIV element inside a P element).

https://git.savannah.gnu.org/cgit/guix/guix-artwork.git/commit/?id=61b79b7fdd5a2a5bbaae7f53891e489ffa28fc95


>> and uses obsolete TT element in links to patches.
> 
> I didn’t know <tt> is obsolete.  Would <code> be OK here?
> 
> We’d need to adjust Guile’s stexi modules accordingly.
> 
> Thanks,
> Ludo’.
> 

bug#24981: [Website] All pages fail the HTML validation test

[Ludovic Courtès]

sirgazil <sirgazil@zoho.com> skribis:

> On 07/12/17 07:21, Ludovic Courtès wrote:
>> Hello,
>>
>> sirgazil <sirgazil@zoho.com> skribis:
>>
>>> With the new website online, all pages pass the HTML validation,
>>> except for the Packages page, which has a </p> tag for no opened P
>>> element in every package description,
>>
>> Oh, how’s that possible?  A bug in Guile’s ‘sxml->xml’?
>
> I just fixed this one. It was a mistake in the packages template
> (using a DIV element inside a P element).
>
> https://git.savannah.gnu.org/cgit/guix/guix-artwork.git/commit/?id=61b79b7fdd5a2a5bbaae7f53891e489ffa28fc95

Good catch, thanks!

Ludo’.

bug#24981: [Website] All pages fail the HTML validation test

[sirgazil]

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

Hi,

This issue is solved in the website repository now. The following 
commits fix remaining validation errors related to the use of the 
obsolete TT element:

  * 13a1a5a41df9eae7d3ca54c6ab4774c7804dba45
    <https://git.savannah.gnu.org/cgit/guix/guix-artwork.git/commit/?id=38ba9baa9162e4060160c03d0827787c9f52e26c>
  * 38ba9baa9162e4060160c03d0827787c9f52e26c
    <https://git.savannah.gnu.org/cgit/guix/guix-artwork.git/commit/?id=38ba9baa9162e4060160c03d0827787c9f52e26c>

And the following commit fixes a validation error related to using a P 
element as a container of DIV elements:

b951df49798db870aab5ebd4c63d70d2d0c6c8cf 
<https://git.savannah.gnu.org/cgit/guix/guix-artwork.git/commit/?id=b951df49798db870aab5ebd4c63d70d2d0c6c8cf>

I think once these changes are deployed to gnu.org and guix.info this 
issue can be closed.

P. S.: I would deploy it myself, but I don't remember how to do it in 
the case of gnu.org, and I don't have information about guix.info.

:)



[-- Attachment #2: Type: text/html, Size: 1357 bytes --]

bug#24981: [Website] All pages fail the HTML validation test

[sirgazil]

Fixed. Changes published.


-- 
Luis Felipe López Acevedo
http://sirgazil.bitbucket.io/

bug#24981: [Website] All pages fail the HTML validation test

[Ludovic Courtès]

Hello sirgazil,

sirgazil <sirgazil@zoho.com> skribis:

> This issue is solved in the website repository now. The following
> commits fix remaining validation errors related to the use of the
> obsolete TT element:
>
>  * 13a1a5a41df9eae7d3ca54c6ab4774c7804dba45
>    <https://git.savannah.gnu.org/cgit/guix/guix-artwork.git/commit/?id=38ba9baa9162e4060160c03d0827787c9f52e26c>
>  * 38ba9baa9162e4060160c03d0827787c9f52e26c
>    <https://git.savannah.gnu.org/cgit/guix/guix-artwork.git/commit/?id=38ba9baa9162e4060160c03d0827787c9f52e26c>
>
> And the following commit fixes a validation error related to using a P
> element as a container of DIV elements:
>
> b951df49798db870aab5ebd4c63d70d2d0c6c8cf
> <https://git.savannah.gnu.org/cgit/guix/guix-artwork.git/commit/?id=b951df49798db870aab5ebd4c63d70d2d0c6c8cf>
>
> I think once these changes are deployed to gnu.org and guix.info this
> issue can be closed.

Thanks for fixing these!

Ludo’.