From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ALlTL2G50GEEWgEAgWs5BA (envelope-from ) for ; Sat, 01 Jan 2022 21:28:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kO7wK2G50GGWAAAAauVa8A (envelope-from ) for ; Sat, 01 Jan 2022 21:28:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 64E7737DBF for ; Sat, 1 Jan 2022 21:28:17 +0100 (CET) Received: from localhost ([::1]:51562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n3kzA-00036r-JK for larch@yhetil.org; Sat, 01 Jan 2022 15:28:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n3kyw-00032p-QU for bug-guix@gnu.org; Sat, 01 Jan 2022 15:28:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47875) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n3kyw-0008Uc-DU for bug-guix@gnu.org; Sat, 01 Jan 2022 15:28:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n3kyw-0002pH-BO for bug-guix@gnu.org; Sat, 01 Jan 2022 15:28:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52913: 0ad only builds fine with a specific version of mozjs Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 01 Jan 2022 20:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52913 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jesse Gibbons , 52913@debbugs.gnu.org Received: via spool by 52913-submit@debbugs.gnu.org id=B52913.164106884310809 (code B ref 52913); Sat, 01 Jan 2022 20:28:02 +0000 Received: (at 52913) by debbugs.gnu.org; 1 Jan 2022 20:27:23 +0000 Received: from localhost ([127.0.0.1]:59421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3kyI-0002oF-Tg for submit@debbugs.gnu.org; Sat, 01 Jan 2022 15:27:23 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:33297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n3kyC-0002nx-Sa for 52913@debbugs.gnu.org; Sat, 01 Jan 2022 15:27:21 -0500 Received: by mail-wr1-f66.google.com with SMTP id d9so62050286wrb.0 for <52913@debbugs.gnu.org>; Sat, 01 Jan 2022 12:27:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=XWPG8/Po4L4z4a7zVvIASFVDO97OwurNB0LJmtI59P4=; b=artUKbu9PLul1uqSafFwwK+wr7H/+ws8SLQ4NfHdwFKR9wIzUkWbwG0Ytb/ZTvwriK 4Ll7jO+wRLHddL/WJBAe149LyKjmqbmIFDX+U1IOaP/irxQ9dTuAfNAjbopVlhI/mqFh twWn5mdsY3g9VIRsBuNPPmIWOhKpWuhaKuzBrQ2uvCWSrblrjDpTQmWx2bszk2gE9IvS 5rPu9ShKyK+iA/c+kKNtdzaF0k/DmEo33ZkkZCqtZd04yk29dnk7MTVhnDq6+uin6VZv u+4wwo55YacNbZweReHm2gsSRIHcnxVw8OSOpBvKiLGz4do9EgbEbqcDWoWUMjnk8Dn9 vEpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=XWPG8/Po4L4z4a7zVvIASFVDO97OwurNB0LJmtI59P4=; b=41UjRssKuKXp7GsMEZkwyynZrVsFt1bQGCTvtCD1xsww8v7aza7k7+UACeCRGzMuiD SVSrqj1bxJu3F/Wy6V80jGf+8zavfbVEG6nnNPXOabxtdawd2qES9L/eR2t8uhipXCrO NNAx6QZQVssCetdmKd6Z/mMwDNFLP7xMDySDEAO23GKGkrBhL7QG/ZrfHOGTnJsWhyrs nj9V3ts2c1f3Yv4XRPCGGNMG7omSsLPRIfiWXoOw7faqdQ/skqrljR/+/523fkBzcT3p 0OT36PGItsd7iLigyTpxTWpR5Qxb3OcWo0A3E8+t7CrVtyxsGZIYFktJuvAG4XYXvL/P qbEw== X-Gm-Message-State: AOAM531yjDALHRuulLDjLHJXVmbcXwi68tsBSLQlCDv0+NKuooV0+QRw /DPrD91KVwdW4nvp8PaF+AM= X-Google-Smtp-Source: ABdhPJwmB5I3k96HAtwDMg4IDk1hECDwPNlgwvMQspbufEf+lzMittd+NKXB7TetqpMvO2snjDqJEQ== X-Received: by 2002:a05:6000:120c:: with SMTP id e12mr33453935wrx.6.1641068830944; Sat, 01 Jan 2022 12:27:10 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id k31sm30176168wms.21.2022.01.01.12.27.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jan 2022 12:27:10 -0800 (PST) Message-ID: From: Liliana Marie Prikler Date: Sat, 01 Jan 2022 21:27:09 +0100 In-Reply-To: <5491e57c-ae88-aa24-256b-c7d6f038cba2@gmail.com> References: <5491e57c-ae88-aa24-256b-c7d6f038cba2@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641068897; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=XWPG8/Po4L4z4a7zVvIASFVDO97OwurNB0LJmtI59P4=; b=e2LuLaPpIxPjPiZk9KAbHuHw9S5eW6pN5im7OXij4++WqADNs4RqpPSQWW2o02KYuh98dg SlV4MlJBhVenhiRCoDQloT8i1byqHJig1q4RRoxqoLQSqQBeVWlJcB5K5H0pPL7JIJzKg+ ERMnc05oCsNxEUwPWzKcAH8/0YMMPODRW51+sP7n5s7eeT1/TRW+Hlfa+VPzEULmr//fGC PqKfFvNIU0Tx/FR+nT2nx/BuI03ehR4xQHgXOKPY0LlTKlRaF7mvV96SX30ELvtWG93JNT +FglbAcz1vdWKbDiwNJssHfMy9PkmeeK/fyMUZNeQXvaHdbaWk+vPTE5aAo7iw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641068897; a=rsa-sha256; cv=none; b=UPJ9Id97Nyv7ULiV8PtcjZjpH16FFMw3y+tmNuo5LNI6SzvrxpZ3lsCgiomKTwSoTPX2wr JQSgH8XUblmFE1c6mvLQ1m/cgzI6JiIkSBfKeN2hmKmJjLUCFvCc+zOGnGZMWiEPAbp7BE YX6EGvGBlI0AUK1UmQVbn7wy8Bxw0kAHsHTtqN5xomTDLYSHXNwhBK0n6XEnWGqvIZSzV9 a8ES/5RpOmjHmL2O/aBs30xh1h5jZt8kQ3Zvj1JLkZaPo846+0xXk1jkCzqX2D7PsAFepe i7FZdaGWcYnImTh5cJYoDZFeYfnrI6L5mLXI2BAgnoqiUN33X6OsBcxxWIJegA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=artUKbu9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.98 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=artUKbu9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 64E7737DBF X-Spam-Score: -1.98 X-Migadu-Scanner: scn1.migadu.com X-TUID: 14cptsedDbve Am Samstag, dem 01.01.2022 um 12:14 -0700 schrieb Jesse Gibbons: >  > What would be the best way to fix this? >  >  - keep a mozjs-78.6 package around just for 0ad >  >  - patch 0ad to fix the compatibility issues with mozjs 78.15 >  >  - use the mozjs version bundled in the 0ad sources >  > >  > WDYT? > > Keeping mozjs-78.6 just for 0ad will probably make things harder later > on because it's another package to maintain and users likely won't be > able install 0ad and icecat/icedove in the same profile. I suppose > users can always use `-P /path/to/0ad-profile` when installing or > updating 0ad. I don't think that would be a problem, since mozjs is a regular input. There ought to be no propagation conflicts between the two. > I'm thinking using the bundled mozjs is perhaps the best option, though > it isn't particularly guixy, because I expect most users would want the > 0ad packaged by guix to be compatible with other 0ad builds in the > wild. There is no benefit to using a bundled version over one packaged with Guix. > Another option would be to keep mozjs-78.6 for 0ad and patch it so > interested users can test updated mozjs using > `--with-input=mozjs=mozjs`. It isn't very difficult to modify a list of > packages to use a specific mozjs in a manifest or home configuration, > right? Though I guess interested contributors could always add the > patch themselves just as easily... Contributors would probably work on top of their local checkouts anyway, so there's no concern here (other than increased store space for another mozjs both locally for users and in CI). @Guillaume: From what I can gather from the build error, it appears as though the calling convention changed to require an additional parameter. I've tracked down the relevant commit [1] and bug [2]. Now obviously doing such a thing violates SemVer, so if rewriting 0ad with this and other changes in mind is not an option, I think having a hidden package for 0ad might be the lesser evil. Cheers [1] https://searchfox.org/mozilla-central/commit/a3c605929b16303e8a52ae9d99d5fe6769e8bf09 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1681268