unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Vivien Kraus <vivien@planete-kraus.eu>, 50677@debbugs.gnu.org
Subject: bug#50677: [PATCH] Minetest basic_materials really depends on moreores
Date: Sun, 19 Sep 2021 19:40:50 +0200	[thread overview]
Message-ID: <b1ca1440fa78bb64acc4f8a6bbd622bc9c396e82.camel@telenet.be> (raw)
In-Reply-To: <47d31be5bfc24646981f2f71942fedd89c556405.camel@planete-kraus.eu>

[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]

Vivien Kraus via Bug reports for GNU Guix schreef op zo 19-09-2021 om 17:23 [+0200]:
> Dear guix,
> 
> basic_materials actually requires moreores, otherwise some craft
> recipes are just not possible. For instance,
> basic_materials:silver_wire can only be crafted with
> moreores:silver_ingot. This silver wire is actually needed for basic
> technic machines, such as the LV compressor.
> 
> So, let’s add minetest-moreores!

In creative mode, crafting isn't necessary, you can give yourself all
the items and blocks you want.  OTOH, letting the crafting recipes
work (at least when all the mods are enabled for the world,
they seem to be disabled by default) seems rather important for ‘survival’
players, so adding a propagated-input doesn't seem unreasonable here.

> + (version "v2.1.0")

Versions in guix don't use any leading "v" prefix.  If I'm not mistaken,
Ludovic applied the patched to remove them automatically.

> +          (lambda* (#:key inputs #:allow-other-keys)

inputs is unused, so you can write '(lambda _' here instead (somewhat simpler)

> /share/minetest/mods/moreores/_config.txt

Is this "_config.txt" file moreores-specific?  If not, maybe minetest-mod-build-system
could be modified to install these files by default?

Greetings,
Maxime

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2021-09-19 17:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-19 15:23 bug#50677: [PATCH] Minetest basic_materials really depends on moreores Vivien Kraus via Bug reports for GNU Guix
2021-09-19 17:40 ` Maxime Devos [this message]
2021-09-19 18:54   ` Vivien Kraus via Bug reports for GNU Guix
2021-09-19 18:59     ` Vivien Kraus via Bug reports for GNU Guix
2021-09-19 19:18       ` Maxime Devos
2021-09-19 19:11     ` Maxime Devos
2021-09-19 21:05       ` Vivien Kraus via Bug reports for GNU Guix
2021-09-22 16:46         ` Vivien Kraus via Bug reports for GNU Guix
2021-09-22 17:41           ` Maxime Devos
2021-09-22 18:04             ` Vivien Kraus via Bug reports for GNU Guix
2021-09-22 18:15               ` Maxime Devos
2021-09-22 18:37                 ` Vivien Kraus via Bug reports for GNU Guix
2021-09-22 18:43                   ` Maxime Devos
2021-10-14 15:14                     ` Vivien Kraus via Bug reports for GNU Guix
2021-10-15 20:18                       ` Maxime Devos
2021-10-16 15:32               ` Tobias Geerinckx-Rice via Bug reports for GNU Guix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1ca1440fa78bb64acc4f8a6bbd622bc9c396e82.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=50677@debbugs.gnu.org \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).