From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UF7kA4wLwmFm4gAAgWs5BA (envelope-from ) for ; Tue, 21 Dec 2021 18:14:52 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SKAiO4sLwmG4YQAAbx9fmQ (envelope-from ) for ; Tue, 21 Dec 2021 17:14:51 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C3AF61EF6 for ; Tue, 21 Dec 2021 18:14:51 +0100 (CET) Received: from localhost ([::1]:50320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mziiw-00058t-Ht for larch@yhetil.org; Tue, 21 Dec 2021 12:14:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mziKw-0003h8-Fr for bug-guix@gnu.org; Tue, 21 Dec 2021 11:50:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43859) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mziKw-00081T-5J for bug-guix@gnu.org; Tue, 21 Dec 2021 11:50:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mziKw-00028p-4H for bug-guix@gnu.org; Tue, 21 Dec 2021 11:50:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52375: webkitgtk needs gst-plugins-bad Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 21 Dec 2021 16:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52375 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 52375@debbugs.gnu.org Received: via spool by 52375-submit@debbugs.gnu.org id=B52375.16401053678176 (code B ref 52375); Tue, 21 Dec 2021 16:50:02 +0000 Received: (at 52375) by debbugs.gnu.org; 21 Dec 2021 16:49:27 +0000 Received: from localhost ([127.0.0.1]:55405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mziKM-00027o-QK for submit@debbugs.gnu.org; Tue, 21 Dec 2021 11:49:27 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:36938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mziKK-00027W-Lz for 52375@debbugs.gnu.org; Tue, 21 Dec 2021 11:49:25 -0500 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mziKF-0000uK-70 for 52375@debbugs.gnu.org; Tue, 21 Dec 2021 11:49:19 -0500 Date: Tue, 21 Dec 2021 11:49:19 -0500 (EST) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: Message-ID: References: <62474069db54770d90977754e32f01cc9b3b3e9a.camel@planete-kraus.eu> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640106891; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=1UoWouVwkrIlZxhFNpcVnFSqPnidVU+pKJ98SRbg80Y=; b=n6tUQwqHXBFIFDyZN9hDW0GZQu9zgpj6GxllhUoHxoqbEmHa0lD9v14Lm1YLQtP/1XrS5M ca0N7/1vrOTbyYcIucajLAiSQN5H+tQOLLj0IFfKpz4HK0yQzuDsNB5JrSgdmtM6rWo8di flPRP0QMDe4M+8TyJ2733j1DJTYfX6K3hYseDaTAMLim/tBa2D8kHe5oQcQ0qUOF4QYT31 cWuW2CMpTHv3AuBbhZtaDSbEfArvA6B0OnaWJAolLP51PvCsdMvgMW5tBf7WjNCC9uZ/cf TyhPsP6hON2DsdElBgTVDXV49yNAAFgCQbIShSzcZmO9RfzBTH97hl77PlBASA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640106891; a=rsa-sha256; cv=none; b=W/u1d7cH3/k3v+Ve1MGtOIqnDeBXys6RpaJjjDGJ3kqXv6XxLB4vbqIpPStSLf2LJCpO4I HmSYOfVLANjiyhr0P8bSXiFmyFNWTD9NYWQ2i/Y+WvvJxNz8c91ufzD9pCETilCMtEap62 6PQ8dDTznSwagB78dR/62zxZKHHjoztSkgKwnLI0T/RZq3K0IGQscEv1ShhFA9m5VmvjFa wq+bp2MPflf96Nyqv0EN+vuRg5J3fLAcyiusDu5W/HTtsd0Df3x3NM2n1s8uAVdlP2zee2 1Iwe+BOoS4N7bpz/1cMkgghE9h8Vln9Yny4y9GQO86RzvLD5Oz/AR+4UGIslWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.33 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C3AF61EF6 X-Spam-Score: -4.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: ydCcDq4NL7MH On Tue, 21 Dec 2021, Jack Hill wrote: > I asked about this issue on #webkitgtk:gnome.org on IRC. It turns out that > what's missing from my environment is gst-plugins-bad (most likely the > fakevideosink plugin contained therein). If I install gst-plugins-bad into an > environment with a webgkitgtk browser, the crash I was seeing is resolved. > Only adding gst-plugins-bad to the inputs of webkitgtk doesn't seem to be > enough to solve the problem. I suppose some additional wrapping is needed > somewhere (although gst-plugins-base shows up in the webkitgtk references). > > What's the best path forward here? I got permission to quote from the IRC conversation for some additional context: 10:52 < jackhill> Hi folks! In the Guix WebKitGTK packages we seem to have introduced a problem that causes tabs to crash on some pages. I'm trying to track it down, but could use a hand in either identifying the solution or in more troubleshooting techniques: https://issues.guix.gnu.org/52375 10:55 < MichaelCatanzaro[m]> jackhill: Looks like you're missing a GStreamer element that is required (do you have: gst-plugins-base, gst-plugins-good, and at least the free half of gst-plugins-bad?) 10:56 < MichaelCatanzaro[m]> Alternatively, maybe try deleting ~/.cache/gstreamer-1.0 in the off chance your registry is corrupt 10:58 < MichaelCatanzaro[m]> jackhill: I think you're missing the fakevideosink element from gst-plugins-bad 11:01 < jackhill> MichaelCatanzaro[m]: thanks. Looking at our package definition we only depend directlyon gst-plugins-base. It seems that we were scared off of -bad at some point in the past: https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/webkit.scm#n255 11:03 < jackhill> I'll look into adding them (and manybe clearing my cache). Were we wrong in our assesment of -bad? 11:06 < MichaelCatanzaro[m]> jackhill: Yup, that is mandatory... and disabling GStreamerGL is not recommended either 11:06 < jackhill> MichaelCatanzaro[m]: yep, adding -bad did it! Is there an official WebKitGTK statement that I can point to when proposing my fix to Guix? 11:06 < MichaelCatanzaro[m]> Not all the elements are mandatory, but some are... 11:07 < MichaelCatanzaro[m]> jackhill: No, we just expect you to have a working gstreamer installation 11:07 < jackhill> hehe, fair enough 11:08 < MichaelCatanzaro[m]> Looks like there is a bug report: https://bugs.webkit.org/show_bug.cgi?id=233949 [daychange] 10:55 < jackhill> MichaelCatanzaro[m]: we're having a conversation in #guix:libera.chat about adding the gst-plugins-bad. Can I quote our conversation yesterday to hopefully bring others up to speed? 11:26 < MichaelCatanzaro[m]> "Michael Catanzaro: we're..." <- Of course, all the history here is public anyway 11:27 < MichaelCatanzaro[m]> You need: gst-plugins-base, gst-plugins-good, and gst-plugins-bad (not gst-plugins-ugly) 11:27 < MichaelCatanzaro[m]> gst-libav especially welcome if available, but not required... 11:29 < MichaelCatanzaro[m]> GStreamer is indeed used inside the bwrap sandbox (most applications do not enable the sandbox, but Ephy does) 11:29 < MichaelCatanzaro[m]> All web content is handled sandboxed :) > Should leaf applications that use webkitgtk be wrapped to find the right > gst-plugins? This seems suboptimal to me. If the plugins are really > dependencies of webkitgtk then perhaps they should be encoded that way in > Guix. > > Should webkitgtk be wrapped somehow to find the plugins on its own? How would > this wrapping be done? Do we want to force all webkitgtk applications to > carry around these dependencies? We talked through some of these option on #guix:libera.chat (thanks apteryx and cybersyn!) and it sounds like we're leaning towards the first option. An additional concern with webkitgtk always pulling in the plugins is that it increases the webkitgtk closure size by over 1G! We're still waiting on webkitgtk builds to finish to help us determine if we can enable GSTREAMER_GL. Best, Jack