From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4FQzLmLToWEBxQAAgWs5BA (envelope-from ) for ; Sat, 27 Nov 2021 07:42:42 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cN7IKWLToWFzWwAAbx9fmQ (envelope-from ) for ; Sat, 27 Nov 2021 06:42:42 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3C66EFCBB for ; Sat, 27 Nov 2021 07:42:42 +0100 (CET) Received: from localhost ([::1]:47744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqrQ1-0002Kq-D8 for larch@yhetil.org; Sat, 27 Nov 2021 01:42:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqrPO-0002Hp-Im for bug-guix@gnu.org; Sat, 27 Nov 2021 01:42:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49471) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqrPO-0005Fh-Ax for bug-guix@gnu.org; Sat, 27 Nov 2021 01:42:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mqrPO-0003BD-9U for bug-guix@gnu.org; Sat, 27 Nov 2021 01:42:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52137: committer.scm wrong type passed to car Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 27 Nov 2021 06:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52137 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 52137@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163799528712177 (code B ref -1); Sat, 27 Nov 2021 06:42:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Nov 2021 06:41:27 +0000 Received: from localhost ([127.0.0.1]:32784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqrOo-0003AL-SD for submit@debbugs.gnu.org; Sat, 27 Nov 2021 01:41:27 -0500 Received: from lists.gnu.org ([209.51.188.17]:49388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqrOn-0003AE-IJ for submit@debbugs.gnu.org; Sat, 27 Nov 2021 01:41:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqrOm-0002H5-Bn for bug-guix@gnu.org; Sat, 27 Nov 2021 01:41:24 -0500 Received: from minsky.hcoop.net ([104.248.1.95]:40422) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqrOk-00057o-7A for bug-guix@gnu.org; Sat, 27 Nov 2021 01:41:23 -0500 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqrOj-0001LW-24; Sat, 27 Nov 2021 01:41:21 -0500 Date: Sat, 27 Nov 2021 01:41:20 -0500 (EST) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="925712948-877446296-1637995281=:13935" Received-SPF: pass client-ip=104.248.1.95; envelope-from=jackhill@jackhill.us; helo=minsky.hcoop.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ricardo Wurmus Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637995362; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:list-id:list-help:list-unsubscribe:list-subscribe: list-post; bh=0DOs9dpMvL2rhxPszO0wtWNRRwEabHwtSiBbYn0Cgb8=; b=aIfwpDlj4+NpJkwDMGdLJNTkmx4eEqM4JTukVMUJFkJkD5hfMBdZkNINp39f9ct0Mb4SIf 2rw2Rr2+3I03aw8g8mnN5ygs7ZBDxNron+dGFNQFHf0E6aDv3BLnBYHTL+YOitrF079NDN DQ/qaSntFESn6RveTH9Tji7kDksjkW66tgqSXBE+qDLAT0wc/d+OMUaX5ndeAgU7BtwpZK PHY4hEqQfN9RseL4j6EmukGrqNsLq133I7DvVla/wf8lmLTuF38vSydoBlEnrLsFA5ZFT9 tJW2HCc2td7hSt+W8PQIeH1A0YiL9DG/EBt1gCRE8HCFXyHInJQdnDFdW+UMWQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637995362; a=rsa-sha256; cv=none; b=jQjaZ2tKJaq8EOJ5+vlclk6Rh1RL4Stgc/En8F+mIeognJklOgb4p2QCRcQxepOfWwzka6 DBK7Dq5GKKbPPLvnWSA0WB9treyH9N8fSQLBdPM21SSgm1Ba9D+/A2uttr9TI2zngM+9Yg /AK998P/4SN8LG5K5vONTL8EI4B5weEqCfIyau4+5NBa8Y70K269mGpdM/2Jy7GIMSmVkX LU1ymeVLK2knTWo5OrDpyCD9sks8XN/W8A8oC/dthvPDivCTgcCwYPGBszHGyEMvtDWr+I h3HtdYuy7pv0u6YnYumD3WU+bIeNcN1Q9Kf53R17n4zw2sRoUyWGBLoEopnQbQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.10 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3C66EFCBB X-Spam-Score: -2.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: /Craw0s38kx2 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-877446296-1637995281=:13935 Content-Type: text/plain; format=flowed; charset=UTF-8 Content-Transfer-Encoding: 8BIT Hi Guix and Ricardo, Running the etc/commiter.scm script with the diff of a patch that I recently submitted [0] results in the backtrace below. This might be because I was holding the script wrong, but it would be nice to provide a more friendly message for people like me who don't remember how to use it properly. [0] https://issues.guix.gnu.org/52134#1 jackhill@leyden ~/repos/guix [env]$ git status On branch committer-test Changes not staged for commit: (use "git add ..." to update what will be committed) (use "git restore ..." to discard changes in working directory) modified: gnu/packages/web-browsers.scm no changes added to commit (use "git add" and/or "git commit -a") jackhill@leyden ~/repos/guix [env]$ git diff diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm index 7ea2a9a9ec..50a41309d3 100644 --- a/gnu/packages/web-browsers.scm +++ b/gnu/packages/web-browsers.scm @@ -51,6 +51,7 @@ (define-module (gnu packages web-browsers) #:use-module (gnu packages) #:use-module (gnu packages autotools) #:use-module (gnu packages backup) + #:use-module (gnu packages base) #:use-module (gnu packages bison) #:use-module (gnu packages compression) #:use-module (gnu packages curl) @@ -125,10 +126,12 @@ (define-public midori (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))))) (native-inputs - `(("glib:bin" ,glib "bin") + `(("desktop-file-utils" ,desktop-file-utils) ;for tests + ("glib:bin" ,glib "bin") ("gtk+:bin" ,gtk+ "bin") ("intltool" ,intltool) - ("pkg-config" ,pkg-config))) + ("pkg-config" ,pkg-config) + ("which" ,which))) ;for tests (inputs `(("adwaita-icon-theme" ,adwaita-icon-theme) ("gcr" ,gcr) @@ -139,10 +142,9 @@ (define-public midori ("json-glib" ,json-glib) ("libarchive" ,libarchive) ("libpeas" ,libpeas) - ("libsoup" ,libsoup) ("sqlite" ,sqlite) ("vala" ,vala) - ("webkitgtk" ,webkitgtk))) + ("webkitgtk" ,webkitgtk-with-libsoup2))) (synopsis "Lightweight graphical web browser") (description "@code{Midori} is a lightweight, Webkit-based web browser. It features integration with GTK+3, configurable web search engine, bookmark jackhill@leyden ~/repos/guix [env]$ ./etc/committer.scm Backtrace: 5 (primitive-load "/home/jackhill/repos/guix/./etc/commit…") In srfi/srfi-1.scm: 634:9 4 (for-each # …) In ice-9/eval.scm: 619:8 3 (_ #(#(#(#(#(#(#(#(#(#(#(…) …) …) …) …) …) …) …) …) …) …)) 619:8 2 (_ #(#(#(#) # …) …)) 626:19 1 (_ #(#(#(#) # …) …)) In unknown file: 0 (car ()) ERROR: In procedure car: In procedure car: Wrong type (expecting pair): () Aborting commit due to empty commit message. --925712948-877446296-1637995281=:13935--