From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id tkUhGPAnK1/0PQAA0tVLHw (envelope-from ) for ; Wed, 05 Aug 2020 21:43:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 6O1hE/AnK185HwAAbx9fmQ (envelope-from ) for ; Wed, 05 Aug 2020 21:43:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BD6829400BF for ; Wed, 5 Aug 2020 21:43:11 +0000 (UTC) Received: from localhost ([::1]:51994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3RBk-0004Ic-TL for larch@yhetil.org; Wed, 05 Aug 2020 17:43:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33588) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3RBe-0004IP-6O for bug-guix@gnu.org; Wed, 05 Aug 2020 17:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40799) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k3RBd-00047S-UC for bug-guix@gnu.org; Wed, 05 Aug 2020 17:43:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k3RBd-0002tR-Sr for bug-guix@gnu.org; Wed, 05 Aug 2020 17:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#42543: lint failure for packages on load path specified with -L Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 05 Aug 2020 21:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42543 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 42543-submit@debbugs.gnu.org id=B42543.159666374811063 (code B ref 42543); Wed, 05 Aug 2020 21:43:01 +0000 Received: (at 42543) by debbugs.gnu.org; 5 Aug 2020 21:42:28 +0000 Received: from localhost ([127.0.0.1]:52343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3RB6-0002sN-Ae for submit@debbugs.gnu.org; Wed, 05 Aug 2020 17:42:28 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:35018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k3RB5-0002rp-5a for 42543@debbugs.gnu.org; Wed, 05 Aug 2020 17:42:27 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1k3RAz-0005pQ-Mz; Wed, 05 Aug 2020 17:42:21 -0400 Date: Wed, 5 Aug 2020 17:42:21 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <87d044on1k.fsf@gnu.org> Message-ID: References: <87d044on1k.fsf@gnu.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="925712948-590414679-1596662573=:4809" Content-ID: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 42543@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: gKht13WH/m2l This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --925712948-590414679-1596662573=:4809 Content-Type: text/plain; CHARSET=UTF-8; FORMAT=flowed Content-Transfer-Encoding: 8BIT Content-ID: Hi Ludo’! Hope you've enjoyed your (short) time away from the keyboard :) On Wed, 5 Aug 2020, Ludovic Courtès wrote: > Hi, > > Jack Hill skribis: > >> jackhill@alperton ~$ guix lint -L lint-test my-hello >> Backtrace:y-hello@2.10 [formatting]... >> 8 (primitive-load "/home/jackhill/.config/guix/current/bi…") >> In guix/ui.scm: >> 1974:12 7 (run-guix-command _ . _) >> In ice-9/boot-9.scm: >> 1736:10 6 (with-exception-handler _ _ #:unwind? _ # _) >> In guix/store.scm: >> 631:22 5 (thunk) >> In srfi/srfi-1.scm: >> 634:9 4 (for-each # …) >> In guix/scripts/lint.scm: >> 60:4 3 (run-checkers _ _ #:store _) >> In srfi/srfi-1.scm: >> 634:9 2 (for-each # …) >> 241:2 1 (for-each _ _) >> In ice-9/boot-9.scm: >> 1669:16 0 (raise-exception _ #:continuable? _) >> >> ice-9/boot-9.scm:1669:16: In procedure raise-exception: >> In procedure for-each: Wrong type argument: #f > > I can’t reproduce this problem: […] > $ guix lint -L /tmp/t my-hello > $ echo $? > 0 > $ guix show -L /tmp/t my-hello > name: my-hello > version: 2.10 > outputs: out > systems: x86_64-linux i686-linux > dependencies: > location: /tmp/t/my-hello.scm:8:2 > homepage: https://www.gnu.org/software/hello/ > license: GPL 3+ > synopsis: Saluton, mondo GNU: ekzemplo de pako GNU > description: GNU Hello montras la mesaĝon "Hello, world!" kaj finiĝas. Ĝi funkcias kiel ekzemplo de norma > + kodumada tradicio de GNU. Tiel, ĝi subtenas komand-liniajn argumentojn, plurajn lingvojn, kaj tiel plu. You've passed an absolute path to -L. Indeed, I don't don't see the problem when I do that, only when using a relative path. Can you try running `guix lint -L t my-hello` while your current working directory is /tmp? > Do you still have this problem? Yes, confirmed just now with 05f3d34094b23dc9612ff6641a0257bc4f7dcd12 > (Besides, ‘canonicalize-path’ should be used sparsely: it’s quite > expensive and sometimes confusing for users. With the proposed patches, > “-L /does/not/exist” would now lead to an error.) Perhaps this can be solved a different way. Could we propagate the knowledge of the current working directory, and construct absolute path when needed? However, now that you, hopefully, better understand the problem, do we want to support relative paths passed to -L? It seems that they happen to work some places now, but not others (guix edit is another place where it doesn't work). I would be equally happy if we decided to not support relative paths, and warn the user when was was provided to -L. I also think it might make sense for -L /does/not/exist to print a (friendly) error rather than silently not loading modules, but I'm open to arguments to the contrary. Best, Jack --925712948-590414679-1596662573=:4809--