From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jack Hill <jackhill@jackhill.us>
Subject: bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering
 by default.
Date: Tue, 10 Mar 2020 13:14:00 -0400 (EDT)
Message-ID: <alpine.DEB.2.20.2003101313370.19733@marsh.hcoop.net>
References: <20200309104242.GH1423@E5400>
 <20200309235402.24941-1-mike@rohleder.de> <20200310085601.GR1423@E5400>
 <alpine.DEB.2.20.2003101042560.19733@marsh.hcoop.net>
 <87ftegqjst.fsf_-_@rohleder.de>
Mime-Version: 1.0
Content-Type: text/plain; format=flowed; charset=US-ASCII
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:47042)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jBiT9-0003fI-Nu
 for bug-guix@gnu.org; Tue, 10 Mar 2020 13:15:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jBiT8-0000a4-Mv
 for bug-guix@gnu.org; Tue, 10 Mar 2020 13:15:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:47239)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jBiT8-0000Yn-IZ
 for bug-guix@gnu.org; Tue, 10 Mar 2020 13:15:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jBiT8-0005FF-Dp
 for bug-guix@gnu.org; Tue, 10 Mar 2020 13:15:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.25201.D25201.158386045220087@debbugs.gnu.org>
In-Reply-To: <87ftegqjst.fsf_-_@rohleder.de>
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
 <mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org>
To: mike@rohleder.de
Cc: 25201-done@debbugs.gnu.org

On Tue, 10 Mar 2020, mike@rohleder.de wrote:

> Hi Jack,
>
> Jack Hill <jackhill@jackhill.us> writes:
>> I'm trying to follow along, and learn some things about making Guix
>> packages. One question I have after seeing this change is how did you
>> decide whether to make this change in the source definition (with a
>> patch or a snippet) or in a phase during the build?
>
> Well, I saw the substitute* of a #include header
> (fix-libspeechd-include) in the phase, but the removing of dirs in the
> source definition and I thought, ok, it might make more sense this way.
> (because, eg, the phase names (fix-libspeechd-include,
> fix-statistic-gathering-default etc) could be printed in the log etc)
>
> This decition was more a "it feels better" than knowledge, because I'm
> new to guix and scheme and love to learn (by doing) ;)

Makes sense, thanks for sharing.

Jack