From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jack Hill Subject: bug#25201: Re bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default. Date: Tue, 10 Mar 2020 10:50:57 -0400 (EDT) Message-ID: References: <20200309104242.GH1423@E5400> <20200309235402.24941-1-mike@rohleder.de> <20200310085601.GR1423@E5400> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:58117) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBgEl-00043X-Fa for bug-guix@gnu.org; Tue, 10 Mar 2020 10:52:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBgEk-0003uT-IU for bug-guix@gnu.org; Tue, 10 Mar 2020 10:52:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47095) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jBgEk-0003u8-FE for bug-guix@gnu.org; Tue, 10 Mar 2020 10:52:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jBgEk-0001mC-E4 for bug-guix@gnu.org; Tue, 10 Mar 2020 10:52:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <20200310085601.GR1423@E5400> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane-mx.org@gnu.org Sender: "bug-Guix" To: Efraim Flashner Cc: 25201-done@debbugs.gnu.org Hi, Thanks for improving Guix! Having an old bug closed is great. I'm trying to follow along, and learn some things about making Guix packages. One question I have after seeing this change is how did you decide whether to make this change in the source definition (with a patch or a snippet) or in a phase during the build? Perhaps for this change the differences don't matter to much, so I won't learn much, but I thought I'd ask anyway :) Best, Jack