From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Suhail Singh <suhailsingh247@gmail.com>
Cc: 72045@debbugs.gnu.org
Subject: bug#72045: [PATCH v2 1/2] gnu: Add system test for Emacs.
Date: Fri, 19 Jul 2024 17:42:52 +0200 [thread overview]
Message-ID: <ac21ebe685d062890391df91a3c44fdcb4788e09.camel@gmail.com> (raw)
In-Reply-To: <877cdhv20i.fsf@gmail.com>
Am Freitag, dem 19.07.2024 um 11:23 -0400 schrieb Suhail Singh:
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>
> > + (test-equal "native-comp-dir"
> > + (emacs-native-comp-dir
> > + #$(file-append old-emacs "/bin/emacs"))
> > + (emacs-native-comp-dir
> > + #$(file-append new-emacs "/bin/emacs")))
>
> I like that there is a test that focuses on the native-comp-dir
> directly. Having only a test that focuses on ABI_VERSION wouldn't
> have been sufficient IMO.
>
> Minor nitpick: However, there may still be some utility in either
> having an additional test for ABI_VERSION or adding a comment that a
> successful evaluation of the above test also implies that the
> ABI_VERSION matches.
We can test `comp-abi-hash` as well, should be no biggie.
> > + (test-assert "old emacs has hierarchical layout"
> > + (file-exists?
> > + (string-append #$new-emacs "/lib/emacs/"
> > + (emacs-effective-version old-emacs-
> > bin)
> > + "/native-lisp/"
> > + (emacs-native-comp-dir old-emacs-bin)
> > + "/preloaded/emacs-lisp/comp.eln")))
>
> Should that say #$old-emacs instead of #$new-emacs ?
Yes, it should.
> > + (test-assert "new emacs has hierarchical layout"
> > + (file-exists?
> > + (string-append #$new-emacs "/lib/emacs/"
> > + (emacs-effective-version new-emacs-
> > bin)
> > + "/native-lisp/"
> > + (emacs-native-comp-dir new-emacs-bin)
> > + "/preloaded/emacs-lisp/comp.eln")))
>
> Do we need to additionally ensure that the new emacs' "hierarchical
> layout" matches the old emacs' "hierarchical layout" in some way
> (over and above both having them)?
We could do so, but that'd be an expensive test. In practice, we
assume the same layout and just poke a single file.
> > +(define %test-emacs-native-comp-replacable
> > + (system-test
> > + (name "emacs-native-comp")
> > + (description "Test whether an emacs replacement (if any) is
> > valid.")
> > + (value (run-native-comp-replacable-test
> > + (package-without-replacement emacs)
> > + emacs))))
>
> Ah! So that's how it's done. I am not qualified to review this
> part, but this looks to be in the right spirit. Hoping this is
> merged soon.™
You can verify this part by running "make check-system TESTS=emacs-
native-comp" and seeing that it fails for this commit but succeeds on
the next. That's TDD :D
Cheers
prev parent reply other threads:[~2024-07-19 15:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 20:06 bug#72045: Emacs graft lookup still fails Liliana Marie Prikler
2024-07-13 5:49 ` bug#72045: [PATCH RFC 1/2] gnu: emacs: Compute ABI hash and native version dir without version Liliana Marie Prikler
2024-07-13 5:53 ` bug#72045: [PATCH 2/2] gnu: emacs-minimal: Ungraft Liliana Marie Prikler
2024-07-13 16:14 ` Suhail Singh
2024-07-13 16:59 ` Liliana Marie Prikler
2024-07-13 16:08 ` bug#72045: [PATCH RFC 1/2] gnu: emacs: Compute ABI hash and native version dir without version Suhail Singh
2024-07-13 17:26 ` Liliana Marie Prikler
2024-07-13 17:59 ` Suhail Singh
2024-07-13 23:22 ` bug#72045: Emacs graft lookup still fails Suhail Singh
2024-07-14 8:50 ` Liliana Marie Prikler
2024-07-14 16:27 ` Suhail Singh
2024-07-14 16:46 ` Liliana Marie Prikler
2024-07-14 16:56 ` Suhail Singh
2024-07-14 16:59 ` Suhail Singh
2024-07-19 7:35 ` bug#72045: [PATCH v2 1/2] gnu: Add system test for Emacs Liliana Marie Prikler
2024-07-19 15:23 ` Suhail Singh
2024-07-19 15:42 ` Liliana Marie Prikler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac21ebe685d062890391df91a3c44fdcb4788e09.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=72045@debbugs.gnu.org \
--cc=suhailsingh247@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).