From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QImZKX9MN2JvIQAAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 16:47:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id iOsKIn9MN2Ix3gAAG6o9tA (envelope-from ) for ; Sun, 20 Mar 2022 16:47:11 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 39AC02D58D for ; Sun, 20 Mar 2022 16:47:11 +0100 (CET) Received: from localhost ([::1]:39780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVxlu-0001h2-AG for larch@yhetil.org; Sun, 20 Mar 2022 11:47:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVxlm-0001gt-Qb for bug-guix@gnu.org; Sun, 20 Mar 2022 11:47:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41131) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVxlm-0006jU-IN for bug-guix@gnu.org; Sun, 20 Mar 2022 11:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVxlm-0005Cb-HK for bug-guix@gnu.org; Sun, 20 Mar 2022 11:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#50329: [PATCH] Bundle icons for emacs-lsp-treemacs Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 20 Mar 2022 15:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50329 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Roman Scherer Received: via spool by 50329-submit@debbugs.gnu.org id=B50329.164779120619197 (code B ref 50329); Sun, 20 Mar 2022 15:47:02 +0000 Received: (at 50329) by debbugs.gnu.org; 20 Mar 2022 15:46:46 +0000 Received: from localhost ([127.0.0.1]:35028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVxlV-0004zK-Ps for submit@debbugs.gnu.org; Sun, 20 Mar 2022 11:46:45 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:40730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVxlU-0004u1-Gx for 50329@debbugs.gnu.org; Sun, 20 Mar 2022 11:46:44 -0400 Received: by mail-ed1-f68.google.com with SMTP id w4so15358882edc.7 for <50329@debbugs.gnu.org>; Sun, 20 Mar 2022 08:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=ImC26O9ppR+giLwqwqCWmgPI+WVxu1WAwoxgaNdrieU=; b=eSevwDB+CDX9nsdoS6rGuDW0qQL01FlwTbxfxeOQtjewQfIkfivQoiSoSN4wJKWJa5 T62JzN6XKAdw9iJ6/UocpF3hmW9RT99pCMKKdlvhhkuROPhKN+WGIy3HzSdM6X6CEdLI 0F/20kueQP3hSax2Iq57Ppq965HxBxkV7yHSvJpDMDlaqZ+kn/ZIFBtbvc6umVNicOi0 BYu52XaW70wjbm9aoJBXZAj2qq4r3dcW07T8xU/BYZ9i4P3vVTXQvY7ibryyeRPV1nbo rvFrCqMOtLb2LUv5jgls9nbrzYVDhUlcQhx38yyS3YXhZ2bEyFtUmryrdzMYidRWTHVB TSNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=ImC26O9ppR+giLwqwqCWmgPI+WVxu1WAwoxgaNdrieU=; b=7BR1rxDPK0CnswKLVN0g5cezGrhv1tzL+70AGexK3zZWOOR0h9fxrk6Rdzgf/kVHjm bM1E/OQU/+AjQyfvU2uownDG+qP16BZxvp46K6z8S/VKkaPDx05rRzvlgkUsNGUVJonk 4Xaa9q8vyO8fcVlr0Vknf9L6dsmldtOoDi08/k8cOxSiPhCtnxD7oPeD5urtKhqFTvQy +W1skq6pngyn8xUm32E96RCZbY/mRicawU/k9ogJTvq/9LuvGtZsHOjKSUviU9LsJZJk kj03SWRlrFotrQo9O5Wlpdjfr3Yj8uwlfKFOEmDdX0+eANtiSDzIlKQ0lc2b9/DSQiit SfLw== X-Gm-Message-State: AOAM531j9muJobUh3cKtK0J776YQN36TfY8JTiudv0wK9U4zboQDCX+j b+XOrUXl1W8+bu9EsnrcdIA= X-Google-Smtp-Source: ABdhPJzCX6heqRXuYXUEQUinKR2RYit/CRHQoxilEBXXsnvQTEWISu4VEwxk1WQFOaxS+yFa6VUJ4w== X-Received: by 2002:a05:6402:358b:b0:416:c8de:ffef with SMTP id y11-20020a056402358b00b00416c8deffefmr18917824edc.45.1647791198594; Sun, 20 Mar 2022 08:46:38 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id ec21-20020a170906b6d500b006d170a3444csm5873340ejb.164.2022.03.20.08.46.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Mar 2022 08:46:37 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Sun, 20 Mar 2022 16:46:36 +0100 In-Reply-To: <874k3sbtbl.fsf@burningswell.com> References: <87fsnevtxi.fsf@burningswell.com> <8c532497fcfb965b7c60e93b3bbd8082b3acddf4.camel@telenet.be> <87wngp6l7n.fsf@burningswell.com> <7333ababd7753976b6165d1ce8d538586089015c.camel@telenet.be> <87sfrc7vqw.fsf@burningswell.com> <87o8207tmx.fsf@burningswell.com> <874k3sbtbl.fsf@burningswell.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Goaziou , 50329@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647791231; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ImC26O9ppR+giLwqwqCWmgPI+WVxu1WAwoxgaNdrieU=; b=l+bUUa3/InIJZlTpTn0pUtnEx0CY/kyq2QUrQeWdUz/D6B6Vb99a3RdZbFUs8eLZBzfCxM qyVu7cnYovDiDFsTWqdOwiU9B+dievBn7vR0W6QiNp8Tl6MtlrodpqOjfbhhMTkPh1p7Mg 1MLj7vptvn5Of0ktv9nBDV3BjCxUTlUPpstI9GY5UIQ9mjRoaqFUZ58bb9UznukBGtdXa1 4QIgHNRDt/02WcHTexG0WrCkAM26GlXcAiz9f3wsVPjXkeY0gQCYy5vrm8uO1gKXEPQ/ft h4mNlyzFlTMuW+/+cEiKmJ1lEEFt+HCBKxA3/VwvJDjzmcSiItKT0nbDPROeoQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647791231; a=rsa-sha256; cv=none; b=p2bNdMVUzz+np3X1EeXnwGZfuxV64mkbYx7yORanAcLSlQmOhOWUs7O/JY9qk28XPN+AdJ qnposqptxysraep3SGJGLzQYMAaFkJkC4Nt9Qjw/HCXrJPbNeeGbYde94HJHVeUOv+swsX efia6arqSqdxGdvWDJk9Q8Pl4R3r0jBBJY6jfCN+bwAlHx0lH1TV5K9rteJV+V9CHqByXc U6qltZNjDP/SWAh7jNtx57WEkpa+p7KF3YhDkNF4AePLcLR1Z6UqIDnAUAahVL/bDqdil8 99qtlIUdAn3ABdxuzfTwDiAxPZEAf86lwN4vLQniyC5uVsnKD4r6a24QSEx31A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=eSevwDB+; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.97 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=eSevwDB+; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 39AC02D58D X-Spam-Score: 5.97 X-Migadu-Scanner: scn1.migadu.com X-TUID: GrQ1JU71fi4x Hi Roman, Am Sonntag, dem 20.03.2022 um 14:58 +0100 schrieb Roman Scherer: > Hi Liliana and Maxime, > > if the icons are really coming from [1], they seem to be licensed > under the Creative Commons Attribution 4.0 International Public > License. > > If it is okay to include them, I could work on a patch that only > installs the VS Code icons. I think we need to give credit and link > to the Creative Commons license. Is it enough to add it to the > license field and mention/link the VS Code icons in the description > field? Adding the license to the field with an appropriate comment would be enough imho. If upstream decides to make a new release, we can also use that -- or alternatively bump to the commit. > Before doing that, I would wait until someone clarified that the > icons are really coming from [1] in the upstream issue. > > In the meantime I think it's best to include my patch that removes > all icons from the source. > > What do you think? I'm in the "let's wait and do the correct thing" camp. Having one commit to restrict the sources to the correct set would be more justifiable than overreacting, particularly given the FSDG stance on non-functional data. That said, long-term this data needs to go :) Cheers