From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id IH/dAGltBWf2FAAA62LTzQ:P1 (envelope-from ) for ; Tue, 08 Oct 2024 17:35:37 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id IH/dAGltBWf2FAAA62LTzQ (envelope-from ) for ; Tue, 08 Oct 2024 19:35:37 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=YtfRTqj2; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=l1WHPrth; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728408936; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=DqeBQlfZ14+DLPHoCkHyZ00/rvMMYgYeZAJgMLtaloI=; b=a2Gh1cuYOfNcde1R1fYbn9H5CpJ7oQt3CMqC3tILrV1rKyxGmLO49MwoEq+BqkbGZszk/K 5kssHH7rOxQ9s47wcfO1+9l6gUPN3IPlWDbzFA4pNxXScA2QDjVGh0BscFaOtNDR/hV32F krQIduSLCa3NGkU2VDqMR70oUxrvhnBE+TujFh17Fq/ACA+Puri+qwMh+QtzbaN1IQqtg7 zqjPNKpl1Tb6IUShlL031ElScm4DarPcLKzuI6gOPRH/V/boLAxEVG0GAoiMyYZi/MwE8i JKhENWD63zFkABuA+YMb/pNs9Kdk9s53UU3VIrg5rj78kSwLPB/qBG8jsFXBEg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728408936; a=rsa-sha256; cv=none; b=KPlBpGSoZ7KJSlO0SYKaK0fJRPWIo8oUwNEDrPmGIy1khDpjkPVyPZCYzyKzmQQByIRSIZ SnM5Boh1GXrMQDpH/WzAMQFAiYpLSvuBFUZltVhd3DFloQ3oDwJS+esOTsJZtOm/kw7Luy /hzeg2VRH/XZCXH14nBkWaSPpdJSxHC4kWdbIPDuPiIKly1z34xYxenUkVLCcwNyPdZMSw QKinJjBb9Gn5qMUp0DBruUq+cGtr9pSBOUS2LJVSJm2Kpfnj1BkxZz3/3k3MR8UVnNqnn1 yzTxvo2c/4vJoJsDdsncahQyBaq8+UcuHujB88TMFlsMGQWCbXJiO3gln5X92w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=YtfRTqj2; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=l1WHPrth; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 91BDA5A87C for ; Tue, 08 Oct 2024 19:35:36 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1syE6p-0008Vc-Pq; Tue, 08 Oct 2024 13:34:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1syE6o-0008VE-BM for bug-guix@gnu.org; Tue, 08 Oct 2024 13:34:54 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1syE6o-0001jY-1T for bug-guix@gnu.org; Tue, 08 Oct 2024 13:34:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=DqeBQlfZ14+DLPHoCkHyZ00/rvMMYgYeZAJgMLtaloI=; b=YtfRTqj2N79yGv9G2YAsX8RlaqPle+kqi6iDa3U5nEfVkTMgWaRqZnkfYnWstCnlqvdZl1NUZXbRXFjq207as/ETEayaXPh44d0Wl858beqHvoGiWTIv+QdE9AAHQ/al3JKf7NGNwRn/XzvnOwYyT8AyeurEHkr9s06VM8CGuVEtQf0hcVHqFbCU6+nAMYQK3dZ4dmKCH/EXhs68MklyPi5FTovGdn1qAq19feP2N7LNVT08w0lGrPxCEuXgFMeGwLl/3b/xc2zF3Q7CncVJuC7hkBYV2vohxen9LC00jf9UB/TXhd7T6tGpFX8qv3cTFEjmyyiLQxaHWJbMk1+MVg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1syE6w-0003jZ-EL for bug-guix@gnu.org; Tue, 08 Oct 2024 13:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#73681: Maybe partly undo the patch on Elisp comp-el-to-eln-filename Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 08 Oct 2024 17:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73681 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Martin =?UTF-8?Q?Edstr=C3=B6m?= Cc: 73681 <73681@debbugs.gnu.org> Received: via spool by 73681-submit@debbugs.gnu.org id=B73681.172840886014284 (code B ref 73681); Tue, 08 Oct 2024 17:35:02 +0000 Received: (at 73681) by debbugs.gnu.org; 8 Oct 2024 17:34:20 +0000 Received: from localhost ([127.0.0.1]:54253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syE6F-0003iK-RN for submit@debbugs.gnu.org; Tue, 08 Oct 2024 13:34:20 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:52435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1syE6E-0003i8-Kf for 73681@debbugs.gnu.org; Tue, 08 Oct 2024 13:34:19 -0400 Received: by mail-wm1-f67.google.com with SMTP id 5b1f17b1804b1-42cb57f8b41so79609605e9.0 for <73681@debbugs.gnu.org>; Tue, 08 Oct 2024 10:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728408789; x=1729013589; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=DqeBQlfZ14+DLPHoCkHyZ00/rvMMYgYeZAJgMLtaloI=; b=l1WHPrthot+regC5ONiJ3R0WwrhgdGiFJMK+j1Ac24cPbWfHVq8NwrSeWoBme3oMG9 zMXSLZqk4JPhVEp4/6OkgxqDSegV1Tv4W2QXKJ/oU0RyGygRzMDVF+GKfhUNOVIUHEAI FAmLWhWpXUCMHgYz2YNxp2olPhWRSXLCq0oou39mJDqw/SzgegZ3JteOEYURSjHGLlUu aZp+Cz3H+sx/1Fn37gRXHCfUoFfhmVKBUvJnpXSE4yVTAs4/GpSiviYmsaY5mFv/yppc W9Z3SrhWLKvbKLiTUKq2CwQPvaMlDbXe7YIXTZZC+TUOD2BkLsuRD3PkjKGKz7CZOhOr B5zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728408789; x=1729013589; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DqeBQlfZ14+DLPHoCkHyZ00/rvMMYgYeZAJgMLtaloI=; b=cnxYdnNvW/Rv69f6SS2sM2tnQbzkMB+iYbqVOtCSSolv4/mCDm0ZGT9A2Zk4kW4sGW ECUZYCOZomKsKYxk6ErL5oM2Jyi+ZliQ9xQFkfgkYoU5wKQdJmQwYyrMGAlX0Ft24JR1 T0lrTH3AtaxGMjcySdksNsptKLHydi60PCL4i0+wqFJnnDc7AIUL9aLP2EVhfOLog05B ogM89GlzigewNUGBxl3xT4sBzjIsFQ6KMN87yKkm6s0SYoLSrOVtUPQHU4TaeaSXPKJC tbTB41QsFM/7D16Lg/vi/9uHQdUJCmgMKmppZY066HcAzKtIa8CMuZVQE2px/CXstLRu wllA== X-Gm-Message-State: AOJu0YzXo1m7ByE2CEIyPVpLp2HYFHOddbKF5e6RXkEGEFu1GWA9nNc9 oPpb1SJ2/6OmQXPGxU9sCVC6ZuHBmOHwFnrgfOOzlPEOSmaTGzim X-Google-Smtp-Source: AGHT+IE59XkoBsfiS2HOJ+Me64ZB28v0AKjEKsltFZfM6wPCPOrh/+yK5xEuJeQpZlHnon7ATYXmTA== X-Received: by 2002:a5d:6e0a:0:b0:374:ce15:9995 with SMTP id ffacd0b85a97d-37d0e78253cmr12212588f8f.34.1728408788203; Tue, 08 Oct 2024 10:33:08 -0700 (PDT) Received: from lumine.fritz.box (85-127-114-32.dsl.dynamic.surfer.at. [85.127.114.32]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d1690fc53sm8599158f8f.4.2024.10.08.10.33.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2024 10:33:07 -0700 (PDT) Message-ID: From: Liliana Marie Prikler Date: Tue, 08 Oct 2024 19:33:06 +0200 In-Reply-To: References: <58598114857dce8a25e3b4d0477d212467a0173f.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.27 X-Spam-Score: -0.27 X-Migadu-Queue-Id: 91BDA5A87C X-Migadu-Scanner: mx13.migadu.com X-TUID: z5gsDNOA/yKY Am Dienstag, dem 08.10.2024 um 12:41 +0200 schrieb Martin Edstr=C3=B6m: > It comes as part of the package. I don't want to assume that it has > been compiled, since it's fairly performance-sensitive. That's why > I'll either use a previously existing compiled object or make a new > one. Could you leave that decision to the user? > [=E2=80=A6] >=20 > So let's ignore my package, it is just an example of a downstream use > of `comp-el-to-eln-filename` that relied on its hashing > functionality. >=20 > Let's just discuss that function. >=20 > I have to point out that the emacs `load-path` does not include any > native paths.=C2=A0 When I inspect the value on my non-Guix emacs, I see > no references to .../eln-cache/..., just references to directories > where there are .elc and .el files. There is a separate load path for natively compiled files, called `native-comp-eln-load-path'. > I infer that Emacs starts with finding a library in load-path, then > converts the path with `comp-el-to-eln-filename`, and checks if that > file exists, then loads it. >=20 > And crucially, it is not just about the filepath, the function hashes > the file contents as well. That ensures that the output path is > always different if the source file changes. I think relying on such implementation details is perhaps permitted if it's inside of Emacs itself, but even then it clashes with our expectation that Emacs be graftable. > Since Guix has a patch that removes this effect, it seems like a > package could be upgraded many, many times, without the .eln path > ever changing, and so the user would stay on that very outdated file. >=20 > Is that not a regression/bug? The way our load paths are set up, it is actually the opposite (which still is a bug, just not the one reported). While `guix upgrade` or a command to the similar effect will swap out the .eln under the hood, the `.el` and `.elc` files stay stable =E2=80=93 remember what I wrote in t= he previous message about that having caused issues with byte compilation? We also get a similar-looking bug if our packages aren't actually native-compiled, but Emacs itself vendors them. That is resolved by dropping those .eln-files from the Emacs package. Cheers