unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Jonathan Brielmaier <jonathan.brielmaier@web.de>
To: 44760@debbugs.gnu.org
Subject: bug#44760: Closure copy in ‘guix system init’ is inefficient
Date: Wed, 16 Dec 2020 22:53:22 +0100	[thread overview]
Message-ID: <a5e9cb2c-16b8-f880-3c71-34b0f03b7696@web.de> (raw)
In-Reply-To: <87h7pkffzy.fsf@inria.fr>

Hi Ludo,

there seems to be another regression in this series.

Pulling from 6a060ff27ff68384d7c90076baa36c349fff689d gives:
```
[ 1/20] Loading './guix/base32.scm'...

[ 2/20] Loading './guix/build/store-copy.scm'...

[ 3/20] Loading './guix/build/syscalls.scm'...

[ 4/20] Loading './guix/build/utils.scm'...

[ 5/20] Loading './guix/combinators.scm'...

[ 6/20] Loading './guix/progress.scm'...

[ 7/20] Loading './guix/records.scm'...

[ 8/20] Loading './guix/serialization.scm'...

[ 9/20] Loading './guix/sets.scm'...

[10/20] Loading './guix/store/deduplication.scm'...

;;; Failed to autoload copy-file/deduplicate in (guix store deduplication):

;;; no code for module (gcrypt hash)

Backtrace:

          17 (primitive-load "/gnu/store/1fwvy0fz6zfgnyq1mj5pn8mfin7?")

In ice-9/eval.scm:

    619:8 16 (_ #f)

In srfi/srfi-1.scm:

   460:18 15 (fold #<procedure 7fffeeb741e0 at ice-9/eval.scm:336:1?> ?)

   460:18 14 (fold #<procedure 7fffeeb81ac0 at ice-9/eval.scm:336:1?> ?)

   460:18 13 (fold #<procedure 7fffeecdaf20 at ice-9/eval.scm:336:1?> ?)

In ice-9/eval.scm:

    619:8 12 (_ #(#(#<directory (guix build utils) 7fffef187d20>) # ?))

In ice-9/boot-9.scm:

   2806:4 11 (save-module-excursion #<procedure 7fffeecdad40 at ice-?>)

In unknown file:

          10 (primitive-load "./guix/store/deduplication.scm")

In ice-9/eval.scm:

   721:20  9 (primitive-eval (define-module (guix store #) # (# #) ?))

In ice-9/psyntax.scm:

  1241:36  8 (expand-top-sequence ((define-module (guix store #) ?)) ?)

  1233:19  7 (parse _ (("placeholder" placeholder)) ((top) #(# # ?)) ?)

   285:10  6 (parse _ (("placeholder" placeholder)) (()) _ c&e (eval) ?)

In ice-9/eval.scm:

   293:34  5 (_ #<directory (guix build utils) 7fffef187d20>)

In ice-9/boot-9.scm:

   3380:4  4 (define-module* _ #:filename _ #:pure _ #:version _ # _ ?)

  2565:24  3 (call-with-deferred-observers #<procedure 7fffeec53cd0 ?>)

  3393:24  2 (_)

   222:17  1 (map1 (((gcrypt hash)) ((guix build utils)) ((guix ?)) ?))

   3300:6  0 (resolve-interface (gcrypt hash) #:select _ #:hide _ # _ ?)



ice-9/boot-9.scm:3300:6: In procedure resolve-interface:

no code for module (gcrypt hash)

```
All commits before in this series are fine. The fix in
d88ff09ea3138fc85c1463b0b345bd6ba71ca568 does not really help.




  parent reply	other threads:[~2020-12-16 21:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 11:02 bug#44760: Closure copy in ‘guix system init’ is inefficient Ludovic Courtès
2020-11-22 19:46 ` raingloom
2020-11-22 21:10   ` Ludovic Courtès
2020-12-11 15:09 ` bug#44760: [PATCH 00/15] Speed up 'guix system init' & co Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 01/15] serialization: 'fold-archive' notifies about directory processing completion Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 02/15] serialization: 'restore-file' sets canonical timestamp and permissions Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 03/15] nar: Deduplicate files right as they are restored Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 04/15] store-copy: 'populate-store' resets timestamps Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 05/15] image: 'register-closure' assumes already-reset timestamps Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 06/15] database: Remove #:reset-timestamps? from 'register-items' Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 07/15] store-copy: 'populate-store' can optionally deduplicate files Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 08/15] image: 'register-closure' leaves it up to the caller to deduplicate Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 09/15] database: Remove #:deduplicate? from 'register-items' Ludovic Courtès
2020-12-15 16:33   ` bug#44760: [PATCH 00/15] Speed up 'guix system init' & co Ludovic Courtès
2020-12-11 15:09 ` bug#44760: [PATCH 10/15] guix system: 'init' copies, resets timestamps, and deduplicates at once Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 11/15] database: Remove #:deduplicate? and #:reset-timestamps? from 'register-path' Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 12/15] system: 'init' does not recompute the hash of each store item Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 13/15] database: Remove 'register-path' Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 14/15] database: Honor 'SOURCE_DATE_EPOCH' Ludovic Courtès
2020-12-11 15:09   ` bug#44760: [PATCH 15/15] deduplicate: Create the '.links' directory lazily Ludovic Courtès
2020-12-15 16:38 ` bug#44760: Closure copy in ‘guix system init’ is inefficient Ludovic Courtès
2020-12-16 21:53 ` Jonathan Brielmaier [this message]
2020-12-17 13:24   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5e9cb2c-16b8-f880-3c71-34b0f03b7696@web.de \
    --to=jonathan.brielmaier@web.de \
    --cc=44760@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).