unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#47735: Non-absolute paths in mariadb scripts
@ 2021-04-12 20:14 Maxime Devos
  2021-04-13 18:41 ` david larsson
  0 siblings, 1 reply; 2+ messages in thread
From: Maxime Devos @ 2021-04-12 20:14 UTC (permalink / raw)
  To: 47735

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

Hi Guix,

As part of <https://issues.guix.gnu.org/47704>, it was discovered
some shell scripts in the mariadb package (e.g. wsrep_sst_rsync)
refer to programs *not* by absolute name.

These programs come from iproute, coreutils, gawk, grep
and mariadb itself.  It seems some substitutions are in order.

Some complications:
some of these scripts are only required in certain configurations.
It's not ideal to increase the closure with rsync and xbcrypt if
they turn out not to be needed ...

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#47735: Non-absolute paths in mariadb scripts
  2021-04-12 20:14 bug#47735: Non-absolute paths in mariadb scripts Maxime Devos
@ 2021-04-13 18:41 ` david larsson
  0 siblings, 0 replies; 2+ messages in thread
From: david larsson @ 2021-04-13 18:41 UTC (permalink / raw)
  To: Maxime Devos; +Cc: 47735, bug-Guix

On 2021-04-12 22:14, Maxime Devos wrote:
> Hi Guix,
> 
> As part of <https://issues.guix.gnu.org/47704>, it was discovered
> some shell scripts in the mariadb package (e.g. wsrep_sst_rsync)
> refer to programs *not* by absolute name.
> 
> These programs come from iproute, coreutils, gawk, grep
> and mariadb itself.  It seems some substitutions are in order.
> 
> Some complications:
> some of these scripts are only required in certain configurations.
> It's not ideal to increase the closure with rsync and xbcrypt if
> they turn out not to be needed ...
> 
> Greetings,
> Maxime.

Adding to this, so far we've we discussed possible fixes:

1. Absolutize all invocations in the sripts using (substitute* 
procedure.
   - drawback: maintenance hassle.

2. Adding (define %default-environment-variables to the mysql-service 
and append this to the list-argument of the #:environment-variables 
keyword in the make-forkexec-constructor procedure.
   - drawback: doesn't actually fix the mysql package, just the service.

3. Adding a line: 
"PATH=<absolute-path-to-awk>:<absolute-path-to-grep>:<etc..>" in the 
scripts.
   - Not the most elegant solution, but possibly the best one; not too 
much maintenance and actually fixes both the package and the service.
   - drawback: It would also increase the closure size of the mysql 
package. Security issues?

Another option, perhaps, would be to have a mysql-minimal package (as 
the package is today) and a regular mysql package ("mysql-full" with the 
increase closure size), and you can use whichever package you need in 
the mysql-service.

I don't know which solution I would vote for...

Best regards,
David L




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-13 18:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-12 20:14 bug#47735: Non-absolute paths in mariadb scripts Maxime Devos
2021-04-13 18:41 ` david larsson

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).