From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id gBqYO06kVl/6WgAA0tVLHw (envelope-from ) for ; Mon, 07 Sep 2020 21:21:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GIJqN06kVl9IcQAAbx9fmQ (envelope-from ) for ; Mon, 07 Sep 2020 21:21:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6DECD940142 for ; Mon, 7 Sep 2020 21:21:18 +0000 (UTC) Received: from localhost ([::1]:53770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFOZh-0005Gg-CI for larch@yhetil.org; Mon, 07 Sep 2020 17:21:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFOZS-0005G3-R4 for bug-guix@gnu.org; Mon, 07 Sep 2020 17:21:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39605) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFOZS-0001Sd-I9 for bug-guix@gnu.org; Mon, 07 Sep 2020 17:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFOZS-0002G4-Ez for bug-guix@gnu.org; Mon, 07 Sep 2020 17:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43093: emacs-ess is broken by emacs 27.1 Resent-From: divoplade Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 07 Sep 2020 21:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43093 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Tim Howes , 43093@debbugs.gnu.org Received: via spool by 43093-submit@debbugs.gnu.org id=B43093.15995136078575 (code B ref 43093); Mon, 07 Sep 2020 21:21:02 +0000 Received: (at 43093) by debbugs.gnu.org; 7 Sep 2020 21:20:07 +0000 Received: from localhost ([127.0.0.1]:51147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFOYY-0002EC-HY for submit@debbugs.gnu.org; Mon, 07 Sep 2020 17:20:06 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:54389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFOYT-0002DU-SK for 43093@debbugs.gnu.org; Mon, 07 Sep 2020 17:20:04 -0400 X-Originating-IP: 86.194.83.229 Received: from divoplade.home (lfbn-lyo-1-1007-229.w86-194.abo.wanadoo.fr [86.194.83.229]) (Authenticated sender: d@divoplade.fr) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 8B5A11C0006; Mon, 7 Sep 2020 21:19:50 +0000 (UTC) Message-ID: From: divoplade Date: Mon, 07 Sep 2020 23:19:40 +0200 In-Reply-To: <1dcca395-324d-d167-836d-31329e2c3fd7@lavabit.com> References: <605a30acc9c66c09938147cccfcaafc3b9f8d57e.camel@divoplade.fr> <1dcca395-324d-d167-836d-31329e2c3fd7@lavabit.com> Content-Type: multipart/mixed; boundary="=-qRqlQALEusm2bjSLTFyS" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: rWfQ+mk2TI9i --=-qRqlQALEusm2bjSLTFyS Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hello Tim, Le vendredi 04 septembre 2020 à 11:25 -0700, Tim Howes a écrit : > I think, instead of disabling the test or trying to make it work > with > emacs 27, I'd like to update emacs-ess to a more recent version. > Right > now it's using the latest tagged release (18.10.2), which was from > 2018, > but there's been active development on the github repo since then. I > can > take the latest commit and give it a version number based on the > commit > time, similar to how it's done on melpa (20200903.1516). I'll try > making > a patch to update it to that version. Right, emacs-ess is already a tag. Let's take the latest commit, 82cd308ae54a6b918bbceb235e6bf02f53e48e19 If I run guix hash -xr within the code, I get 0zw6j8jzrdmy41g6313js7c0xlmc2wmiazx4d4wm6hdvykn8q39k The version would be 20200905.1022 If I do a drop-in replacement, remove the "Fix roxygen preview test." modification and change the commands to disable julia, I get one other test that fails: Test ess-test-r-help-mode condition: (ert-test-failed ((should (or (equal ess-help-object "plot.default") (equal ess-help-object "plot"))) :form (or (equal ess-help-object "plot.default") (equal ess-help-object "plot")) :value nil)) The test is in test/ess-test-r.el, line 628. (ert-deftest ess-test-r-help-mode () (with-r-running nil (let ((ess-pop-to-buffer t)) (ess-display-help-on-object "plot") (should (equal ess-help-object "plot")) (should (derived-mode-p 'ess-r-help-mode)) ;; Ensure help buffers after button presses are also in ;; `ess-r-help-mode', Bug#836 (forward-button 2) (push-button) (should (or (equal ess-help-object "plot.default") (equal ess-help-object "plot"))) ;; Badaboom ;;(the value is "NULL") (should (derived-mode-p 'ess-r-help-mode))))) Looking at its friend, ess-test-r-index-mode, line 643: (ert-deftest ess-test-r-index-mode () (skip-unless (not noninteractive)) ;; negation overflow ;p (with-r-running nil (let ((ess-pop-to-buffer t)) (ess-display-package-index "stats") (should (equal ess-help-object "stats")) (should (derived-mode-p 'ess-r-help-mode)) ;; Ensure help buffers after button presses are also in ;; `ess-r-help-mode', Bug#836 (forward-button 2) (push-button) (should (equal ess-help-object "plot.default")) (should (derived-mode-p 'ess-r-help-mode))))) it seems that these tests should only run if (not (not (not (not interactive)))) (i.e. interactive), and ess-test-r-help-mode has missed a copy-paste. Also, the license has changed: it is now gpl3+! Anyway, here is a version that's working (I tested it with "emacs-ess- next" as a name, but replaced it for this message). Sorry, I don't know how to make a patch. Best regards, divoplade --=-qRqlQALEusm2bjSLTFyS Content-Disposition: attachment; filename="modified-emacs.scm" Content-Transfer-Encoding: base64 Content-Type: text/x-scheme; name="modified-emacs.scm"; charset="UTF-8" KGRlZmluZS1wdWJsaWMgZW1hY3MtZXNzCiAgKHBhY2thZ2UKICAgIChuYW1lICJlbWFjcy1lc3Mi KQogICAgKHZlcnNpb24gIjIwMjAwOTA1LjEwMjIiKQogICAgKHNvdXJjZSAob3JpZ2luCiAgICAg ICAgICAgICAgKG1ldGhvZCBnaXQtZmV0Y2gpCiAgICAgICAgICAgICAgKHVyaSAoZ2l0LXJlZmVy ZW5jZQogICAgICAgICAgICAgICAgICAgICh1cmwgImh0dHBzOi8vZ2l0aHViLmNvbS9lbWFjcy1l c3MvRVNTIikKICAgICAgICAgICAgICAgICAgICAoY29tbWl0ICI4MmNkMzA4YWU1NGE2YjkxOGJi Y2ViMjM1ZTZiZjAyZjUzZTQ4ZTE5IikpKQogICAgICAgICAgICAgIChzaGEyNTYKICAgICAgICAg ICAgICAgKGJhc2UzMgogICAgICAgICAgICAgICAgIjB6dzZqOGp6cmRteTQxZzYzMTNqczdjMHhs bWMyd21pYXp4NGQ0d202aGR2eWtuOHEzOWsiKSkKICAgICAgICAgICAgICAoZmlsZS1uYW1lIChn aXQtZmlsZS1uYW1lIG5hbWUgdmVyc2lvbikpCiAgICAgICAgICAgICAgKG1vZHVsZXMgJygoZ3Vp eCBidWlsZCB1dGlscykpKQogICAgICAgICAgICAgIChzbmlwcGV0CiAgICAgICAgICAgICAgICco YmVnaW4KICAgICAgICAgICAgICAgICAgOzsgU3RvcCBFU1MgZnJvbSB0cnlpbmcgdG8gYnVuZGxl IGFuIGV4dGVybmFsIGp1bGlhLW1vZGUuZWwuCiAgICAgICAgICAgICAgICAgIChzdWJzdGl0dXRl KiAibGlzcC9NYWtlZmlsZSIKICAgICAgICAgICAgICAgICAgICAoKCJKVUxJQVMgOj0ganVsaWEt bW9kZS5lbCBqdWxpYS1tb2RlLWxhdGV4c3Vicy5lbCIpICJKVUxJQVMgPSIpKQogICAgICAgICAg ICAgICAgICAoc3Vic3RpdHV0ZSogIk1ha2VmaWxlIgogICAgICAgICAgICAgICAgICAgICgoIiQo TUFLRSkganVsaWEtbW9kZS5lbCIpICIiKSkKICAgICAgICAgICAgICAgICAgKHN1YnN0aXR1dGUq ICJ0ZXN0L01ha2VmaWxlIgoJCQkgICAgICAgKCgibGlzcDoganVsaWEiKSAibGlzcDoiKSkKCQkg IDs7IEl0IGxvb2tzIGxpa2UgdGhpcyB0ZXN0IG1pc3NlcyBhIHBhc3RlCiAgICAgICAgICAgICAg ICAgIChzdWJzdGl0dXRlKiAidGVzdC9lc3MtdGVzdC1yLmVsIgoJCQkgICAgICAgKCgiXFwoZXJ0 LWRlZnRlc3QgZXNzLXRlc3Qtci1oZWxwLW1vZGUgXFwoXFwpIikgIihlcnQtZGVmdGVzdCBlc3Mt dGVzdC1yLWhlbHAtbW9kZSAoKSAoc2tpcC11bmxlc3MgKG5vdCBub25pbnRlcmFjdGl2ZSkpIikp CiAgICAgICAgICAgICAgICAgIDs7IEluY2x1ZGUgKi5lbCBmaWxlcyBpbiBpbnN0YWxsIHRhcmdl dC4KICAgICAgICAgICAgICAgICAgKHN1YnN0aXR1dGUqICJsaXNwL01ha2VmaWxlIgogICAgICAg ICAgICAgICAgICAgICgoIlx0XFwkXFwoSU5TVEFMTCkgXFwkXFwoRUxDXFwpIFxcJFxcKExJU1BE SVJcXCkiIGVsYykKICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgIlx0JChJTlNU QUxMKSAkKEVMUykgZXNzLWF1dG9sb2Fkcy5lbCAiCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICIkKExJU1BESVIpXG4iIGVsYykpKQogICAgICAgICAgICAgICAgICA7OyBPbmx5 IGJ1aWxkIGRvY3MgaW4gaW5mbyBmb3JtYXQuCiAgICAgICAgICAgICAgICAgIChzdWJzdGl0dXRl KiAiZG9jL01ha2VmaWxlIgogICAgICAgICAgICAgICAgICAgICgoImFsbCAgOiBpbmZvIHRleHQi KQogICAgICAgICAgICAgICAgICAgICAiYWxsICA6IGluZm8iKQogICAgICAgICAgICAgICAgICAg ICgoImluc3RhbGw6IGluc3RhbGwtaW5mbyBpbnN0YWxsLW90aGVyLWRvY3MiKQogICAgICAgICAg ICAgICAgICAgICAiaW5zdGFsbDogaW5zdGFsbC1pbmZvIikpCiAgICAgICAgICAgICAgICAgIDs7 IFN0b3AgaW5zdGFsbC1pbmZvIGZyb20gdHJ5aW5nIHRvIHVwZGF0ZSB0aGUgaW5mbyBkaXJlY3Rv cnkuCiAgICAgICAgICAgICAgICAgIChzdWJzdGl0dXRlKiAiZG9jL01ha2VmaWxlIgogICAgICAg ICAgICAgICAgICAgICgoIi4qXFwkXFwoSU5GT0RJUlxcKS9kaXIuKiIpICIiKSkKICAgICAgICAg ICAgICAgICAgI3QpKSkpCiAgICAoYnVpbGQtc3lzdGVtIGdudS1idWlsZC1zeXN0ZW0pCiAgICAo YXJndW1lbnRzCiAgICAgKGxldCAoKGJhc2UtZGlyZWN0b3J5ICIvc2hhcmUvZW1hY3Mvc2l0ZS1s aXNwIikpCiAgICAgICBgKCM6bWFrZS1mbGFncyAobGlzdCAoc3RyaW5nLWFwcGVuZCAiUFJFRklY PSIgJW91dHB1dCkKICAgICAgICAgICAgICAgICAgICAgICAgICAgIChzdHJpbmctYXBwZW5kICJF VENESVI9IiAlb3V0cHV0CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAsYmFzZS1kaXJlY3RvcnkgIi9ldGMiKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0 cmluZy1hcHBlbmQgIkxJU1BESVI9IiAlb3V0cHV0CiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAsYmFzZS1kaXJlY3RvcnkpKQogICAgICAgICAjOnBoYXNlcwogICAg ICAgICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCiAgICAgICAgICAgKGRlbGV0ZSAn Y29uZmlndXJlKQogICAgICAgICAgIChhZGQtYmVmb3JlICdidWlsZCAnbW9yZS1zaGViYW5nLXBh dGNoaW5nCiAgICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgaW5wdXRzICM6YWxsb3ctb3RoZXIt a2V5cykKICAgICAgICAgICAgICAgKHN1YnN0aXR1dGUqICJNYWtlY29uZiIKICAgICAgICAgICAg ICAgICAoKCJTSEVMTCA9IC9iaW4vc2giKQogICAgICAgICAgICAgICAgICAoc3RyaW5nLWFwcGVu ZCAiU0hFTEwgPSAiICh3aGljaCAic2giKSkpKQogICAgICAgICAgICAgICAjdCkpCiAgICAgICAg ICAgKHJlcGxhY2UgJ2NoZWNrCiAgICAgICAgICAgICAobGFtYmRhIF8KICAgICAgICAgICAgICAg KGludm9rZSAibWFrZSIgInRlc3QiKSkpKSkpKQogICAgKGlucHV0cwogICAgIGAoKCJlbWFjcyIg LGVtYWNzLW1pbmltYWwpCiAgICAgICAoInItbWluaW1hbCIgLHItbWluaW1hbCkpKQogICAgKG5h dGl2ZS1pbnB1dHMKICAgICBgKCgicGVybCIgLHBlcmwpCiAgICAgICAoInItcm94eWdlbjIiICxy LXJveHlnZW4yKQogICAgICAgKCJ0ZXhpbmZvIiAsdGV4aW5mbykpKQogICAgKHByb3BhZ2F0ZWQt aW5wdXRzCiAgICAgYCgoImVtYWNzLWp1bGlhLW1vZGUiICxlbWFjcy1qdWxpYS1tb2RlKSkpCiAg ICAoaG9tZS1wYWdlICJodHRwczovL2Vzcy5yLXByb2plY3Qub3JnLyIpCiAgICAoc3lub3BzaXMg IkVtYWNzIG1vZGUgZm9yIHN0YXRpc3RpY2FsIGFuYWx5c2lzIHByb2dyYW1zIikKICAgIChkZXNj cmlwdGlvbiAiRW1hY3MgU3BlYWtzIFN0YXRpc3RpY3MgKEVTUykgaXMgYW4gYWRkLW9uIHBhY2th Z2UgZm9yIEdOVQpFbWFjcy4gIEl0IGlzIGRlc2lnbmVkIHRvIHN1cHBvcnQgZWRpdGluZyBvZiBz Y3JpcHRzIGFuZCBpbnRlcmFjdGlvbiB3aXRoCnZhcmlvdXMgc3RhdGlzdGljYWwgYW5hbHlzaXMg cHJvZ3JhbXMgc3VjaCBhcyBSLCBKdWxpYSwgYW5kIEpBR1MuIikKICAgIChsaWNlbnNlIGxpY2Vu c2U6Z3BsMyspKSkK --=-qRqlQALEusm2bjSLTFyS--