bug#67973: docbook2x build failure

bug#67973: docbook2x build failure

[Greg Hogan]

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]

Build log attached. Am building from the most recent upstream commit
to core-updates (eff2e20688). bug#65479 "Docbook & XML/SGML
improvements" was merged to core-updates on October 10.

--8<---------------cut here---------------start------------->8---
Making all in documentation
make[2]: Entering directory
'/tmp/guix-build-docbook2x-0.8.8.drv-0/docbook2X-0.8.8/xslt/documentation'
../../perl/db2x_xsltproc -C ../../xslt/catalog.xml -s ./ss-texi.xsl -o
docbook2man-xslt.txml docbook2man-xslt.xml \
        -g output-file="docbook2man-xslt"
docbook2man-xslt.xml:1: parser error : Document is empty

^
unable to parse docbook2man-xslt.xml
make[2]: *** [Makefile:808: docbook2man-xslt.txml] Error 6
make[2]: Leaving directory
'/tmp/guix-build-docbook2x-0.8.8.drv-0/docbook2X-0.8.8/xslt/documentation'
make[1]: *** [Makefile:389: all-recursive] Error 1
make[1]: Leaving directory
'/tmp/guix-build-docbook2x-0.8.8.drv-0/docbook2X-0.8.8/xslt'
make: *** [Makefile:411: all-recursive] Error 1
error: in phase 'build': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("-j" "1")
exit-status: 2 term-signal: #f stop-signal: #f>
phase `build' failed after 0.4 seconds
command "make" "-j" "1" failed with status 2
build process 4 exited with status 256
--8<---------------cut here---------------end--------------->8---

[-- Attachment #2: b8slfkxkrj83shnglrpjhq5ykcxwq1-docbook2x-0.8.8.drv.gz --]
[-- Type: application/gzip, Size: 6940 bytes --]

bug#67973: [PATCH core-updates 0/1] gnu: docbook2x: Fix build.

[Bruno Victal]

Hi Greg,

Thanks for noticing, it turned out to be a regression introduced in v3.

Bruno Victal (1):
  gnu: docbook2x: Fix build.

 gnu/packages/docbook.scm | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)


base-commit: e769385a7e348c8ba97614d889d7e8625fd8226a
-- 
2.41.0

bug#67973: [PATCH core-updates 1/1] gnu: docbook2x: Fix build.

[Bruno Victal]

The documentation step fails to build if the original configure script is
removed.

* gnu/packages/docbook.scm (docbook2x)[source]: Preserve original configure
script.
[arguments]<#:phases>: Add 'autoreconf phase.
<#:modules>: Use %default-gnu-modules.
---
 gnu/packages/docbook.scm | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/docbook.scm b/gnu/packages/docbook.scm
index 3046846619..02e60222ac 100644
--- a/gnu/packages/docbook.scm
+++ b/gnu/packages/docbook.scm
@@ -912,21 +912,20 @@ (define-public docbook2x
               (modules '((guix build utils)))
               (snippet
                ;; Fix a failing test (maybe it worked with old texinfo?)
-               #~(begin
-                   (substitute* "test/complete-manuals/at1.xml"
-                     (("<bridgehead>")
-                      "<bridgehead renderas=\"sect2\">"))
-                   ;; Force a new autoreconf run.
-                   (delete-file "configure")))))
+               #~(substitute* "test/complete-manuals/at1.xml"
+                   (("<bridgehead>")
+                    "<bridgehead renderas=\"sect2\">")))))
     (outputs '("out" "doc"))
     (build-system gnu-build-system)
     (arguments
      (list
-      #:modules '((guix build gnu-build-system)
-                  (guix build utils)
-                  (srfi srfi-26))
+      #:modules `((srfi srfi-26)
+                  ,@%default-gnu-modules)
       #:phases
       #~(modify-phases %standard-phases
+          (add-after 'unpack 'autoreconf
+            (lambda _
+              (invoke "autoreconf" "-vif")))
           (add-after 'install 'move-doc
             (lambda _
               (let* ((old (string-append #$output "/share/doc"))
-- 
2.41.0

bug#67973: [PATCH core-updates 1/1] gnu: docbook2x: Fix build.

[Steve George]

Hi,

Builds fine on current core-updates, so closing.

Steve / Futurile

On 29 Dec, Bruno Victal wrote:
> The documentation step fails to build if the original configure script is
> removed.
> 
> * gnu/packages/docbook.scm (docbook2x)[source]: Preserve original configure
> script.
> [arguments]<#:phases>: Add 'autoreconf phase.
> <#:modules>: Use %default-gnu-modules.
> ---
>  gnu/packages/docbook.scm | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/gnu/packages/docbook.scm b/gnu/packages/docbook.scm
> index 3046846619..02e60222ac 100644
> --- a/gnu/packages/docbook.scm
> +++ b/gnu/packages/docbook.scm
> @@ -912,21 +912,20 @@ (define-public docbook2x
>                (modules '((guix build utils)))
>                (snippet
>                 ;; Fix a failing test (maybe it worked with old texinfo?)
> -               #~(begin
> -                   (substitute* "test/complete-manuals/at1.xml"
> -                     (("<bridgehead>")
> -                      "<bridgehead renderas=\"sect2\">"))
> -                   ;; Force a new autoreconf run.
> -                   (delete-file "configure")))))
> +               #~(substitute* "test/complete-manuals/at1.xml"
> +                   (("<bridgehead>")
> +                    "<bridgehead renderas=\"sect2\">")))))
>      (outputs '("out" "doc"))
>      (build-system gnu-build-system)
>      (arguments
>       (list
> -      #:modules '((guix build gnu-build-system)
> -                  (guix build utils)
> -                  (srfi srfi-26))
> +      #:modules `((srfi srfi-26)
> +                  ,@%default-gnu-modules)
>        #:phases
>        #~(modify-phases %standard-phases
> +          (add-after 'unpack 'autoreconf
> +            (lambda _
> +              (invoke "autoreconf" "-vif")))
>            (add-after 'install 'move-doc
>              (lambda _
>                (let* ((old (string-append #$output "/share/doc"))
> -- 
> 2.41.0
> 
> 
> 
> 

bug#67973: [PATCH core-updates 0/1] gnu: docbook2x: Fix build.

[Greg Hogan]

On Fri, Dec 29, 2023 at 5:14 PM Bruno Victal <mirai@makinata.eu> wrote:
>
> Hi Greg,
>
> Thanks for noticing, it turned out to be a regression introduced in v3.
>
> Bruno Victal (1):
>   gnu: docbook2x: Fix build.
>
>  gnu/packages/docbook.scm | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
>
>
> base-commit: e769385a7e348c8ba97614d889d7e8625fd8226a
> --
> 2.41.0

Hi Bruno,

Can this issue be closed? I am now able to build dockbook2x on
core-updates, and I believe this was fixed by Josselin Poiret in
d3a45711392fcecff640915c8bd881ff82559757 (also on 2023/12/29).


Greg