bug#68948: highlight error, cannot open filetypes.conf: No such file or directory

bug#68948: highlight error, cannot open filetypes.conf: No such file or directory

[chris]

There is an issue using "highlight"

https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/pretty-print.scm#n353
http://www.andre-simon.de/doku/highlight/en/highlight.php#ch3_8

This unexpected error is reproduced easily with the command below: "cannot open filetypes.conf"
```
$ echo "(highlight (package bug))" | highlight -O xterm256 --syntax lisp
cannot open filetypes.conf: No such file or directory
(highlight (package bug))
```

Creating `~/.highlight/filetypes.conf` did not resolve the error.
Setting "HIGHLIGHT_DATADIR=$HOME/.config/highlight/" did not resolve the error.

Any advice is welcome. Thank you :)

Chris

bug#68948: temp fix

[chris]

The following workaround can be used,
```
HLDIRS=$(guix build highlight); # returns two directories
HLDIR="${HLDIRS##*[[:space:]]}"; # returns the second dir, after whitespace
DATADIR="$HLDIR/etc/highlight/";
echo "(highlight (package bug))" | highlight --data-dir=$DATADIR -O xterm256 --syntax lisp
```

Based on my understanding, the current package definition is correct. Possibly a patch like this could resolve the issue the current package definition seems correct.
```
diff --git a/gnu/packages/pretty-print.scm b/gnu/packages/pretty-print.scm
index b95f56729a..2a7cf74009 100644
--- a/gnu/packages/pretty-print.scm
+++ b/gnu/packages/pretty-print.scm
@@ -389,7 +389,7 @@ (define-public highlight
                           (lambda* (#:key inputs outputs #:allow-other-keys)
                             (let* ((out (assoc-ref outputs "out"))
                                    (data (string-append out
-                                                        "/share/highlight/"))
+                                                        "/etc/highlight/"))
                                    (conf (string-append out "/etc/highlight/"))
                                    (doc (string-append out
                                          "/share/doc/highlight/"))
```

bug#68948: highlight error, cannot open filetypes.conf: No such file or directory

[chris]

Below changes at the highlight package resolve the issue here but may adversely affect "highlight-gui" functionality. Will wait for https://issues.guix.gnu.org/70047 before trying to proceed,
```diff
-      #:make-flags #~(let ((confdir (string-append %output
-                                                   "/share/highlight/config/")))
-                       (list (string-append "PREFIX=" %output)
-                             (string-append "HL_CONFIG_DIR=" confdir)
-                             (string-append "conf_dir=" confdir)))
+      #:make-flags #~(list (string-append "PREFIX=" %output)
+                           (string-append "HL_CONFIG_DIR=" %output "/etc/")
+                           (string-append "conf_dir=" %output "/etc/"))
```