From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:700:3204::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id UDUhNgkAjGXSWQEAkFu2QA (envelope-from ) for ; Wed, 27 Dec 2023 11:44:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id wAKHLgkAjGXqfwEAe85BDQ (envelope-from ) for ; Wed, 27 Dec 2023 11:44:25 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=SeoaQz0B; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1703673865; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=h3tp7PIKxY2xR4P+tObxXqY1XuViKQVUITgj83Kpuik=; b=LYucQXFHA4A6DKD9utWF+D0Tc0ahF49javEYSGwADYoVFBMBQpX1KASIeE1LH2nDw7FpqG aW5GNRKMfp26I7FArbkHyBqqw1BBiJam0hCOYY36THGBFPdpwk+6miy+8n4Ld5IB1eOGUI /H+FN11smU+7iZp3nZ2QieBIeOm13WWgw8WNijX4LL9q5a1xqZu1x+HhZvpQVATUWUh0Ct 7+Vj4qBzmhDKunjJTezFr78EnQ56/8WoQ3s7OOpsojSsgzPAl/eYfzCEsMaI1mDAOxrk4K lavmffXUjgCF/NulNlT0NiFy8i3b+2c9T4B4D0iRN6PWzbHYzg1G09Jef3RyoA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1703673865; a=rsa-sha256; cv=none; b=FAeErBlL7w3PTjcL/1eLz4nF8/ns78ofknx/ue+taJtyKZ7cMgDTdacrZC+iVR2LHwWVcf a1Qxeh952IgTw23N3JC66irJSWI8S7hVr5uU4N3ckmGLFdl40UiLVgbxn3N+iSu6hLnlvL NPrhZFW2AbNZe+dKq9wGnq1em9L/NOHfJ8onMRXRtlbLAPlaQHHH9jdaRWONfIex0j3WuQ MU3D/roNpyyOwUTAyZaGDma+SLZkec1fr8DPEXAPQL/x2lYpKr4uHHL4JX353Y0z1Y/W+W jFm9GaEOy4t/eg1ooFRnuqrw58ahBqO5t2FhD8jWPOCoMyCy2t9qsNBAAPNpYw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=SeoaQz0B; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 448AA541A1 for ; Wed, 27 Dec 2023 11:44:25 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rIROR-0008UH-Pr; Wed, 27 Dec 2023 05:44:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rIROO-0008Ts-WE for bug-guix@gnu.org; Wed, 27 Dec 2023 05:44:05 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rIROO-0004R8-Na for bug-guix@gnu.org; Wed, 27 Dec 2023 05:44:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rIRON-0005qH-8Y for bug-guix@gnu.org; Wed, 27 Dec 2023 05:44:03 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#68017: Clarification on why cargo-build-system should propagate inputs and native-inputs. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 27 Dec 2023 10:44:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68017 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jaeme Sifat Cc: 68017@debbugs.gnu.org, tsymsh@gmail.com Received: via spool by 68017-submit@debbugs.gnu.org id=B68017.170367382922411 (code B ref 68017); Wed, 27 Dec 2023 10:44:03 +0000 Received: (at 68017) by debbugs.gnu.org; 27 Dec 2023 10:43:49 +0000 Received: from localhost ([127.0.0.1]:35417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rIRO9-0005pP-CQ for submit@debbugs.gnu.org; Wed, 27 Dec 2023 05:43:49 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:56594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rIRO7-0005pC-P8 for 68017@debbugs.gnu.org; Wed, 27 Dec 2023 05:43:48 -0500 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-336979a566aso3634926f8f.1 for <68017@debbugs.gnu.org>; Wed, 27 Dec 2023 02:43:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703673823; x=1704278623; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=h3tp7PIKxY2xR4P+tObxXqY1XuViKQVUITgj83Kpuik=; b=SeoaQz0BrbHK9yNFdhpaZ3o7SxCkkv/FE4H+WhNHoXXZIhKFicsCxdHBGNCavUioqo tYI+dsStBRI/QZwWh+YMF6ynrtfr4J/casWDm7FyjbxLB+atba7PTcZzVR0/9AQUwWc1 gX6NzsJli681WTZmzxMko9kA2dhACdK2nHuiicfVD6HNQiMtcSlS3yyBo3/tZhWjDEIF M5XIq9lFI6iYx3ewrrT3L55rDfZGmPCvi5rFUIuC4vnUH0JHz9/dotjSWlRhLP3vxeht fqbBU7TiEf0C8Dfx5NvAP6UH5ecgqlpltO9ENOt3MFU1qU99FTYWsXfN3uEjc3hSRaaj 8xZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703673823; x=1704278623; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h3tp7PIKxY2xR4P+tObxXqY1XuViKQVUITgj83Kpuik=; b=okdvBL/Gz4EUVnxDOvdbRsUxedODfS2vJrR5ThzFqhX0nN4iuPEg/F6XOAZ8UhlmX2 xQk4U0Ip7e/NQewHs7XDFth/HZzAB18TzfN4uHQaRzg+4ZS/jO72zRjeqRNrmKrD2l8q ay+HUIsYjaPpdL0gQBTVR+xA4LkSdYEUmGFnaJtqLEWQDLCdQgKR1ZTTMkmNoGQFe9oZ w0rBXGE2n9u0cxyTkLZbuXsR9vjHqKU0mXzBP9mdV2QVuhudVL8fWKABehKsNvfUjGJh xuqJWdACAb8+viQr6bH0FABKuqObMRVVdNzS7im/S0PEEroGRIVYUuHp7/ZTJP35VPyK efYw== X-Gm-Message-State: AOJu0YwqNnJnqsSOtpJWi4mH3uXRzp/eqPqCBzkvAnrIab6K30Q1DTWx Se+xIaQFyaez/VMqTIYCf60= X-Google-Smtp-Source: AGHT+IF1Nf4j/iDMQgyikqcdxGso8Cf1smbtgtRn5GJhYn78mR9aD+CjLSbo457ZmfbSdLC4BLiByw== X-Received: by 2002:a05:600c:4fc7:b0:40d:5dfc:5576 with SMTP id o7-20020a05600c4fc700b0040d5dfc5576mr396909wmq.150.1703673823037; Wed, 27 Dec 2023 02:43:43 -0800 (PST) Received: from localhost ([141.226.15.142]) by smtp.gmail.com with ESMTPSA id s15-20020a05600c45cf00b0040d5d5ac69asm2298918wmo.36.2023.12.27.02.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 02:43:42 -0800 (PST) Date: Wed, 27 Dec 2023 12:43:41 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Jaeme Sifat , 68017@debbugs.gnu.org, tsymsh@gmail.com References: <6c571648-f982-4b1c-bca3-22cd030b4940@runbox.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="20q5LugdfuQIFawj" Content-Disposition: inline In-Reply-To: <6c571648-f982-4b1c-bca3-22cd030b4940@runbox.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.82 X-Spam-Score: -6.82 X-Migadu-Queue-Id: 448AA541A1 X-Migadu-Scanner: mx11.migadu.com X-TUID: mR8sjooHuYJl --20q5LugdfuQIFawj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 25, 2023 at 03:02:22PM -0500, Jaeme Sifat wrote: > The culprit to your problem is `rust-ffmpeg-sys-the-third-1', which requi= res > all the packages you just mentioned for building. `rust-av1an-core` requi= res > `rust-ffmpeg-the-third-1' which in turn requires the sys libraries as wel= l. >=20 > --8<---------------cut here---------------start------------->8--- >=20 > rust-ffmpeg-sys-the-third-1 -> Requires vapoursynth ffmpeg clang nasm > pkg-config >=20 > rust-ffmpeg-the-third-1 -> Requires rust-ffmpeg-sys-the-third-1 >=20 > rust-av1an-core -> Requires rust-ffmpeg-the-third-1 >=20 > rust-av1an -> Requires rust-av1an-core >=20 > --8<---------------cut here---------------end--------------->8--- >=20 > Thus, the native-inputs and inputs of rust-ffmpeg-sys-the-third are requi= red > for any packages that depend on it in #:cargo-inputs. >=20 > I see your point now, it would be very helpful if cargo-build-system could > grab the inputs and native-inputs of dependent packages in the case of > crates like `rust-ffmpeg-sys-the-third-1.' That way the dependencies > wouldn't have to be duplicated across packages. >=20 > This sounds like a good suggestion, I can bring this up to Efraim, who is= on > the Rust team, about this who is much more knowledgeable about the > implementation of the cargo-build-system than me. I haven't looked too closely at that part of the cargo-build-system but in general my mental model is that it grabs the sources of the named packages in the cargo{,-development}-inputs. I suppose we could tell the crates to also grab the {propagated-,native-,}inputs also and carry those forward to the next crate. I suppose in theory we might end up with multiple versions of libgit2 or other packages, and I'm not sure if that'd point to various packages having the wrong inputs or needing to adjust it somehow to prefer one version over another. A similar issue is the perl dependency for rust-ring. I've finally fixed it on the rust-team branch using a computed-origin but I think both are the type of thing the antioxidant build system would help solve. I suppose we could end up with using propagated-inputs for things like perl or ffmpeg (in your package above) like we do with the python build systems and adjusting the cargo-build-system to grab those when it traverses the tree. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --20q5LugdfuQIFawj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmWL/9oACgkQQarn3Mo9 g1Gn8g//Tzl9jhIVF9FrE3r9Qmgu71cGamlxbVOtbdilbxDygRgWO8yWbOewIt9B cXZmvhuYfhZ/8z0bBZoyrjUvnG8dJFrH36BtkP7Y/bLp4Krk4Jq86zYpnCxSXQnp o7aGmKnUsU8LnzNpCQ460HuSu8Xo3klT92fqRQh83wsT61bR/JYiWSfgKz+EFhjE 4D4JjU7/ZMZM5605uD1pSHJWtJU/ZPdYt54HvMp8WdoMPMBej5UOpfV1i++nnQbT buExDpFNScxu5bTPjAMsGnIF+CbFx2+luhNGoUmKvJK727izN2/gJaGn7zrtPmAU n1Khwsa4ZDHUvJ3ufRLapIQtBeqG+GJhd+BbY+R7PScEGc39lVYvF8rAzInKqB3x 6jSFN1bZBvwpVlyxFZ/eb/YHWuleyCREVmoJvwHFQkdckEqgHcziRd8lASAIUPv4 2nGYUFhPnsqt6/0pfHZsBGg/lt4SLmDiwgGlmAjJUPf00TKs1g9tIWvXL98pyum+ FRmoN4c2ZmruY1oTOaHQB0i94YVqnV2GvL46ZwagYqArSEzRm8EYMVAUaCxDpKn3 78iE+FiypSLbvY3N9drx/PsGMls8Jt56FNu3uuYqY1QlP+yaTQtJjWuigmWjrs6m HrXxxe/JoulXgvuA8ejdvcqppi3olLsIDioXHHttXX03oFyxnFU= =yHRp -----END PGP SIGNATURE----- --20q5LugdfuQIFawj--