From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id IB8sNYic7WKJHwAAbAwnHQ (envelope-from ) for ; Sat, 06 Aug 2022 00:41:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id gNk0NYic7WJPwAAA9RJhRA (envelope-from ) for ; Sat, 06 Aug 2022 00:41:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 054D48261 for ; Sat, 6 Aug 2022 00:41:12 +0200 (CEST) Received: from localhost ([::1]:60356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oK60F-00026n-7c for larch@yhetil.org; Fri, 05 Aug 2022 18:41:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oK606-00026e-Q6 for bug-guix@gnu.org; Fri, 05 Aug 2022 18:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42709) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oK606-0001s5-H5 for bug-guix@gnu.org; Fri, 05 Aug 2022 18:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oK606-0004RR-Ca for bug-guix@gnu.org; Fri, 05 Aug 2022 18:41:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#56398: (guix git) fails to check out repos with nested submodules Resent-From: =?UTF-8?Q?Andr=C3=A9?= Batista Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 05 Aug 2022 22:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56398 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 56398@debbugs.gnu.org Received: via spool by 56398-submit@debbugs.gnu.org id=B56398.165973923517025 (code B ref 56398); Fri, 05 Aug 2022 22:41:02 +0000 Received: (at 56398) by debbugs.gnu.org; 5 Aug 2022 22:40:35 +0000 Received: from localhost ([127.0.0.1]:60689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oK5ze-0004QW-SX for submit@debbugs.gnu.org; Fri, 05 Aug 2022 18:40:35 -0400 Received: from mx1.riseup.net ([198.252.153.129]:53094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oK5zd-0004QF-Ep for 56398@debbugs.gnu.org; Fri, 05 Aug 2022 18:40:34 -0400 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4M00t31XJnzDqPB; Fri, 5 Aug 2022 22:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1659739227; bh=HMlfzZLdIvufHJKRj6uc/fNjiqZyI9FlqNBhLmK5Kg8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iE4UOnDkFiXOU/onieqK2KLDRcABvgWIufOt2IxYUt0r9LFzQl+maaZoYabIRVDGs lucAqMen0YyKHq2LHuNQpacSNtHg0nu9NB7JFDlZvB5plyUH8zmtBt520Bf8rMITmR tCZ4frVZRU67ngBPNZvMMt4roIlDGC04/JSs+G5g= X-Riseup-User-ID: B3CA2C84A70F9E69985F194E8CD2A2B34F0A0AE570AB8CFE7F21801018585360 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4M00t20vR5z1yQc; Fri, 5 Aug 2022 22:40:25 +0000 (UTC) Date: Fri, 5 Aug 2022 19:40:17 -0300 From: =?UTF-8?Q?Andr=C3=A9?= Batista Message-ID: References: <87sfnf4n7c.fsf@inria.fr> <87pmigxb5r.fsf@inria.fr> <87h72smd7r.fsf@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659739272; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=X1PeUyzOM+L40RsDHoK5u1qRxu9TlA+w3HauJ977i14=; b=abEhX3R+PlQCGP4HWdze35VzxsVkI5kB6Cg6GIFgHYuXfJSMuxkfTMidxtwY9pTRpU5v4o o6r+Js6mQqk1N83UhHucGEkWJ1SrPA2ZAPmyItfJWPMj+cS9lNg4pJQY7DorYMQgsonQTF iSWtBrXkRRuhX2vt4u29Pms/Yg8wTBnWZ7LUKP1+7795nF6k3Xiw4F0U0fqYjmbyKvh75m 4uMGwS+fz/V8EeAjeJL2uFhW2eEa3UK2YBsZ95UBvMuxThOI72+mwgDfFZ0WOhywwrDiIQ X4iVecmI6ajwUL7BgwDB+eNnQ5mOo3kH60kdWHrmh+/mBLuVg28kg2LPQbIWlA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659739272; a=rsa-sha256; cv=none; b=n2uPTPtljuCxFi0PK3QWNSe6qIp65FNON/PewFx1H0ZA03If08i6+xHDbqfszq9NFmEf/G wbJgVg2Uyso6dY3rfd0k4VFqTXSw5rOVvyDPb3valA+cw+a/KlelX3e5QzmW+PRmGsPH2Q t+XBdBBXl0yFUqZ23OPIXt3NY4lZ6NOY6VyJkEZpZ82cgIS5IBuw7NihYH78/vefOlpvnA LtwcgexVAAN462+DIKxWoMoo+joEKc47K3e6Yjw/LrntH3NCCNwOjITtNeG5/Ll8rCWg/w 76LBzgeQrQ1CPrQSCFF8WL6iXWlWSYt5UevaLUz8lao4rDpfP3g0Gq+DypGkEw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=iE4UOnDk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 8.00 X-Spam: Yes Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=riseup.net header.s=squak header.b=iE4UOnDk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=riseup.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 054D48261 X-Spam-Score: 8.00 X-Migadu-Spam: Yes X-Migadu-Scanner: scn1.migadu.com X-TUID: X1B/g/iBkVhA sex 05 ago 2022 ās 17:10:50 (1659730250), nandre@riseup.net enviou: > Does it though? I'm trying to wrap my head over this, but I'm somewhat > unsure that this isn't the intended - expected? - behaviour on this > case: > (...) > So, I'm inclined to think that this is not a bug on libgit2, but a > result of gloo having misconfigured its submodule and it's not > surprising that 'git_submodule_update' is erroring out. If so, any > program using this library should decide what to do with the returned > error, right? On further thinking, I guess I see what you mean: there's not much to be done in such a case and it would be better if libgit2 would silently fail, mimicking what git itself does, otherwise this logic would need to be reproduced everywhere else for no reason whatsoever. Sorry for the noise!