From: "André Batista" <nandre@riseup.net>
To: "Ludovic Courtès" <ludovic.courtes@inria.fr>
Cc: 56398@debbugs.gnu.org
Subject: bug#56398: (guix git) fails to check out repos with nested submodules
Date: Fri, 5 Aug 2022 19:40:17 -0300 [thread overview]
Message-ID: <Yu2cUfhpUdoUsxjY@andel> (raw)
In-Reply-To: <Yu15Ss+vIksxt0Z9@andel>
sex 05 ago 2022 às 17:10:50 (1659730250), nandre@riseup.net enviou:
> Does it though? I'm trying to wrap my head over this, but I'm somewhat
> unsure that this isn't the intended - expected? - behaviour on this
> case:
> (...)
> So, I'm inclined to think that this is not a bug on libgit2, but a
> result of gloo having misconfigured its submodule and it's not
> surprising that 'git_submodule_update' is erroring out. If so, any
> program using this library should decide what to do with the returned
> error, right?
On further thinking, I guess I see what you mean: there's not much to
be done in such a case and it would be better if libgit2 would
silently fail, mimicking what git itself does, otherwise this logic
would need to be reproduced everywhere else for no reason whatsoever.
Sorry for the noise!
next prev parent reply other threads:[~2022-08-05 22:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 15:02 bug#56398: (guix git) fails to check out repos with nested submodules Ludovic Courtès
2022-07-07 21:35 ` André Batista
2022-07-08 2:45 ` André Batista
2022-07-08 10:17 ` bokr
2022-08-04 12:01 ` André Batista
2022-07-08 8:26 ` Ludovic Courtès
2022-08-04 11:43 ` André Batista
2022-08-04 11:59 ` Ludovic Courtès
2022-08-05 20:10 ` André Batista
2022-08-05 22:40 ` André Batista [this message]
2022-11-24 15:17 ` André Batista
2022-11-24 23:51 ` bokr
2022-11-28 15:41 ` André Batista
2022-11-28 16:57 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yu2cUfhpUdoUsxjY@andel \
--to=nandre@riseup.net \
--cc=56398@debbugs.gnu.org \
--cc=ludovic.courtes@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).