From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oHtlAfNaQWIEUAAAgWs5BA (envelope-from ) for ; Mon, 28 Mar 2022 08:51:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uFzPOfJaQWLzjQAAauVa8A (envelope-from ) for ; Mon, 28 Mar 2022 08:51:30 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5608830B5 for ; Mon, 28 Mar 2022 08:51:30 +0200 (CEST) Received: from localhost ([::1]:60608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYjDs-0005Mx-4I for larch@yhetil.org; Mon, 28 Mar 2022 02:51:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYjDT-0005JP-3N for bug-guix@gnu.org; Mon, 28 Mar 2022 02:51:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nYjDS-0000yP-Na for bug-guix@gnu.org; Mon, 28 Mar 2022 02:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nYjDS-0003bs-Ht for bug-guix@gnu.org; Mon, 28 Mar 2022 02:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 28 Mar 2022 06:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25957 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxime Devos Received: via spool by 25957-submit@debbugs.gnu.org id=B25957.164845021213816 (code B ref 25957); Mon, 28 Mar 2022 06:51:02 +0000 Received: (at 25957) by debbugs.gnu.org; 28 Mar 2022 06:50:12 +0000 Received: from localhost ([127.0.0.1]:57010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYjCe-0003am-Jq for submit@debbugs.gnu.org; Mon, 28 Mar 2022 02:50:12 -0400 Received: from flashner.co.il ([178.62.234.194]:51016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYjCd-0003aX-05 for 25957@debbugs.gnu.org; Mon, 28 Mar 2022 02:50:11 -0400 Received: from localhost (unknown [5.102.239.82]) by flashner.co.il (Postfix) with ESMTPSA id A74AC40D0D; Mon, 28 Mar 2022 06:50:02 +0000 (UTC) Date: Mon, 28 Mar 2022 09:49:29 +0300 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Maxime Devos , zimoun , 25957@debbugs.gnu.org References: <20170303215819.bttmrfsbhlxyipmy@abyayala> <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> <86k0ff9has.fsf_-_@gmail.com> <8635l01x7a.fsf@gmail.com> <86lex10wwr.fsf@gmail.com> <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TzPdF/YzzWOLJluu" Content-Disposition: inline In-Reply-To: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 25957@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1648450290; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=IZ6PY/gse/iDXmdy7QWPvXilxaG96ZxyGP7NEoUYTsg=; b=L1Nh5Cq5wtdtbcIbcU01U7XEKZ1NAD/7weROfCALBUq3ye3Kg69/0jiFfgk6EFVYtx+nsY xIO+HhFiD/dT0okfHu9MqeyRuMVT1E9DaqWRgS0KZ7ugZyJqwMf1D3obQ7Q1h7kplmBcik BtHBQIPnbo5HXzvt60Jn9BKs2+YbXBxqS5WlhkMcjhfoQ21s/IlLMjHi+qxhXLgKbtTJBm eWLoND/V6k7TPE4+RU5Q28lz9+ASgWsBlBvJmN7Jj7QbuVQRyzP42AJSbVZHXqfT4Eli1q CumGjiY+TdMZAiwHuGj/stJaW9V0wqWjtybqCoUSE8NuTjKTxRmLlahfpTt6bg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1648450290; a=rsa-sha256; cv=none; b=ILJm53PskcBFBAQ4Oa0h5NN6mcwmofxQH2MvEEuXXVZabj5WRVtUZRSAltv0fVJGWTCwHb 3kicUnK4CDALP5a0GGfdt8I6hD9FsJYZgW24qUifRr1Annv/0mRVoeN75LPs8Ek1R6TaNP O0437y9qfw9taFByaNfsGLL3sOxXBBshlP3k4up/vpPbVHCltMxKj3eUi0PfvOZxRal1dr 3M/OHDs8A6sl4DauRrvMHJzDDoenxkYrn3U9K03RnMRBcPtFN78nJagD1ao6cUL+2ASCmn GpIY3UP32/GhcySuV3iBJmFYeP3ktJgiD3JhQ+B+aUDnpWhC1uwvdkoiCb4gIg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.17 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5608830B5 X-Spam-Score: -5.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: t95rkk002frz --TzPdF/YzzWOLJluu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 23, 2022 at 01:44:29PM +0100, Maxime Devos wrote: > zimoun schreef op wo 23-03-2022 om 11:45 [+0100]: > > > On Wed, 12 Jan 2022 at 20:07, Efraim Flashner > > > wrote: > > >=20 > > > > > =E2=80=A6the package redis is not a dependency of gitolite.=C2=A0= Therefore, > > > > > the > > > > > question is: is our Gitolite package working with Redis?=C2=A0 Ev= en > > > > > using the > > > > > /usr/bin one?=C2=A0 Idem for SVN. > > > > >=20 > > > > > Otherwise, I am favor to remove the 2 =E2=80=9Cproblematic=E2=80= =9D > > > > > references.=C2=A0=C2=A0 WDYT? > > > >=20 > > > > Or change it to search the $PATH for the binary, so it would just > > > > be > > > > 'redis-server' or 'svnserve' > > >=20 > > > Is our Gitolite package working with Redis?=C2=A0 If not, why try to > > > fix. ;-) > >=20 > > What is the status of this old bug [1]?=C2=A0 Is it actionable?=C2=A0 I= f yes, > > what > > is the action?=C2=A0 If no, let close it. :-)=C2=A0 WDYT? >=20 > Seems like all we have to do is 'substitute*' a '/usr/bin/svnserve' > into a '/gnu/store/...' (untested), so seems actionable to me. > Alternatively, as Efraim wrote, let it search the $PATH (that might be > useful if adding svnserve would increase the closure too much and it is > an optional dependency in practice?). I spent some time looking at gitolite and the service. As I understand it, with the exception of svnserve, it searches $PATH for a number of different binaries, including git-annex. I believe that this would only work if git-annex (and potentially other packages) are installed globally. In addition, git (not git-minimal) and openssh are propagated inputs AND wrapped. I haven't tested to see if wrapping only is enough. I think the best choice is to: A: Replace /usr/bin/svnserve with svnserve so it will just search $PATH, like it does with the other helpers. B: Adjust the service so that it automatically creates a variant (or just a wrapped version) of the package which is wrapped with a list of additional packages so that they can be in gitolite's path. If I were deploying this to an arm device I wouldn't want it wrapped with git-annex since it doesn't build, but would definitely want it for an x86_64 machine. I suppose we should try to find someone who is using the gitolite service and see if they can be our test subject for wrapping the package with optional addons. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --TzPdF/YzzWOLJluu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmJBWnIACgkQQarn3Mo9 g1F36A//TNGr5K6tptHG5aR4e6/StBJM5qrUJb/ldVQZ8yr0LpHQZF+PgHsdOX3S /thtlEwQuqVTnaBptF+9w8R35IowpDc1fwwQgy5zgKpFdH1r90ufFaNFm2YJ6Pep dLxpRyr3hxc3bOk6/B7cEfyBbD2A56qh4pLcGUrSbmfOH1VYZDKWNonBz1zZd4PC oyViPxFLWdXxblaSLo2CCxfKcsM0jmBV7VHgfOYaTrSvr+UStiKLf1Doib4Hfz2V ZnPq2oTv+tTr4gI7dSF5eOu4UtK45KcFLwuPWDNBw3s9dDeGcZ8ly6snbPFRhevU mAHo7rqkn1rpQLxAUYSZv35eZnpj2953TtekdCacHtrw+I9AhhBNwLhWJg3FF5By KkG9jbLp1d64UdTDCrxCte5XacS3mailiW0Oh2wzr/R5W42CntrVGPK1PSduyCe1 EzbkdnGd3lLpmk6IDhTrjh6vGq07QdsyH+i9vfEsTboM2sbAUeT4IQagYAYL4Q0H WFatKL4I00BUYI/cGfaxIO6Cc1566CI4YNkTCGf0Y6nOKMMjllZdOGXsQ3D/cm3T nyBDsIZc2PPSkC63CN9KNz3XWFiRqw4i9pmLe0KLTOsL8i+goYkSYxkWlI8rdqad HP75zsuJ8+uK/06SpwPRbodCr1CzGzMtCnXZjFhFAdL8K3zIF90= =KBfr -----END PGP SIGNATURE----- --TzPdF/YzzWOLJluu--