From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mO0BKFtg+mF2iwAAgWs5BA (envelope-from ) for ; Wed, 02 Feb 2022 11:43:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id iLuDJFtg+mHOXAAAauVa8A (envelope-from ) for ; Wed, 02 Feb 2022 11:43:39 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EE94F2F8CC for ; Wed, 2 Feb 2022 11:43:38 +0100 (CET) Received: from localhost ([::1]:33672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nFD6v-0007qU-2Q for larch@yhetil.org; Wed, 02 Feb 2022 05:43:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFD6M-0007G7-DC for bug-guix@gnu.org; Wed, 02 Feb 2022 05:43:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57661) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nFD6M-0006mR-3v for bug-guix@gnu.org; Wed, 02 Feb 2022 05:43:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nFD6L-0000yu-U5 for bug-guix@gnu.org; Wed, 02 Feb 2022 05:43:01 -0500 Subject: bug#52963: freedroidrpg: build failure Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Wed, 02 Feb 2022 10:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 52963 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Leo Famulari Received: via spool by 52963-done@debbugs.gnu.org id=D52963.16437985463716 (code D ref 52963); Wed, 02 Feb 2022 10:43:01 +0000 Received: (at 52963-done) by debbugs.gnu.org; 2 Feb 2022 10:42:26 +0000 Received: from localhost ([127.0.0.1]:51556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFD5l-0000xq-Gs for submit@debbugs.gnu.org; Wed, 02 Feb 2022 05:42:25 -0500 Received: from flashner.co.il ([178.62.234.194]:38500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFD5h-0000xa-M5 for 52963-done@debbugs.gnu.org; Wed, 02 Feb 2022 05:42:24 -0500 Received: from localhost (unknown [31.210.177.79]) by flashner.co.il (Postfix) with ESMTPSA id 3E666404EF; Wed, 2 Feb 2022 10:42:15 +0000 (UTC) Date: Wed, 2 Feb 2022 12:41:42 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Leo Famulari , Christopher Howard , 52963-done@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="j5ZJDpr7DBTKbyhX" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 52963-done@debbugs.gnu.org, Christopher Howard Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643798619; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=HGXu9fbKmQp0ZSVpw+bN/m8sdFz/lHIcD3QkVwlzaNo=; b=FeEGHj1Jo+7JVyV7d5nY30Au/a05kHiTeWeiXavhwk+uOLdDzN4DQvaS5ESZxJMG1JEjD4 CyEvc5f1LN3QDqIO8i0d5ENtuH7XB3zi0Sg3Zo/w2Pu+SzqphW3PgnbIgB7QDCPtgUBC3L CSt+mXx3MtbtmVTsjl4y0XIuDQk8VkhtkhZbKbU7GJuGCiEd7lmEWYI9VpaToCRH8kpnNL 1gr8M4Ps85p85RH1lO+tBtJcZeHalKqYogr1xDeMVnNpQ8B+jeLc5BKksB9HfoFnXFipLZ joJ4SVmRs2GXlC+oSyjVj8SMkIimAjLPbWCdpCvBgTSKsHStbAYrEZoeebrNlw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643798619; a=rsa-sha256; cv=none; b=d/v0AO4LTzp2q0/1KPmXKQCbnmK3Nb1XDs5EMxGGrdUa294L5LKywtDhKhh2SuC19CQIfd nrwPINXIYIXuHHYUWQ7EWsIj1IuihGNVpbSUUNCu8azoPOYkjQfR/mQ2hbVbhyu4uPjCox 7yTccgrd0BKbTXZJ94as/CjlcKojfn9nOr8/cXgpo3jfzKVS+L5BwVX5ppAZOekeIdU4Er 0vL+yJmNG1xEhC0bW6NjiKQBg7+EgVQmqZuNNjOH2wkTMpWrMEe17wt1b/CiylsAm6mPgF 25esMUOE/bZHly5yiI5z64FfanZ6kmjXoPo0DEFVXJFeWsePZ655PhjoPgZPaA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.73 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: EE94F2F8CC X-Spam-Score: -4.73 X-Migadu-Scanner: scn1.migadu.com X-TUID: STi3VGuHL3rs --j5ZJDpr7DBTKbyhX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 05, 2022 at 11:58:20PM -0500, Leo Famulari wrote: > On Sun, Jan 02, 2022 at 02:40:55PM -0500, Leo Famulari wrote: > > On Sun, Jan 02, 2022 at 10:11:01AM -0900, Christopher Howard wrote: > > > Package "freedroidrpg" fails to build: > > [...] > > > ld: addon_crafting_ui.o:(.bss+0x0): multiple definition of `tux_rende= ring'; action.o:(.bss+0x0): first defined here > >=20 > > I think we need to build the package with -fcommon. This is a typical > > problem with unmaintained or old codebases, now that we have switched to > > GCC 10. > >=20 > > Are you able to test it? Check the commit log for examples. >=20 > I tried this with the attached patch, but the build failed due to issues > with how it finds SDL: It looks like you missed the space after '/include/SDL' for sdl-mixer when you added '-fcommon'. In any case, it's been fixed by Tobias so I'm closing the bug. > ------ > gcc -DHAVE_CONFIG_H -I. -I.. -DFD_DATADIR=3D'"/gnu/store/kjwi84vzlgxxj0s= 19nsmfblpipk5rlm6-freedroidrpg-0.16.1/share/freedroidrpg"' -I../lua -DLOCAL= EDIR=3D'"/gnu/store/kjwi84vzlgxxj0s19nsmfblpipk5rlm6-freedroidrpg-0.16.1/sh= are/locale"' -I/gnu/store/l4k60q5jm9g2f3jslnhjsldls0l4vf9q-sdl-1.2.15/incl= ude/SDL -D_GNU_SOURCE=3D1 -D_REENTRANT -pipe -Wall -Wno-format-zero-length= -ffast-math -I/gnu/store/2qfzwl2k819cdp57xwikhp0i3sl27hma-sdl-gfx-2.0.26/i= nclude/SDL -I/gnu/store/h9b8d63bxyjd5hl1mdmicrvl4rhz87vp-sdl-image-1.2.12/i= nclude/SDL -I/gnu/store/4n31akz1025w8c9yjfa5mwf9b2q2vv83-sdl-mixer-1.2.12/i= nclude/SDL-fcommon -MT armor.o -MD -MP -MF $depbase.Tpo -c -o armor.o armor= =2Ec &&\ > mv -f $depbase.Tpo $depbase.Po > In file included from struct.h:30, > from animate.c:33: > system.h:132:10: fatal error: SDL_mixer.h: No such file or directory > 132 | #include > | ^~~~~~~~~~~~~ > In file included from struct.h:30, > from addon_crafting_ui.c:24: > system.h:132:10: fatal error: SDL_mixer.h: No such file or directory > 132 | #include > | ^~~~~~~~~~~~~ > compilation terminated. > compilation terminated. > make[3]: *** [Makefile:663: addon_crafting_ui.o] Error 1 > make[3]: *** Waiting for unfinished jobs.... > make[3]: *** [Makefile:663: animate.o] Error 1 > In file included from action.c:32: > system.h:132:10: fatal error: SDL_mixer.h: No such file or directory > 132 | #include > | ^~~~~~~~~~~~~ > compilation terminated. > In file included from armor.c:25: > system.h:132:10: fatal error: SDL_mixer.h: No such file or directory > 132 | #include > | ^~~~~~~~~~~~~ > compilation terminated. > make[3]: *** [Makefile:663: action.o] Error 1 > make[3]: *** [Makefile:663: armor.o] Error 1 > make[3]: Leaving directory '/tmp/guix-build-freedroidrpg-0.16.1.drv-0/fre= edroidrpg-0.16.1/src' > make[2]: *** [Makefile:352: all] Error 2 > make[2]: Leaving directory '/tmp/guix-build-freedroidrpg-0.16.1.drv-0/fre= edroidrpg-0.16.1/src' > make[1]: *** [Makefile:474: all-recursive] Error 1 > make[1]: Leaving directory '/tmp/guix-build-freedroidrpg-0.16.1.drv-0/fre= edroidrpg-0.16.1' > make: *** [Makefile:354: all] Error 2 > error: in phase 'build': uncaught exception: > %exception #<&invoke-error program: "make" arguments: ("-j" "4") exit-sta= tus: 2 term-signal: #f stop-signal: #f>=20 > phase `build' failed after 2.6 seconds > ------ > From 6c9bbda796c3528f018bd4590238aeebcbe81feb Mon Sep 17 00:00:00 2001 > From: Leo Famulari > Date: Wed, 5 Jan 2022 23:54:33 -0500 > Subject: [PATCH] gnu: FreedroidRPG: Fix build with GCC 10? >=20 > * gnu/packages/games.scm (freedroidrpg)[arguments]: Add -fcommon to CFLAG= S. > --- > gnu/packages/games.scm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > index bfd566aac0..e4ddcf8aea 100644 > --- a/gnu/packages/games.scm > +++ b/gnu/packages/games.scm > @@ -1365,7 +1365,8 @@ (define-public freedroidrpg > (string-append "CFLAGS=3D" > "-I" (assoc-ref %build-inputs "sdl-gfx") "/includ= e/SDL " > "-I" (assoc-ref %build-inputs "sdl-image") "/incl= ude/SDL " > - "-I" (assoc-ref %build-inputs "sdl-mixer") "/incl= ude/SDL") > + "-I" (assoc-ref %build-inputs "sdl-mixer") "/incl= ude/SDL" > + "-fcommon") ; Fix build with GCC 10 > "--enable-opengl") > ;; FIXME: the test suite fails with the following error output: > ;; 4586 Segmentation fault env SDL_VIDEODRIVER=3Ddummy \ > --=20 > 2.34.0 >=20 --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --j5ZJDpr7DBTKbyhX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmH6X+MACgkQQarn3Mo9 g1EYjg//R8w4FW80FtjQepLBcIOdOfLkhE+UCiPkUihvVeKHQdK4/3TBzMr19I+T +3BzWf0O8aLPDnb9Cjbz6mL3aSZp9gHZDNYfFpXP8jMaJlqrtseMM2X/6t3oz1Kp 7U1Ut92LGQbhco3A1AfMH/WRfNx/H5EGkStHgnNo17QYG09eCRBOKtiR0l6dwZEM 2oEYjz+ux09jazFCV5O/p2oZwy18yK1hIP+IjgED5p24PvM1ssBdWBZ7VfWuoPGe ZQADBBWgO3157IqoUYKv2LmAfXSqvmgjfSAmqCbRNdV7YlMbv2NifHTbxLSGyFP1 PtrCQPUOjnvTSGqaryV5LAV+a1jZjz1Zccqv3sUJ/HGTKSVE+DcMcafbO+RHVrQ8 4dYm79lxPymy/pvuFBgwKAhTRqVFK1mtbu74p7GXOPLIVd+1iphz8BYYPbWM+zfT i18e+ujUr6XBZgGJNwQEA5bn8bRZ3pRzara8KdKsMkoaOYB6CfFblZHqgO++e+aG qetLzdt6DesgcxyHJcJB6/esu8cWxRIX9RrqCon6fBvgEAJUNWipFAoYe62UVdBG CR5AsJqa4RLzZozPh8HdXVbXxDgTPGSgiHLZf67Hv0qKKNrvtsdwosNsDL+lJ59V 0HaBxnA6DX2uYN8yn6K5z6oobHzpkL043sT7A5wIOmAsI/uBvVU= =4+GA -----END PGP SIGNATURE----- --j5ZJDpr7DBTKbyhX--