bug#53544: [installer] Trying to edit the generated config.scm crashes the installer

bug#53544: [installer] Trying to edit the generated config.scm crashes the installer

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

While testing the installer built from the current master branch, we
found that trying to edit the generated config.scm crashes the
installer. Screenshot attached.

I built the installer like this:

$ guix environment guix -- ./pre-inst-env guix system image -t uncompressed-iso9660 --label="GUIX_x86_64-linux-leo" --system=x86_64-linux gnu/system/install.scm

I created a disk to install it with QEMU:

$ qemu-img create -f qcow2 guix-system.img 50G

And I ran the installer like this:

$ qemu-system-x86_64 -m 1024 -smp 1 -enable-kvm -nic user,model=virtio-net-pci -boot menu=on,order=d -device virtio-blk,drive=myhd -drive if=none,file=guix-system.img,id=myhd -drive media=cdrom,file=my-image.iso

I proceeded to select the default answers for all questions: no desktop,
the default networking-related services, DHCP network provider, guided
partitioning using the entire disk.

At the end, it shows the generated configuration, and crashes when I
select "edit". Unfortunately, the installer becomes unresponsive when
this happens, so I cannot scroll down and read the entire backtrace.

[-- Attachment #2: 2022-01-25-230958_895x700_scrot.png --]
[-- Type: image/png, Size: 127965 bytes --]

bug#53544: [installer] Trying to edit the generated config.scm crashes the installer

[Mathieu Othacehe]

Hello Leo,

> At the end, it shows the generated configuration, and crashes when I
> select "edit". Unfortunately, the installer becomes unresponsive when
> this happens, so I cannot scroll down and read the entire backtrace.

I followed the exact same steps on Guix commit
4943ac86e4f95a2e14fd209f3fdaac74a0d9ca2e and could not reproduce the
issue. It was possibly fixed by the wip-harden-installer branch
merge. Could you please confirm that you have the same behaviour
locally?

Thanks,

Mathieu

bug#53544: [installer] Trying to edit the generated config.scm crashes the installer

[Leo Famulari]

On Wed, Feb 02, 2022 at 06:23:04PM +0100, Mathieu Othacehe wrote:
> I followed the exact same steps on Guix commit
> 4943ac86e4f95a2e14fd209f3fdaac74a0d9ca2e and could not reproduce the
> issue. It was possibly fixed by the wip-harden-installer branch
> merge. Could you please confirm that you have the same behaviour
> locally?

Indeed, it must have been fixed by the recent changes from that branch.
Thanks!