bug#53332: [version-1.4.0] python-black fails sanity-check

bug#53332: [version-1.4.0] python-black fails sanity-check

[Leo Famulari]

Since the version-1.4.0 merge, python-black fails the sanity-check
phase:

------
starting phase `sanity-check'
validating 'black' /gnu/store/s2lic2m7cxzzfc19cans1i6q494484qm-python-black-21.12b0/lib/python3.9/site-packages
...checking requirements: ERROR: black==21.12b0 ContextualVersionConflict(tomli 2.0.0 (/gnu/store/4k52mqy3c7dkgfmxgl21lzq3k9vx6gz5-python-tomli-2.0.0/lib/python3.9/site-packages), Requirement.parse('tomli<2.0.0,>=0.2.6'), {'black'})
error: in phase 'sanity-check': uncaught exception:
%exception #<&invoke-error program: "python" arguments: ("/gnu/store/35ix1m6m8a5s21j02ajhdyqxb2xkshfb-sanity-check.py" "/gnu/store/s2lic2m7cxzzfc19cans1i6q494484qm-python-black-21.12b0/lib/python3.9/site-packages") exit-status: 1 term-signal: #f stop-signal: #f> 
phase `sanity-check' failed after 0.2 seconds
command "python" "/gnu/store/35ix1m6m8a5s21j02ajhdyqxb2xkshfb-sanity-check.py" "/gnu/store/s2lic2m7cxzzfc19cans1i6q494484qm-python-black-21.12b0/lib/python3.9/site-packages" failed with status 1
builder for `/gnu/store/fi5h4bk3qqyisdsp5lf35104sdaiv0vh-python-black-21.12b0.drv' failed with exit code 1
build of /gnu/store/fi5h4bk3qqyisdsp5lf35104sdaiv0vh-python-black-21.12b0.drv failed
------

Indeed, python-tomli was updated to 2.0.0, which is not considered
compatible with python-black.

This breaks 240 dependent packages.

bug#53332: [version-1.4.0] python-black fails sanity-check

[Leo Famulari]

On Mon, Jan 17, 2022 at 07:44:05PM -0500, Leo Famulari wrote:
> Indeed, python-tomli was updated to 2.0.0, which is not considered
> compatible with python-black.
> 
> This breaks 240 dependent packages.

It's unfortunate that tomli itself has thousands of dependent packages.

Things were fine on the version-1.4.0 branch, with an *older* version of
python-black:

https://ci.guix.gnu.org/build/359319/details

It's surprising that later versions of python-black would be less
compatible with its dependencies, but that's what has happened:

https://ci.guix.gnu.org/search?query=spec%3Amaster+system%3Ax86_64-linux+python-black

Maxim, do you remember why you updated python-tomli? Marius, do you
remember why you updated python-black? I could use some advice about how
to untangle this.

bug#53332: [version-1.4.0] python-black fails sanity-check

[Maxim Cournoyer]

Hello,

Leo Famulari <leo@famulari.name> writes:

> On Mon, Jan 17, 2022 at 07:44:05PM -0500, Leo Famulari wrote:
>> Indeed, python-tomli was updated to 2.0.0, which is not considered
>> compatible with python-black.
>> 
>> This breaks 240 dependent packages.
>
> It's unfortunate that tomli itself has thousands of dependent packages.
>
> Things were fine on the version-1.4.0 branch, with an *older* version of
> python-black:
>
> https://ci.guix.gnu.org/build/359319/details
>
> It's surprising that later versions of python-black would be less
> compatible with its dependencies, but that's what has happened:
>
> https://ci.guix.gnu.org/search?query=spec%3Amaster+system%3Ax86_64-linux+python-black
>
> Maxim, do you remember why you updated python-tomli? Marius, do you
> remember why you updated python-black? I could use some advice about how
> to untangle this.

The python-tomli brought a cleaner bootstrap path, IIRC.

I fixed python-black by relaxing its requirement in
d849be7b5fe7d6f20f9a46793d8ba6ca2a3a54ba.

Closing.

Thanks for the report!

Maxim