unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <marius@gnu.org>
Cc: Olivier Dion <olivier.dion@polymtl.ca>,
	53238@debbugs.gnu.org,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: bug#53238: [PATCH] gnu: tree: Remove stddata feature.
Date: Sun, 16 Jan 2022 13:06:01 -0500	[thread overview]
Message-ID: <YeReiaoZyCY/Xny4@jasmine.lan> (raw)
In-Reply-To: <877daz8ve1.fsf@gnu.org>

On Sun, Jan 16, 2022 at 06:04:22PM +0100, Marius Bakke wrote:
> After some consideration (and emails with tree author), I think the best
> solution is to patch 'password-store' so that it DTRT even in the
> presence of fd 3.
> 
> I sent a patch to that effect upstream:
> 
>   https://lists.zx2c4.com/pipermail/password-store/2022-January/004563.html
> 
> ...and have local patches to apply that in Guix and revert
> bd4f314bbacaaa56751be3a4769f2082be747d24 and
> a40ac6271578ea061a8a07b2adbd6032a690ca70.
> 
> WDYT?

Definitely, this is the right approach. I didn't participate in this
bugfix but I think that removing or adding features to packages is not
something we should be doing at the level of the distro, except with
upstream coordination. Reporting this issue to password-store should
have been one of the first steps we took.




  reply	other threads:[~2022-01-16 18:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fee834af05b189e4efdf06977a2ccb8935aa1277.1642105304.git.olivier.dion@polymtl.ca>
     [not found] ` <87ee5bcqhy.fsf@nckx>
     [not found]   ` <87ee5bwdzw.fsf@laura>
     [not found]     ` <87a6fzchid.fsf@nckx>
2022-01-15 14:37       ` bug#53238: [PATCH] gnu: tree: Remove stddata feature Tobias Geerinckx-Rice via Bug reports for GNU Guix
     [not found]     ` <87r19bxofo.fsf_-_@gmail.com>
2022-01-16 17:04       ` Marius Bakke
2022-01-16 18:06         ` Leo Famulari [this message]
2022-01-17 17:37           ` Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YeReiaoZyCY/Xny4@jasmine.lan \
    --to=leo@famulari.name \
    --cc=53238@debbugs.gnu.org \
    --cc=marius@gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=olivier.dion@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).