From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4awaIyd31mHZDQAAgWs5BA (envelope-from ) for ; Thu, 06 Jan 2022 05:59:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 2Jw4Gyd31mHNlwAAG6o9tA (envelope-from ) for ; Thu, 06 Jan 2022 05:59:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A84C63D308 for ; Thu, 6 Jan 2022 05:59:18 +0100 (CET) Received: from localhost ([::1]:39582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5Krt-0004Ke-PV for larch@yhetil.org; Wed, 05 Jan 2022 23:59:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Krf-0004KS-UI for bug-guix@gnu.org; Wed, 05 Jan 2022 23:59:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46536) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5Kre-0000pM-5y for bug-guix@gnu.org; Wed, 05 Jan 2022 23:59:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5Krd-0002Z9-VN for bug-guix@gnu.org; Wed, 05 Jan 2022 23:59:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52963: freedroidrpg: build failure Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 06 Jan 2022 04:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52963 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Christopher Howard Received: via spool by 52963-submit@debbugs.gnu.org id=B52963.16414451139820 (code B ref 52963); Thu, 06 Jan 2022 04:59:01 +0000 Received: (at 52963) by debbugs.gnu.org; 6 Jan 2022 04:58:33 +0000 Received: from localhost ([127.0.0.1]:39439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5KrA-0002YJ-Vi for submit@debbugs.gnu.org; Wed, 05 Jan 2022 23:58:33 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:48299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5Kr6-0002Y0-V2 for 52963@debbugs.gnu.org; Wed, 05 Jan 2022 23:58:30 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 8E68632015ED; Wed, 5 Jan 2022 23:58:22 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 05 Jan 2022 23:58:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=VVyVFViA1AJE6qxfw11nAft1 DipgGJIdlH+PfQQdl9g=; b=zZecUiGSdqWu6V3cv+TidlulevIgEphaQZ+/8ga1 UcjgBXakkIrpnrum16PhfvUAynrxHXLH416T+RZ0vBFPUfUyO7Z1f6RbP3nmx+vO afFX4XnO5eQLXLk4VLmosievsSjZVccAVYNeOp5ogsen/gjXvDFUExeAVp8GEbeA eps= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=VVyVFV iA1AJE6qxfw11nAft1DipgGJIdlH+PfQQdl9g=; b=Fj1US6qcOqrUH0vD9KTGMZ 4YBw4je8DthBh+1FluEEV2vohtBtgMjuu42ewK3/PLMm32kTi7Kjxxxzn0SSEOyR AvBn2pjwipUxKp8ycyem598VUN5H9YDQM3Jf3juLiIX7DNLIwHc5A+Ww5L6MJMvx rwdCTdFbXxeM7SWP/Z77OBfIALdBhST41V5YWbXPG7YxjzdlY2irUOLmuOaVgQoc n+Dfuw3s5VGBeLEwU0FsL8R+2lj2fhDrAjLxwgjy7iZ8MT/g9v3rQ1ub3VOqKrV/ n1B/z1HlHH1c65vbISy125tWLan7R/TqjNgpbVzGdI2nXQ51lcaKen5afZgL8EqQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudefjedgudehfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepudekveegteekleetgfeitdejgfejkeffudethedvhfeukeduleeikeejfeeh ffetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplh gvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 5 Jan 2022 23:58:21 -0500 (EST) Date: Wed, 5 Jan 2022 23:58:20 -0500 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Odwb4doX/X+OcAPe" Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 52963@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641445159; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=VVyVFViA1AJE6qxfw11nAft1DipgGJIdlH+PfQQdl9g=; b=uDdDPcwoz74Z5H3WUrfbvzOXuvAdbbbKy9umRPD66DC8CwkybVEs4n/wECvDtE3CHmqMUL kLSi4UMiUQKW40wWDP78bPCrEP+Z1pYe1FU9jsC0N8InH8ICVmqHeLh1YsvVI69NSbekmy 8yegFsyR5R0eSt6p50ZEVZlihbG2XaFXIQN0tyRVVqgK3Hzf2GTWAso8pwX0HdnJ7BMB7k pze2fDGeKOTB5ZYc/Y10bttMwSuFRagDzF24SfZy4rY+w47P+xKn6yj1ccMLdwVaA3xyWi lav1dbaSOwzIPbFJJgBTg1ATq0XBf7/be9o5UeF1DiwG9xkaULryP7dSeSUb7g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641445159; a=rsa-sha256; cv=none; b=u0PGDBodSbFfuNDfMV9Cqxc7NWZcIwIUvf2K6ZPvkFdzW3kBwDHLF4soBb5OBgHgp61nch m2aPJypvkd9ywo1DT/fseCIGjunR2Dxp4lF1KewLkvvlWDyN/0aTCFdLjGkZUzd1j1T1ea sH2UOiVyvhlBXy3YF1RCjLajMGsdVsQNKfHLfUNNJHW/XRKzju08DpyAU82nQv4293UwE0 jQ3pLoqQS7J9GgHFxaVTj3GkO5TFN9TTavNTU3VzJ6HuTd0UcrrDIdW+DzuF4bAqJhxDQA k9E6if/B8+cr2dK/DUoJYJJpErhZZ/Gyr3SJ/rozEZj64DwsYCQGlSYi2/yO8A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=zZecUiGS; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=Fj1US6qc; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.30 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=zZecUiGS; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b=Fj1US6qc; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A84C63D308 X-Spam-Score: -4.30 X-Migadu-Scanner: scn1.migadu.com X-TUID: gZ156k/Ma+RF --Odwb4doX/X+OcAPe Content-Type: multipart/mixed; boundary="HDxsiaCMOuPZ7cxG" Content-Disposition: inline --HDxsiaCMOuPZ7cxG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 02, 2022 at 02:40:55PM -0500, Leo Famulari wrote: > On Sun, Jan 02, 2022 at 10:11:01AM -0900, Christopher Howard wrote: > > Package "freedroidrpg" fails to build: > [...] > > ld: addon_crafting_ui.o:(.bss+0x0): multiple definition of `tux_renderi= ng'; action.o:(.bss+0x0): first defined here >=20 > I think we need to build the package with -fcommon. This is a typical > problem with unmaintained or old codebases, now that we have switched to > GCC 10. >=20 > Are you able to test it? Check the commit log for examples. I tried this with the attached patch, but the build failed due to issues with how it finds SDL: ------ gcc -DHAVE_CONFIG_H -I. -I.. -DFD_DATADIR=3D'"/gnu/store/kjwi84vzlgxxj0s19= nsmfblpipk5rlm6-freedroidrpg-0.16.1/share/freedroidrpg"' -I../lua -DLOCALED= IR=3D'"/gnu/store/kjwi84vzlgxxj0s19nsmfblpipk5rlm6-freedroidrpg-0.16.1/shar= e/locale"' -I/gnu/store/l4k60q5jm9g2f3jslnhjsldls0l4vf9q-sdl-1.2.15/includ= e/SDL -D_GNU_SOURCE=3D1 -D_REENTRANT -pipe -Wall -Wno-format-zero-length -= ffast-math -I/gnu/store/2qfzwl2k819cdp57xwikhp0i3sl27hma-sdl-gfx-2.0.26/inc= lude/SDL -I/gnu/store/h9b8d63bxyjd5hl1mdmicrvl4rhz87vp-sdl-image-1.2.12/inc= lude/SDL -I/gnu/store/4n31akz1025w8c9yjfa5mwf9b2q2vv83-sdl-mixer-1.2.12/inc= lude/SDL-fcommon -MT armor.o -MD -MP -MF $depbase.Tpo -c -o armor.o armor.c= &&\ mv -f $depbase.Tpo $depbase.Po In file included from struct.h:30, from animate.c:33: system.h:132:10: fatal error: SDL_mixer.h: No such file or directory 132 | #include | ^~~~~~~~~~~~~ In file included from struct.h:30, from addon_crafting_ui.c:24: system.h:132:10: fatal error: SDL_mixer.h: No such file or directory 132 | #include | ^~~~~~~~~~~~~ compilation terminated. compilation terminated. make[3]: *** [Makefile:663: addon_crafting_ui.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[3]: *** [Makefile:663: animate.o] Error 1 In file included from action.c:32: system.h:132:10: fatal error: SDL_mixer.h: No such file or directory 132 | #include | ^~~~~~~~~~~~~ compilation terminated. In file included from armor.c:25: system.h:132:10: fatal error: SDL_mixer.h: No such file or directory 132 | #include | ^~~~~~~~~~~~~ compilation terminated. make[3]: *** [Makefile:663: action.o] Error 1 make[3]: *** [Makefile:663: armor.o] Error 1 make[3]: Leaving directory '/tmp/guix-build-freedroidrpg-0.16.1.drv-0/freed= roidrpg-0.16.1/src' make[2]: *** [Makefile:352: all] Error 2 make[2]: Leaving directory '/tmp/guix-build-freedroidrpg-0.16.1.drv-0/freed= roidrpg-0.16.1/src' make[1]: *** [Makefile:474: all-recursive] Error 1 make[1]: Leaving directory '/tmp/guix-build-freedroidrpg-0.16.1.drv-0/freed= roidrpg-0.16.1' make: *** [Makefile:354: all] Error 2 error: in phase 'build': uncaught exception: %exception #<&invoke-error program: "make" arguments: ("-j" "4") exit-statu= s: 2 term-signal: #f stop-signal: #f>=20 phase `build' failed after 2.6 seconds ------ --HDxsiaCMOuPZ7cxG Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-gnu-FreedroidRPG-Fix-build-with-GCC-10.patch" Content-Transfer-Encoding: quoted-printable =46rom 6c9bbda796c3528f018bd4590238aeebcbe81feb Mon Sep 17 00:00:00 2001 =46rom: Leo Famulari Date: Wed, 5 Jan 2022 23:54:33 -0500 Subject: [PATCH] gnu: FreedroidRPG: Fix build with GCC 10? * gnu/packages/games.scm (freedroidrpg)[arguments]: Add -fcommon to CFLAGS. --- gnu/packages/games.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index bfd566aac0..e4ddcf8aea 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -1365,7 +1365,8 @@ (define-public freedroidrpg (string-append "CFLAGS=3D" "-I" (assoc-ref %build-inputs "sdl-gfx") "/include/= SDL " "-I" (assoc-ref %build-inputs "sdl-image") "/includ= e/SDL " - "-I" (assoc-ref %build-inputs "sdl-mixer") "/includ= e/SDL") + "-I" (assoc-ref %build-inputs "sdl-mixer") "/includ= e/SDL" + "-fcommon") ; Fix build with GCC 10 "--enable-opengl") ;; FIXME: the test suite fails with the following error output: ;; 4586 Segmentation fault env SDL_VIDEODRIVER=3Ddummy \ --=20 2.34.0 --HDxsiaCMOuPZ7cxG-- --Odwb4doX/X+OcAPe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmHWduwACgkQJkb6MLrK fwiTnQ/9HixJ6QpdGr1/o0pThLSeXiHTlebMDP9Rb3tn36J5AolMls0rDRWWJJJ6 XW9HgKFujLrZ2HAkt4/x5E6pr4oPzkg+e2PUqv5CzOKJ9xv023AQ6gl7mZJx0Dgz /Vv2aC8tptC7J9eMxumqg5VEyuOFDnQE4HS93YlA1PYx0hiVGau5k3pg4xmLG1lj JcC6u4qDHfiE3qUZzLB3E72iI08kZsVm/pi2WXJ1nyK3vMKQVsfsWn6oHSdg6BjB NibpqFnoZJg99cYCtPntZsiQfoZfUAZpv2wVsgvy+9Eiurqru54q8IlnRFeylxpq lowFrx3Wly/MTgrbWZ6nbHa3FtbF8o2VH0fsP868nPzDGASsEHkKpj2e8vst+AS/ 9+nmN9ljZcJPrxzLKss9AdwvVhqmtV+8DBNc3LtIFQIR/2bswwa+ixoSJvFLccXm sTq1xOOpY6P5XVNzw3UiWXWm4HnZHMR8UuQkIUx/p3shsWWTfR+F4iIqWRP7tm4h m7Rt3fQvu/tfW+jR/wpt0tuiREjPfVWv/SPRPDzoQqkWSB1/YsQRKX8bRuniQ09c pkYiS3+VTDKJOLyAuUPyNxf4teO/zgYDZUMIpE5tY5DOMl/hE+DzzF1L/Eapo+zj 4w8SSwXMAnwIV+YIgHpFPbG64SqyBhgXWSlOjKafAFu3bE+7PUI= =hVYe -----END PGP SIGNATURE----- --Odwb4doX/X+OcAPe--