unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#52963: freedroidrpg: build failure
@ 2022-01-02 19:11 Christopher Howard
  2022-01-02 19:40 ` Leo Famulari
  0 siblings, 1 reply; 3+ messages in thread
From: Christopher Howard @ 2022-01-02 19:11 UTC (permalink / raw)
  To: 52963

[-- Attachment #1: Type: text/plain, Size: 18296 bytes --]

Package "freedroidrpg" fails to build:

```
gcc -I/gnu/store/l4k60q5jm9g2f3jslnhjsldls0l4vf9q-sdl-1.2.15/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -pipe -Wall -Wno-format-zero-length -ffast-math -I/gnu/store/2qfzwl2k819cdp57xwikhp0i3sl27hma-sdl-gfx-2.0.26/include/SDL -I/gnu/store/h9b8d63bxyjd5hl1mdmicrvl4rhz87vp-sdl-image-1.2.12/include/SDL -I/gnu/store/4n31akz1025w8c9yjfa5mwf9b2q2vv83-sdl-mixer-1.2.12/include/SDL -rdynamic -Wl,--as-needed  -o freedroidRPG action.o addon_crafting_ui.o animate.o armor.o automap.o benchmark.o BFont.o blocks.o bullet.o character.o chat.o colldet.o dynarray.o enemy.o event.o faction.o floor_tiles.o font.o game_ui.o getopt.o getopt1.o graphics.o hud.o image.o influ.o init.o input.o items.o item_upgrades.o item_upgrades_ui.o keyboard.o lang.o light.o lists.o lua.o luaconfig.o main.o map.o map_label.o menu.o misc.o mission.o npc.o obstacle.o obstacle_extension.o open_gl.o open_gl_atlas.o open_gl_debug.o pathfinder.o pngfuncs.o quest_browser_ui.o rtprof.o saveloadgame.o savestruct_internal.o scandir.o shop.o skills.o sound.o sound_effects.o string.o takeover.o text.o text_public.o view.o waypoint.o lua/luaFD.o lua/luaFD_tux.o lua/luaFD_npc.o lvledit/lvledit.o lvledit/lvledit_actions.o lvledit/lvledit_beautify_actions.o lvledit/lvledit_display.o lvledit/lvledit_enemy.o lvledit/lvledit_input.o lvledit/lvledit_map.o lvledit/lvledit_menu.o lvledit/lvledit_object_lists.o lvledit/lvledit_tools.o lvledit/lvledit_tool_move.o lvledit/lvledit_tool_place.o lvledit/lvledit_tool_select.o lvledit/lvledit_validator.o lvledit/lvledit_widgets.o lvledit/lvledit_widget_categoryselect.o lvledit/lvledit_widget_map.o lvledit/lvledit_widget_minimap.o lvledit/lvledit_widget_toolbar.o mapgen/gram_simple.o mapgen/mapgen.o mapgen/themes.o savegame/convert.o savegame/filters_0_16.o widgets/widgets.o widgets/widget_background.o widgets/widget_button.o widgets/widget_group.o widgets/widget_text.o widgets/widget_text_list.o savestruct.o version.o  ../lua/liblua.a  -L/gnu/store/l4k60q5jm9g2f3jslnhjsldls0l4vf9q-sdl-1.2.15/lib -Wl,-rpath,/gnu/store/l4k60q5jm9g2f3jslnhjsldls0l4vf9q-sdl-1.2.15/lib -lSDL -lpthread -lGL  -lm   -lvorbis -logg -lSDL_mixer -lSDL_gfx -lSDL_image -lpng -ljpeg -lz -lm 
ld: addon_crafting_ui.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: animate.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: armor.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: automap.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: benchmark.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: BFont.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: blocks.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: bullet.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: character.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: chat.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: colldet.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: dynarray.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: enemy.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: event.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: faction.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: floor_tiles.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: font.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: game_ui.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: graphics.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: hud.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: image.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: influ.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: init.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: input.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: items.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: item_upgrades.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: item_upgrades_ui.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: keyboard.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lang.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: light.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lists.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lua.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: luaconfig.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: main.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: map.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: map_label.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: menu.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: misc.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: misc.o:(.data+0xcbc8): multiple definition of `FPSover1'; main.o:(.bss+0x50): first defined here
ld: mission.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: npc.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: obstacle.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: obstacle_extension.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: open_gl.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: open_gl_atlas.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: open_gl_debug.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: pathfinder.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: quest_browser_ui.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: rtprof.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: saveloadgame.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: savestruct_internal.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: shop.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: skills.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: sound.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: sound_effects.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: string.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: takeover.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: text.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: text_public.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: view.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: view.o:(.bss+0x29490): multiple definition of `tool_place'; keyboard.o:(.bss+0x50): first defined here
ld: view.o:(.bss+0x294a0): multiple definition of `tool_move'; keyboard.o:(.bss+0x60): first defined here
ld: view.o:(.bss+0x294b0): multiple definition of `tool_select'; keyboard.o:(.bss+0x70): first defined here
ld: waypoint.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lua/luaFD_tux.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lua/luaFD_npc.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit.o:(.bss+0x2780): multiple definition of `tool_place'; keyboard.o:(.bss+0x50): first defined here
ld: lvledit/lvledit.o:(.bss+0x2790): multiple definition of `tool_move'; keyboard.o:(.bss+0x60): first defined here
ld: lvledit/lvledit.o:(.bss+0x27a0): multiple definition of `tool_select'; keyboard.o:(.bss+0x70): first defined here
ld: lvledit/lvledit_actions.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_beautify_actions.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_display.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_enemy.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_input.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_map.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_menu.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_object_lists.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_tools.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_tools.o:(.bss+0x50): multiple definition of `tool_place'; keyboard.o:(.bss+0x50): first defined here
ld: lvledit/lvledit_tools.o:(.bss+0x60): multiple definition of `tool_move'; keyboard.o:(.bss+0x60): first defined here
ld: lvledit/lvledit_tools.o:(.bss+0x70): multiple definition of `tool_select'; keyboard.o:(.bss+0x70): first defined here
ld: lvledit/lvledit_tool_move.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_tool_move.o:(.bss+0x50): multiple definition of `tool_place'; keyboard.o:(.bss+0x50): first defined here
ld: lvledit/lvledit_tool_move.o:(.bss+0x60): multiple definition of `tool_move'; keyboard.o:(.bss+0x60): first defined here
ld: lvledit/lvledit_tool_move.o:(.bss+0x70): multiple definition of `tool_select'; keyboard.o:(.bss+0x70): first defined here
ld: lvledit/lvledit_tool_place.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_tool_place.o:(.bss+0x50): multiple definition of `tool_place'; keyboard.o:(.bss+0x50): first defined here
ld: lvledit/lvledit_tool_place.o:(.bss+0x60): multiple definition of `tool_move'; keyboard.o:(.bss+0x60): first defined here
ld: lvledit/lvledit_tool_place.o:(.bss+0x70): multiple definition of `tool_select'; keyboard.o:(.bss+0x70): first defined here
ld: lvledit/lvledit_tool_select.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_tool_select.o:(.bss+0x50): multiple definition of `tool_place'; keyboard.o:(.bss+0x50): first defined here
ld: lvledit/lvledit_tool_select.o:(.bss+0x60): multiple definition of `tool_move'; keyboard.o:(.bss+0x60): first defined here
ld: lvledit/lvledit_tool_select.o:(.bss+0x70): multiple definition of `tool_select'; keyboard.o:(.bss+0x70): first defined here
ld: lvledit/lvledit_validator.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_widgets.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_widgets.o:(.bss+0x50): multiple definition of `tool_place'; keyboard.o:(.bss+0x50): first defined here
ld: lvledit/lvledit_widgets.o:(.bss+0x60): multiple definition of `tool_move'; keyboard.o:(.bss+0x60): first defined here
ld: lvledit/lvledit_widgets.o:(.bss+0x70): multiple definition of `tool_select'; keyboard.o:(.bss+0x70): first defined here
ld: lvledit/lvledit_widget_categoryselect.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_widget_map.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_widget_map.o:(.bss+0x60): multiple definition of `tool_place'; keyboard.o:(.bss+0x50): first defined here
ld: lvledit/lvledit_widget_map.o:(.bss+0x70): multiple definition of `tool_move'; keyboard.o:(.bss+0x60): first defined here
ld: lvledit/lvledit_widget_map.o:(.bss+0x80): multiple definition of `tool_select'; keyboard.o:(.bss+0x70): first defined here
ld: lvledit/lvledit_widget_minimap.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_widget_toolbar.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: lvledit/lvledit_widget_toolbar.o:(.bss+0x50): multiple definition of `tool_place'; keyboard.o:(.bss+0x50): first defined here
ld: lvledit/lvledit_widget_toolbar.o:(.bss+0x60): multiple definition of `tool_move'; keyboard.o:(.bss+0x60): first defined here
ld: lvledit/lvledit_widget_toolbar.o:(.bss+0x70): multiple definition of `tool_select'; keyboard.o:(.bss+0x70): first defined here
ld: mapgen/gram_simple.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: mapgen/gram_simple.o:(.bss+0x50): multiple definition of `dungeonmap_convert'; lvledit/lvledit_menu.o:(.bss+0x50): first defined here
ld: mapgen/gram_simple.o:(.bss+0x58): multiple definition of `dungeonmap_place_enemies'; lvledit/lvledit_menu.o:(.bss+0x58): first defined here
ld: mapgen/gram_simple.o:(.bss+0x60): multiple definition of `dungeonmap_gift'; lvledit/lvledit_menu.o:(.bss+0x60): first defined here
ld: mapgen/mapgen.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: mapgen/mapgen.o:(.bss+0x50): multiple definition of `dungeonmap_convert'; lvledit/lvledit_menu.o:(.bss+0x50): first defined here
ld: mapgen/mapgen.o:(.bss+0x58): multiple definition of `dungeonmap_place_enemies'; lvledit/lvledit_menu.o:(.bss+0x58): first defined here
ld: mapgen/mapgen.o:(.bss+0x60): multiple definition of `dungeonmap_gift'; lvledit/lvledit_menu.o:(.bss+0x60): first defined here
ld: mapgen/themes.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: mapgen/themes.o:(.bss+0x50): multiple definition of `dungeonmap_convert'; lvledit/lvledit_menu.o:(.bss+0x50): first defined here
ld: mapgen/themes.o:(.bss+0x58): multiple definition of `dungeonmap_place_enemies'; lvledit/lvledit_menu.o:(.bss+0x58): first defined here
ld: mapgen/themes.o:(.bss+0x60): multiple definition of `dungeonmap_gift'; lvledit/lvledit_menu.o:(.bss+0x60): first defined here
ld: savegame/convert.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: savegame/filters_0_16.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: widgets/widgets.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: widgets/widget_background.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: widgets/widget_button.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: widgets/widget_group.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: widgets/widget_text.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: widgets/widget_text_list.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: savestruct.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
ld: ../lua/liblua.a(loslib.o): in function `os_tmpname':
loslib.c:(.text+0x29c): warning: the use of `tmpnam' is dangerous, better use `mkstemp'
collect2: error: ld returned 1 exit status
```

My system:

```
christopher@nightshade ~$ neofetch --stdout
christopher@nightshade 
---------------------- 
OS: Guix System 637dec9d45db4df2a3e6aa565fa2c5cf6bb77768 x86_64 
Host: GA-880GM-UD2H 
Kernel: 5.15.5-gnu 
Uptime: 6 days, 14 hours, 11 mins 
Packages: 63 (guix-system), 164 (guix-user) 
Shell: bash 5.0.16 
Resolution: 1920x1200 
DE: GNOME 3.34.5 
Theme: Adwaita [GTK2/3] 
Icons: Adwaita [GTK2/3] 
Terminal: .emacs-27.2-rea 
CPU: AMD Athlon II X3 455 (3) @ 3.300GHz 
GPU: NVIDIA Quadro 2000 
Memory: 2790MiB / 7957MiB 
```

-- 
📛 Christopher Howard
🚀 gemini://gem.librehacker.com
🌐 https://portal.mozz.us/gemini/gem.librehacker.com

בראשית ברא אלהים את השמים ואת הארץ

[-- Attachment #2: zl2z53dbr64zkdjhrvl23xb3kc8isw-freedroidrpg-0.16.1.drv.bz2 --]
[-- Type: application/octet-stream, Size: 33156 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#52963: freedroidrpg: build failure
  2022-01-02 19:11 bug#52963: freedroidrpg: build failure Christopher Howard
@ 2022-01-02 19:40 ` Leo Famulari
  2022-01-06  4:58   ` Leo Famulari
  0 siblings, 1 reply; 3+ messages in thread
From: Leo Famulari @ 2022-01-02 19:40 UTC (permalink / raw)
  To: Christopher Howard; +Cc: 52963

On Sun, Jan 02, 2022 at 10:11:01AM -0900, Christopher Howard wrote:
> Package "freedroidrpg" fails to build:
[...]
> ld: addon_crafting_ui.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here

I think we need to build the package with -fcommon. This is a typical
problem with unmaintained or old codebases, now that we have switched to
GCC 10.

Are you able to test it? Check the commit log for examples.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#52963: freedroidrpg: build failure
  2022-01-02 19:40 ` Leo Famulari
@ 2022-01-06  4:58   ` Leo Famulari
  0 siblings, 0 replies; 3+ messages in thread
From: Leo Famulari @ 2022-01-06  4:58 UTC (permalink / raw)
  To: Christopher Howard; +Cc: 52963


[-- Attachment #1.1: Type: text/plain, Size: 3090 bytes --]

On Sun, Jan 02, 2022 at 02:40:55PM -0500, Leo Famulari wrote:
> On Sun, Jan 02, 2022 at 10:11:01AM -0900, Christopher Howard wrote:
> > Package "freedroidrpg" fails to build:
> [...]
> > ld: addon_crafting_ui.o:(.bss+0x0): multiple definition of `tux_rendering'; action.o:(.bss+0x0): first defined here
> 
> I think we need to build the package with -fcommon. This is a typical
> problem with unmaintained or old codebases, now that we have switched to
> GCC 10.
> 
> Are you able to test it? Check the commit log for examples.

I tried this with the attached patch, but the build failed due to issues
with how it finds SDL:

------
gcc -DHAVE_CONFIG_H -I. -I..  -DFD_DATADIR='"/gnu/store/kjwi84vzlgxxj0s19nsmfblpipk5rlm6-freedroidrpg-0.16.1/share/freedroidrpg"' -I../lua -DLOCALEDIR='"/gnu/store/kjwi84vzlgxxj0s19nsmfblpipk5rlm6-freedroidrpg-0.16.1/share/locale"'  -I/gnu/store/l4k60q5jm9g2f3jslnhjsldls0l4vf9q-sdl-1.2.15/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -pipe -Wall -Wno-format-zero-length -ffast-math -I/gnu/store/2qfzwl2k819cdp57xwikhp0i3sl27hma-sdl-gfx-2.0.26/include/SDL -I/gnu/store/h9b8d63bxyjd5hl1mdmicrvl4rhz87vp-sdl-image-1.2.12/include/SDL -I/gnu/store/4n31akz1025w8c9yjfa5mwf9b2q2vv83-sdl-mixer-1.2.12/include/SDL-fcommon -MT armor.o -MD -MP -MF $depbase.Tpo -c -o armor.o armor.c &&\
mv -f $depbase.Tpo $depbase.Po
In file included from struct.h:30,
                 from animate.c:33:
system.h:132:10: fatal error: SDL_mixer.h: No such file or directory
  132 | #include <SDL_mixer.h>
      |          ^~~~~~~~~~~~~
In file included from struct.h:30,
                 from addon_crafting_ui.c:24:
system.h:132:10: fatal error: SDL_mixer.h: No such file or directory
  132 | #include <SDL_mixer.h>
      |          ^~~~~~~~~~~~~
compilation terminated.
compilation terminated.
make[3]: *** [Makefile:663: addon_crafting_ui.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: *** [Makefile:663: animate.o] Error 1
In file included from action.c:32:
system.h:132:10: fatal error: SDL_mixer.h: No such file or directory
  132 | #include <SDL_mixer.h>
      |          ^~~~~~~~~~~~~
compilation terminated.
In file included from armor.c:25:
system.h:132:10: fatal error: SDL_mixer.h: No such file or directory
  132 | #include <SDL_mixer.h>
      |          ^~~~~~~~~~~~~
compilation terminated.
make[3]: *** [Makefile:663: action.o] Error 1
make[3]: *** [Makefile:663: armor.o] Error 1
make[3]: Leaving directory '/tmp/guix-build-freedroidrpg-0.16.1.drv-0/freedroidrpg-0.16.1/src'
make[2]: *** [Makefile:352: all] Error 2
make[2]: Leaving directory '/tmp/guix-build-freedroidrpg-0.16.1.drv-0/freedroidrpg-0.16.1/src'
make[1]: *** [Makefile:474: all-recursive] Error 1
make[1]: Leaving directory '/tmp/guix-build-freedroidrpg-0.16.1.drv-0/freedroidrpg-0.16.1'
make: *** [Makefile:354: all] Error 2
error: in phase 'build': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("-j" "4") exit-status: 2 term-signal: #f stop-signal: #f> 
phase `build' failed after 2.6 seconds
------

[-- Attachment #1.2: 0001-gnu-FreedroidRPG-Fix-build-with-GCC-10.patch --]
[-- Type: text/plain, Size: 1205 bytes --]

From 6c9bbda796c3528f018bd4590238aeebcbe81feb Mon Sep 17 00:00:00 2001
From: Leo Famulari <leo@famulari.name>
Date: Wed, 5 Jan 2022 23:54:33 -0500
Subject: [PATCH] gnu: FreedroidRPG: Fix build with GCC 10?

* gnu/packages/games.scm (freedroidrpg)[arguments]: Add -fcommon to CFLAGS.
---
 gnu/packages/games.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index bfd566aac0..e4ddcf8aea 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -1365,7 +1365,8 @@ (define-public freedroidrpg
         (string-append "CFLAGS="
                        "-I" (assoc-ref %build-inputs "sdl-gfx") "/include/SDL "
                        "-I" (assoc-ref %build-inputs "sdl-image") "/include/SDL "
-                       "-I" (assoc-ref %build-inputs "sdl-mixer") "/include/SDL")
+                       "-I" (assoc-ref %build-inputs "sdl-mixer") "/include/SDL"
+                       "-fcommon") ; Fix build with GCC 10
         "--enable-opengl")
        ;; FIXME: the test suite fails with the following error output:
        ;;   4586 Segmentation fault      env SDL_VIDEODRIVER=dummy \
-- 
2.34.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-06  4:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-02 19:11 bug#52963: freedroidrpg: build failure Christopher Howard
2022-01-02 19:40 ` Leo Famulari
2022-01-06  4:58   ` Leo Famulari

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).